Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/otlp/metrics] Add WithInitialValueMode to metrics translator #109

Merged
merged 7 commits into from
Jun 26, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 23, 2023

What does this PR do?

Motivation

Relates to #100

@mx-psi mx-psi requested a review from a team as a code owner June 23, 2023 15:04
@mx-psi mx-psi requested a review from IbraheemA June 23, 2023 15:04
@mx-psi mx-psi requested a review from songy23 June 23, 2023 15:06
@mx-psi
Copy link
Member Author

mx-psi commented Jun 23, 2023

The breaking changes report is reporting a change on a private struct:

Changes for github.com/DataDog/opentelemetry-mapping-go/pkg/otlp/metrics:
Incompatible changes:
- translatorConfig.SendMonotonic: removed
Compatible changes:
- InitialValueMode: added
make: *** [Makefile:8[6](https://github.com/DataDog/opentelemetry-mapping-go/actions/runs/5357793420/jobs/9719189185?pr=109#step:8:7): apidiff-compare] Error 1
- InitialValueModeAuto: added
- InitialValueModeDrop: added
- InitialValueModeKeep: added
- WithInitialValueMode: added
- translatorConfig.InitialValueMode: added
- translatorConfig.NumberMode: added
Incompatible changes found!

While this could be a breaking change if the struct was embedded somewhere, it is not the case. I am going to add the breaking-changes label to skip the check as this is a false positive.

@mx-psi mx-psi added the breaking-change This PR introduces a Go API breaking change label Jun 23, 2023
pkg/otlp/metrics/config.go Outdated Show resolved Hide resolved
pkg/otlp/metrics/metrics_translator.go Outdated Show resolved Hide resolved
pkg/otlp/metrics/metrics_translator.go Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from songy23 June 26, 2023 11:23
pkg/otlp/metrics/config.go Outdated Show resolved Hide resolved
pkg/otlp/metrics/config.go Outdated Show resolved Hide resolved
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@mx-psi mx-psi enabled auto-merge (squash) June 26, 2023 14:07
@mx-psi mx-psi merged commit b54d407 into main Jun 26, 2023
@mx-psi mx-psi deleted the mx-psi/counter-mode branch June 26, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This PR introduces a Go API breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants