feat(data-pipeline-ffi): add functions to manipulate span from C #994
+1,535
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leiyks
force-pushed
the
leiyks-add-span-conversion-functions
branch
5 times, most recently
from
3172f33 to
b6ff6bb
Compare
BenchmarksComparisonBenchmark execution time: 2025-07-11 14:11:23 Comparing candidate commit 5c4e725 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
BaselineOmitted due to size. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
- Coverage 71.42% 71.00% -0.43%
==========================================
Files 342 346 +4
Lines 52062 53048 +986
==========================================
+ Hits 37186 37667 +481
- Misses 14876 15381 +505
🚀 New features to boost your workflow:
|
Leiyks
force-pushed
the
leiyks-add-span-conversion-functions
branch
4 times, most recently
from
c78046e to
00df87d
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Leiyks
force-pushed
the
leiyks-add-span-conversion-functions
branch
2 times, most recently
from
cee1bc0 to
a9c6aa1
Compare
ekump
previously requested changes
Apr 7, 2025
It's an error on my part, the PR was supposed to stay in draft as it is just at the experiment level yet. |
ekump
dismissed
their stale review
PR wasn't ready for review yet, and was moved to draft.
Leiyks
force-pushed
the
leiyks-add-span-conversion-functions
branch
3 times, most recently
from
62862df to
d7d9779
Compare
Leiyks
force-pushed
the
leiyks-add-span-conversion-functions
branch
2 times, most recently
from
0e074ee to
ac9484b
Compare
bwoebi
reviewed
Apr 30, 2025
Leiyks
force-pushed
the
leiyks-add-span-conversion-functions
branch
from
0a39708 to
a03994a
Compare
bwoebi
reviewed
Apr 30, 2025
Leiyks
force-pushed
the
leiyks-add-span-conversion-functions
branch
from
abe97d7 to
ed40e83
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…fety Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
leiyks-add-span-conversion-functions
branch
from
ed40e83 to
6779847
Compare
| write_str(writer, "span_links")?; | ||
| rmp::encode::write_array_len(writer, span.span_links.len() as u32)?; | ||
| for link in span.span_links.iter() { | ||
| let mut link_len = 3; /* minimal span link: trace_id, trace_id_high, span_id */ |
There was a problem hiding this comment.
Could you extract writing a span link and a span event to their functions?
Comment on lines
+14
to
+19
| // If it's the first span make it the root | ||
| let span_id = if i == 0 { | ||
| root_span_id | ||
| } else { | ||
| root_span_id + i as u64 + 1 | ||
| }; |
There was a problem hiding this comment.
if i == 0 the root_span_id + i as u64 is root_span_id, otherwise it's a new value?
Suggested change
| // If it's the first span make it the root | |
| let span_id = if i == 0 { | |
| root_span_id | |
| } else { | |
| root_span_id + i as u64 + 1 | |
| }; | |
| // If it's the first span make it the root | |
| let span_id = root_span_id + i as u64; |
Comment on lines
+133
to
+139
| /// # Safety | ||
| /// Callers must ensure this is only used for read or drop purposes | ||
| /// that are compatible with how the memory was originally allocated. | ||
| pub const fn as_raw_parts(&self) -> (*const T, usize) { | ||
| (self.ptr, self.len) | ||
| } | ||
|
|
There was a problem hiding this comment.
Where is this used in this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add functions to create and manipulate field of Rust Span struct from C code.
Motivation
The replacement of PHP Span to Rust Span in the PHP Tracer.
Additional Notes
As I am using macros to create the functions, the tests need to be run on a nightly version of Rust.
How to test the change?
Tests have been added, and this is linked to another one in the PHP tracer. (TODO)