Skip to content

chore(lint): update nightly - #2281

Merged
gyuheon0h merged 8 commits into
mainfrom
gyuheon0h/lint-repo
Jul 27, 2026
Merged

gyuheon0h merged 8 commits into
mainfrom
gyuheon0h/lint-repo

Conversation

@gyuheon0h

@gyuheon0h gyuheon0h commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

My local nightly is latest. I've noticed that its fmt from cargo +nightly fmt differs from what CI expects.

This PR bumps nightly version, updates .precommit-config.yaml and the local Linux dockerfile. This PR also fixes new nightly clippy lints.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@gyuheon0h gyuheon0h changed the title Run cargo +nightly fmt chore(lint): run cargo +nightly fmt Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

📚 Documentation Check Results

⚠️ 1933 documentation warning(s) found

📦 libdd-alloc - 3 warning(s)

📦 libdd-common-ffi - 278 warning(s)

📦 libdd-profiling-heap-gotter - 47 warning(s)

📦 libdd-trace-obfuscation - 846 warning(s)

📦 libdd-trace-utils - 759 warning(s)


Updated: 2026-07-27 19:00:36 UTC | Commit: 8edfd2c | missing-docs job results

@github-actions

github-actions Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

🔒 Cargo Deny Results

⚠️ 5 issue(s) found, showing only errors (advisories, bans, sources)

📦 libdd-alloc - ✅ No issues

📦 libdd-common-ffi - 1 error(s)

Show output
error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:105:1
    │
105 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by [@lopopolo](https://github.com/lopopolo)) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      └── (dev) libdd-common v5.1.0
          └── libdd-common-ffi v37.0.0

advisories FAILED, bans ok, sources ok

📦 libdd-profiling-heap-gotter - ✅ No issues

📦 libdd-trace-obfuscation - 2 error(s)

Show output
error[vulnerability]: Invalid pointer dereference in `fmt::Pointer` impl for `Atomic` and `Shared` when the underlying pointer is invalid
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:62:1
   │
62 │ crossbeam-epoch 0.9.18 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
   │
   ├ ID: RUSTSEC-2026-0204
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0204
   ├ Affected versions of `fmt::Display` dereference the underlying pointer. This causes a invalid pointer dereference e.g., when a pointer created with `Atomic::null` or `Shared::null`. `fmt::Debug` impls and pre-0.9 `fmt::Display` impls, which do not dereference pointers, are not affected by this issue.
   ├ Announcement: https://github.com/crossbeam-rs/crossbeam/pull/1276
   ├ Solution: Upgrade to >=0.9.20 (try `cargo update -p crossbeam-epoch`)
   ├ crossbeam-epoch v0.9.18
     └── crossbeam-deque v0.8.5
         └── rayon-core v1.12.1
             └── rayon v1.10.0
                 └── criterion v0.5.1
                     ├── libdd-common v5.1.0
                     │   ├── libdd-capabilities-impl v3.0.0
                     │   │   └── libdd-trace-utils v9.0.0
                     │   │       ├── libdd-trace-obfuscation v5.0.0
                     │   │       └── (dev) libdd-trace-utils v9.0.0 (*)
                     │   ├── libdd-trace-obfuscation v5.0.0 (*)
                     │   └── libdd-trace-utils v9.0.0 (*)
                     ├── (dev) libdd-trace-normalization v3.0.0
                     │   └── libdd-trace-utils v9.0.0 (*)
                     ├── (dev) libdd-trace-obfuscation v5.0.0 (*)
                     └── (dev) libdd-trace-utils v9.0.0 (*)

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:186:1
    │
186 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by [@lopopolo](https://github.com/lopopolo)) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── (dev) libdd-common v5.1.0
      │   ├── libdd-capabilities-impl v3.0.0
      │   │   └── libdd-trace-utils v9.0.0
      │   │       ├── libdd-trace-obfuscation v5.0.0
      │   │       └── (dev) libdd-trace-utils v9.0.0 (*)
      │   ├── libdd-trace-obfuscation v5.0.0 (*)
      │   └── libdd-trace-utils v9.0.0 (*)
      ├── (dev) libdd-trace-normalization v3.0.0
      │   └── libdd-trace-utils v9.0.0 (*)
      ├── libdd-trace-utils v9.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-tinybytes v1.1.1
              ├── (dev) libdd-tinybytes v1.1.1 (*)
              └── libdd-trace-utils v9.0.0 (*)

advisories FAILED, bans ok, sources ok

📦 libdd-trace-utils - 2 error(s)

Show output
error[vulnerability]: Invalid pointer dereference in `fmt::Pointer` impl for `Atomic` and `Shared` when the underlying pointer is invalid
   ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:61:1
   │
61 │ crossbeam-epoch 0.9.18 registry+https://github.com/rust-lang/crates.io-index
   │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
   │
   ├ ID: RUSTSEC-2026-0204
   ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0204
   ├ Affected versions of `fmt::Display` dereference the underlying pointer. This causes a invalid pointer dereference e.g., when a pointer created with `Atomic::null` or `Shared::null`. `fmt::Debug` impls and pre-0.9 `fmt::Display` impls, which do not dereference pointers, are not affected by this issue.
   ├ Announcement: https://github.com/crossbeam-rs/crossbeam/pull/1276
   ├ Solution: Upgrade to >=0.9.20 (try `cargo update -p crossbeam-epoch`)
   ├ crossbeam-epoch v0.9.18
     └── crossbeam-deque v0.8.5
         └── rayon-core v1.12.1
             └── rayon v1.10.0
                 └── criterion v0.5.1
                     ├── libdd-common v5.1.0
                     │   ├── libdd-capabilities-impl v3.0.0
                     │   │   └── libdd-trace-utils v9.0.0
                     │   │       └── (dev) libdd-trace-utils v9.0.0 (*)
                     │   └── libdd-trace-utils v9.0.0 (*)
                     ├── (dev) libdd-trace-normalization v3.0.0
                     │   └── libdd-trace-utils v9.0.0 (*)
                     └── (dev) libdd-trace-utils v9.0.0 (*)

error[unsound]: Rand is unsound with a custom logger using `rand::rng()`
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:181:1
    │
181 │ rand 0.8.5 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unsound advisory detected
    │
    ├ ID: RUSTSEC-2026-0097
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2026-0097
    ├ It has been reported (by [@lopopolo](https://github.com/lopopolo)) that the `rand` library is [unsound](https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#soundness-of-code--of-a-library) (i.e. that safe code using the public API can cause Undefined Behaviour) when all the following conditions are met:
      
      - The `log` and `thread_rng` features are enabled
      - A [custom logger](https://docs.rs/log/latest/log/#implementing-a-logger) is defined
      - The custom logger accesses `rand::rng()` (previously `rand::thread_rng()`) and calls any `TryRng` (previously `RngCore`) methods on `ThreadRng`
      - The `ThreadRng` (attempts to) reseed while called from the custom logger (this happens every 64 kB of generated data)
      - Trace-level logging is enabled or warn-level logging is enabled and the random source (the `getrandom` crate) is unable to provide a new seed
      
      `TryRng` (previously `RngCore`) methods for `ThreadRng` use `unsafe` code to cast `*mut BlockRng<ReseedingCore>` to `&mut BlockRng<ReseedingCore>`. When all the above conditions are met this results in an aliased mutable reference, violating the Stacked Borrows rules. Miri is able to detect this violation in sample code. Since construction of [aliased mutable references is Undefined Behaviour](https://doc.rust-lang.org/stable/nomicon/references.html), the behaviour of optimized builds is hard to predict.
    ├ Announcement: https://github.com/rust-random/rand/pull/1763
    ├ Solution: Upgrade to >=0.10.1 OR <0.10.0, >=0.9.3 OR <0.9.0, >=0.8.6 (try `cargo update -p rand`)
    ├ rand v0.8.5
      ├── (dev) libdd-common v5.1.0
      │   ├── libdd-capabilities-impl v3.0.0
      │   │   └── libdd-trace-utils v9.0.0
      │   │       └── (dev) libdd-trace-utils v9.0.0 (*)
      │   └── libdd-trace-utils v9.0.0 (*)
      ├── (dev) libdd-trace-normalization v3.0.0
      │   └── libdd-trace-utils v9.0.0 (*)
      ├── libdd-trace-utils v9.0.0 (*)
      └── proptest v1.5.0
          └── (dev) libdd-tinybytes v1.1.1
              ├── (dev) libdd-tinybytes v1.1.1 (*)
              └── libdd-trace-utils v9.0.0 (*)

advisories FAILED, bans ok, sources ok

Updated: 2026-07-27 19:00:33 UTC | Commit: 8edfd2c | dependency-check job results

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 80.00%
• Overall Coverage: 74.73% (+0.07%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a22ddeb | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-07-27 19:02:20

Comparing candidate commit a22ddeb in PR branch gyuheon0h/lint-repo with baseline commit caa732f in branch main.

Found 16 performance improvements and 10 performance regressions! Performance is the same for 116 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:normalization/normalize_service/normalize_service/[empty string]

  • 🟩 execution_time [-2.727µs; -2.701µs] or [-7.128%; -7.061%]
  • 🟩 throughput [+1986503.565op/s; +2005373.400op/s] or [+7.600%; +7.672%]

scenario:otlp/e2e_json/1x1000

  • 🟥 execution_time [+347.751µs; +350.198µs] or [+8.488%; +8.547%]

scenario:otlp/encode_json/1x1000

  • 🟥 execution_time [+344.544µs; +345.115µs] or [+19.406%; +19.438%]

scenario:otlp/encode_protobuf/1x1000

  • 🟩 execution_time [-46.594µs; -45.537µs] or [-4.228%; -4.132%]

scenario:vec_map/contains_key/8

  • 🟩 execution_time [-4.375ns; -4.304ns] or [-5.544%; -5.455%]
  • 🟩 throughput [+5851034.464op/s; +5948624.755op/s] or [+5.772%; +5.868%]

scenario:vec_map/get_hit/128

  • 🟩 execution_time [-3.025µs; -3.015µs] or [-18.218%; -18.162%]
  • 🟩 throughput [+1711548.552op/s; +1716854.730op/s] or [+22.200%; +22.269%]

scenario:vec_map/get_hit/16

  • 🟩 execution_time [-49.592ns; -49.285ns] or [-19.844%; -19.722%]
  • 🟩 throughput [+15741886.924op/s; +15837473.168op/s] or [+24.587%; +24.736%]

scenario:vec_map/get_hit/64

  • 🟩 execution_time [-752.304ns; -748.603ns] or [-17.121%; -17.037%]
  • 🟩 throughput [+2992122.136op/s; +3008036.536op/s] or [+20.543%; +20.652%]

scenario:vec_map/get_hit/8

  • 🟩 execution_time [-12.454ns; -12.418ns] or [-18.769%; -18.713%]
  • 🟩 throughput [+27767309.737op/s; +27843181.679op/s] or [+23.032%; +23.095%]

scenario:vec_map/get_miss/128

  • 🟥 execution_time [+3.783ns; +3.992ns] or [+4.932%; +5.204%]

scenario:vec_map/get_miss/16

  • 🟩 execution_time [-17.081ns; -16.649ns] or [-62.698%; -61.112%]

scenario:vec_map/get_miss/64

  • 🟩 execution_time [-21.375ns; -21.295ns] or [-41.907%; -41.750%]

scenario:vec_map/get_miss/8

  • 🟩 execution_time [-12.606ns; -12.407ns] or [-68.331%; -67.253%]

scenario:vec_map/get_mut/128

  • 🟥 execution_time [+2.076µs; +2.159µs] or [+15.091%; +15.698%]
  • 🟥 throughput [-1266774.947op/s; -1216588.483op/s] or [-13.610%; -13.071%]

scenario:vec_map/get_mut/16

  • 🟥 execution_time [+22.326ns; +34.587ns] or [+8.006%; +12.403%]
  • 🟥 throughput [-6459338.073op/s; -4225201.477op/s] or [-11.142%; -7.288%]

scenario:vec_map/get_mut/64

  • 🟥 execution_time [+443.973ns; +484.190ns] or [+11.487%; +12.528%]
  • 🟥 throughput [-1861076.792op/s; -1700909.472op/s] or [-11.230%; -10.264%]

scenario:vec_map/get_mut/8

  • 🟥 execution_time [+3.492ns; +8.306ns] or [+4.008%; +9.534%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

@yannham

yannham commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

I have the same problem :/ running cargo +nightly fmt locally always try to change this file as well. Maybe there's a nightly version mismatch somewhere between the CI and the repo?

@gyuheon0h
gyuheon0h force-pushed the gyuheon0h/lint-repo branch from 598ee98 to 3751612 Compare July 27, 2026 16:02
@gyuheon0h gyuheon0h changed the title chore(lint): run cargo +nightly fmt chore(lint): update nightly Jul 27, 2026
@gyuheon0h
gyuheon0h marked this pull request as ready for review July 27, 2026 16:03
@gyuheon0h
gyuheon0h requested review from a team as code owners July 27, 2026 16:03
@gyuheon0h
gyuheon0h requested a review from yannham July 27, 2026 16:03
@dd-octo-sts

dd-octo-sts Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 88.18 MB 88.18 MB -0% (-368 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.13 MB 8.13 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.46 MB 99.46 MB -0% (-376 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.93 MB 10.93 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.59 MB 26.59 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 89.18 KB 89.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 191.42 MB 191.38 MB --.02% (-40.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 1.04 GB 1.04 GB +0% (+2.35 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.66 MB 8.66 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 89.18 KB 89.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.36 MB 25.36 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 50.56 MB 50.56 MB -0% (-86 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.16 MB 23.16 MB -0% (-512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 90.58 KB 90.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 196.09 MB 196.07 MB --.01% (-24.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 1.03 GB 1.03 GB +0% (+2.33 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.68 MB 6.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 90.58 KB 90.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 27.26 MB 27.26 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 48.13 MB 48.13 MB -0% (-126 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 78.65 MB 78.64 MB -0% (-368 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.06 MB 9.06 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 94.14 MB 94.14 MB -0% (-368 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.02 MB 11.02 MB 0% (0 B) 👌

@gyuheon0h

Copy link
Copy Markdown
Contributor Author

Ugh something wrong with formatter tool chain check

@gyuheon0h
gyuheon0h requested a review from a team as a code owner July 27, 2026 16:09

@yannham yannham left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought nightly-toolchain.toml would automatically pin +nightly locally, but it seems that it's not currently easy to pin both a nightly and a stable version... We probably have to manually use an override as devs. Or use the Nix devenv 😛 anyway it's time to update I think

Comment thread libdd-common-ffi/src/array_queue.rs
@ekump

ekump commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Could you also update .pre-commit-config.yaml and local-linux.dockerfile? We should look into getting those files to respect the toolchain, but that can be done in a separate PR.

@gyuheon0h
gyuheon0h requested review from a team as code owners July 27, 2026 17:04
@gyuheon0h
gyuheon0h merged commit ddef629 into main Jul 27, 2026
97 of 98 checks passed
@gyuheon0h
gyuheon0h deleted the gyuheon0h/lint-repo branch July 27, 2026 19:41
hoolioh added a commit that referenced this pull request Aug 7, 2026
…er-flare (#2332)

# Release proposal for libdd-ffe, libdd-http-client, libdd-tracer-flare
and their dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-v3.0.0`

### Commits

- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- feat(capabilities)!: Add streaming to http capabilities (#2251)
- feat: added file capability [APMSP-3780] (#2240)
- feat: added environment capability [APMSP-3780] (#2239)

## libdd-common
**Next version:** `5.1.1`
**Semver bump:** `patch`
**Tag:** `libdd-common-v5.1.1`

### Commits

- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- test: stabilize flaky tests (#2256)
- fix(sidecar): don't double-encode file:// telemetry endpoints (#2230)
- fix: last new clippy lint (#2221)

## libdd-tinybytes
**Next version:** `1.1.2`
**Semver bump:** `patch`
**Tag:** `libdd-tinybytes-v1.1.2`

### Commits

- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-trace-protobuf
**Next version:** `4.0.1`
**Semver bump:** `patch`
**Tag:** `libdd-trace-protobuf-v4.0.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)

## libdd-capabilities-impl
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v4.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0

### Commits

- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- feat(capabilities)!: Add streaming to http capabilities (#2251)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat: added file capability [APMSP-3780] (#2240)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- feat: added environment capability [APMSP-3780] (#2239)

## libdd-http-client
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-http-client-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-trace-normalization
**Next version:** `3.0.1`
**Semver bump:** `patch`
**Tag:** `libdd-trace-normalization-v3.0.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-remote-config
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-remote-config-v3.0.0`

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- fix(wasm)!: finish the WASM port of remote-config (#2315)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- feat(rc): Handle expired config status (#2274)
- feat(remote-config)!: add AsmRawResponseBody capability (#2278)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- fix(rc): Make Target fields available again after eaf5ad0 (#2232)
- fix: new clippy lints (#2219)

## libdd-trace-utils
**Next version:** `10.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-utils-v10.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- fix(libdd-trace-utils): apply SpanLink flags masking when v0.5 json
encoding (#2314)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- feat(data-pipeline)!: add compression option for agentless export
(#2205)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor(trace-utils)!: split generic TracerHeaderTags (#2279)
- chore(lint): update nightly (#2281)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)
- feat(trace-utils)!: add v1 decoder (#2174)
- feat(trace-utils)!: add encoder v1 to v04 + refactor (#2145)
- feat(otlp): add instrumentation scope metadata (#2235)
- fix(trace-utils)!: serialize v0.5 span links and events into meta
(#980)

## libdd-ffe
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-ffe-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-tracer-flare
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-tracer-flare-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
hoolioh added a commit that referenced this pull request Aug 18, 2026
)

# Release proposal for libdd-data-pipeline, libdd-telemetry and their
dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-ddsketch
**Next version:** `1.1.1`
**Semver bump:** `patch`
**Tag:** `libdd-ddsketch-v1.1.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- chore: moving to workspace-level dependencies, phase 2 (#2270)

## libdd-shared-runtime
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-shared-runtime-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0
- `libdd-capabilities-impl`: ^3.0.0 → ^4.0.0

### Commits

- feat(shared-runtime): add block_on_with_timeout to BlockingRuntime
(#2333)
- chore(runtime): restart all workers on invalid state (#2262)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-dogstatsd-client
**Next version:** `5.0.0`
**Semver bump:** `major`
**Tag:** `libdd-dogstatsd-client-v5.0.0`

### Commits

- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(dogstatsd)!: add shared_runtime buffered sink (#2224)
- refactor(statsd)!: make client clonable (#2222)

## libdd-telemetry
**Next version:** `7.0.0`
**Semver bump:** `major`
**Tag:** `libdd-telemetry-v7.0.0`

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- fix: drain the mailbox before stopping (#2258)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- fix(sidecar): don't double-encode file:// telemetry endpoints (#2230)

## libdd-trace-obfuscation
**Next version:** `6.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-obfuscation-v6.0.0`

### ⚠️ major bump forced due to:

- `libdd-trace-utils`: ^9.0.0 → ^10.1.0

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- chore(lint): update nightly (#2281)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- fix: new clippy lints (#2219)

## libdd-trace-stats
**Next version:** `7.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-stats-v7.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0
- `libdd-capabilities-impl`: ^3.0.0 → ^4.0.0
- `libdd-dogstatsd-client`: ^4.0.0 → ^5.0.0
- `libdd-telemetry`: ^6.0.0 → ^7.0.0
- `libdd-trace-utils`: ^9.0.0 → ^10.1.0

### Commits

- feat: add v1 isolated bricks for trace exporter (#2280)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- feat(data-pipeline)!: add compression option for agentless export
(#2205)
- feat(stats)!: per-field cardinality limits (#2211)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- feat(stats)!: string field length limit (#2267)
- feat(trace_exporter)!: add `restart_after_fork` configuration option
[APMSP-3843] (#2263)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)
- refactor(statsd)!: make client clonable (#2222)
- fix(stats-exporter): disable retries for stats payload sends (#2249)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- fix!: css obfuscation logic (#2203)

## libdd-data-pipeline
**Next version:** `8.0.0`
**Semver bump:** `major`
**Tag:** `libdd-data-pipeline-v8.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0
- `libdd-capabilities-impl`: ^3.0.0 → ^4.0.0
- `libdd-dogstatsd-client`: ^4.0.0 → ^5.0.0
- `libdd-telemetry`: ^6.0.0 → ^7.0.0
- `libdd-trace-stats`: ^6.0.0 → ^7.0.0
- `libdd-trace-utils`: ^9.0.0 → ^10.1.0

### Commits

- fix(trace-exporter): mark OTLP client-computed stats (#2245)
- feat(data-pipeline): adds new attributes to OTLP trace metrics export
(#2316)
- feat: add v1 isolated bricks for trace exporter (#2280)
- feat(data-pipeline)!: add flush_and_close to the trace buffer (#2313)
- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- feat(data-pipeline)!: add compression option for agentless export
(#2205)
- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- feat(stats)!: per-field cardinality limits (#2211)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- feat(stats)!: string field length limit (#2267)
- refactor(trace-utils)!: split generic TracerHeaderTags (#2279)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- feat(trace_exporter)!: add `restart_after_fork` configuration option
[APMSP-3843] (#2263)
- feat(data-pipeline): emit additional_metric_tags on OTLP span duration
metric (#2264)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(dogstatsd)!: add shared_runtime buffered sink (#2224)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)
- refactor(statsd)!: make client clonable (#2222)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- feat(trace_exporter)!: remove deprecated methods (#2250)
- feat(trace-utils)!: add v1 decoder (#2174)
- feat(trace-utils)!: add encoder v1 to v04 + refactor (#2145)
- feat(otlp): add instrumentation scope metadata (#2235)
- fix(trace-utils)!: serialize v0.5 span links and events into meta
(#980)
- fix!: css obfuscation logic (#2203)
- test(data-pipeline): gate telemetry-only tests behind the telemetry
feature (#2204)


[APMSP-3843]:
https://datadoghq.atlassian.net/browse/APMSP-3843?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants