feat(capabilities): trait architecture http draft

.github/CODEOWNERS

@@ -38,6 +38,7 @@ docker-bake.hcl                      @DataDog/apm-common-components-core
 docs                                 @DataDog/libdatadog
 examples                             @DataDog/libdatadog
 libdd-alloc/                         @DataDog/libdatadog-profiling
+libdd-capabilities*/                 @DataDog/apm-common-components-core
 libdd-common*/                       @DataDog/libdatadog
 libdd-crashtracker*/                 @DataDog/libdatadog-profiling
 libdd-data-pipeline*/                @DataDog/libdatadog-apm

Cargo.toml

@@ -29,6 +29,8 @@ members = [
   "libdd-trace-utils",
   "libdd-trace-stats",
   "datadog-tracer-flare",
+  "libdd-capabilities",
+  "libdd-capabilities-impl",
   "libdd-common",
   "libdd-common-ffi",
   "libdd-telemetry",
@@ -107,3 +109,7 @@ codegen-units = 1
 # so benchmarks are not measuring the same thing as the release build. This patch removes
 # the default dependency on libm. A PR will be opened to proptest to make this optional.
 proptest = { git = 'https://github.com/bantonsson/proptest.git', branch = "ban/avoid-libm-in-std" }
+
+# Currently needs to live under patch but once it is on crates.io, only the
+# integration would need to specify this.
+libdd-capabilities-impl = { path = "libdd-capabilities-impl" }

LICENSE-3rdparty.yml

@@ -1,4 +1,4 @@
-root_name: builder, build_common, tools, libdd-alloc, libdd-crashtracker, libdd-common, libdd-telemetry, libdd-ddsketch, libdd-crashtracker-ffi, libdd-common-ffi, datadog-ffe, datadog-ffe-ffi, datadog-ipc, datadog-ipc-macros, libdd-tinybytes, tarpc, tarpc-plugins, spawn_worker, cc_utils, libdd-library-config, libdd-library-config-ffi, datadog-live-debugger, libdd-data-pipeline, libdd-dogstatsd-client, libdd-trace-protobuf, libdd-trace-stats, libdd-trace-utils, libdd-trace-normalization, libdd-log, datadog-live-debugger-ffi, libdd-profiling, libdd-profiling-protobuf, libdd-profiling-ffi, libdd-data-pipeline-ffi, libdd-ddsketch-ffi, libdd-log-ffi, libdd-telemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, libdd-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib
+root_name: builder, build_common, tools, libdd-alloc, libdd-crashtracker, libdd-common, libdd-capabilities, libdd-telemetry, libdd-capabilities-impl, libdd-ddsketch, libdd-crashtracker-ffi, libdd-common-ffi, datadog-ffe, datadog-ffe-ffi, datadog-ipc, datadog-ipc-macros, libdd-tinybytes, tarpc, tarpc-plugins, spawn_worker, cc_utils, libdd-library-config, libdd-library-config-ffi, datadog-live-debugger, libdd-data-pipeline, libdd-dogstatsd-client, libdd-trace-protobuf, libdd-trace-stats, libdd-trace-utils, libdd-trace-normalization, libdd-log, datadog-live-debugger-ffi, libdd-profiling, libdd-profiling-protobuf, libdd-profiling-ffi, libdd-data-pipeline-ffi, libdd-ddsketch-ffi, libdd-log-ffi, libdd-telemetry-ffi, symbolizer-ffi, datadog-profiling-replayer, datadog-remote-config, datadog-sidecar, datadog-sidecar-macros, datadog-sidecar-ffi, libdd-trace-obfuscation, datadog-tracer-flare, sidecar_mockgen, test_spawn_from_lib, bin_tests
 third_party_libraries:
 - package_name: addr2line
   package_version: 0.24.2

datadog-remote-config/src/fetch/test_server.rs

@@ -216,9 +216,9 @@ impl RemoteConfigServer {
                 tracer_version: "1.2.3".to_string(),
                 endpoint: self.endpoint.clone(),
             },
-            #[cfg(not(feature = "live-debugger"))]
+            #[cfg(not(all(feature = "live-debugger", not(target_arch = "wasm32"))))]
             products: vec![RemoteConfigProduct::ApmTracing],
-            #[cfg(feature = "live-debugger")]
+            #[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
             products: vec![
                 RemoteConfigProduct::ApmTracing,
                 RemoteConfigProduct::LiveDebugger,

datadog-remote-config/src/parse.rs

@@ -9,13 +9,13 @@ use crate::{
 };
 #[cfg(feature = "ffe")]
 use datadog_ffe::rules_based::UniversalFlagConfig;
-#[cfg(feature = "live-debugger")]
+#[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
 use datadog_live_debugger::LiveDebuggingData;
 
 #[derive(Debug)]
 pub enum RemoteConfigData {
     DynamicConfig(DynamicConfigFile),
-    #[cfg(feature = "live-debugger")]
+    #[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
     LiveDebugger(LiveDebuggingData),
     TracerFlareConfig(AgentConfigFile),
     TracerFlareTask(AgentTaskFile),
@@ -39,7 +39,7 @@ impl RemoteConfigData {
             RemoteConfigProduct::ApmTracing => {
                 RemoteConfigData::DynamicConfig(config::dynamic::parse_json(data)?)
             }
-            #[cfg(feature = "live-debugger")]
+            #[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
             RemoteConfigProduct::LiveDebugger => {
                 let parsed = datadog_live_debugger::parse_json(&String::from_utf8_lossy(data))?;
                 RemoteConfigData::LiveDebugger(parsed)
@@ -57,7 +57,7 @@ impl From<&RemoteConfigData> for RemoteConfigProduct {
     fn from(value: &RemoteConfigData) -> Self {
         match value {
             RemoteConfigData::DynamicConfig(_) => RemoteConfigProduct::ApmTracing,
-            #[cfg(feature = "live-debugger")]
+            #[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
             RemoteConfigData::LiveDebugger(_) => RemoteConfigProduct::LiveDebugger,
             RemoteConfigData::TracerFlareConfig(_) => RemoteConfigProduct::AgentConfig,
             RemoteConfigData::TracerFlareTask(_) => RemoteConfigProduct::AgentTask,

datadog-remote-config/src/path.rs

@@ -24,7 +24,7 @@ pub enum RemoteConfigProduct {
     AsmDD,
     AsmFeatures,
     FfeFlags,
-    #[cfg(feature = "live-debugger")]
+    #[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
     LiveDebugger,
 }
 
@@ -39,7 +39,7 @@ impl Display for RemoteConfigProduct {
             RemoteConfigProduct::AsmDD => "ASM_DD",
             RemoteConfigProduct::AsmFeatures => "ASM_FEATURES",
             RemoteConfigProduct::FfeFlags => "FFE_FLAGS",
-            #[cfg(feature = "live-debugger")]
+            #[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
             RemoteConfigProduct::LiveDebugger => "LIVE_DEBUGGING",
         };
         write!(f, "{str}")
@@ -90,7 +90,7 @@ impl RemoteConfigPath {
                 "ASM_DD" => RemoteConfigProduct::AsmDD,
                 "ASM_FEATURES" => RemoteConfigProduct::AsmFeatures,
                 "FFE_FLAGS" => RemoteConfigProduct::FfeFlags,
-                #[cfg(feature = "live-debugger")]
+                #[cfg(all(feature = "live-debugger", not(target_arch = "wasm32")))]
                 "LIVE_DEBUGGING" => RemoteConfigProduct::LiveDebugger,
                 product => anyhow::bail!("Unknown product {}", product),
             },

datadog-sidecar/src/service/tracing/trace_flusher.rs

@@ -5,9 +5,7 @@ use super::TraceSendData;
 use crate::agent_remote_config::AgentRemoteConfigWriter;
 use datadog_ipc::platform::NamedShmHandle;
 use futures::future::join_all;
-use http_body_util::BodyExt;
-use libdd_common::http_common::new_default_client;
-use libdd_common::{Endpoint, HttpClient, MutexExt};
+use libdd_common::{Endpoint, MutexExt};
 use libdd_trace_utils::trace_utils;
 use libdd_trace_utils::trace_utils::SendData;
 use libdd_trace_utils::trace_utils::SendDataResult;
@@ -96,7 +94,6 @@ pub(crate) struct TraceFlusher {
     pub(crate) min_force_drop_size_bytes: AtomicU32, // put a limit on memory usage
     remote_config: Mutex<AgentRemoteConfigs>,
     pub metrics: Mutex<TraceFlusherMetrics>,
-    client: HttpClient,
 }
 impl Default for TraceFlusher {
     fn default() -> Self {
@@ -107,7 +104,6 @@ impl Default for TraceFlusher {
             min_force_drop_size_bytes: AtomicU32::new(trace_utils::MAX_PAYLOAD_SIZE as u32),
             remote_config: Mutex::new(Default::default()),
             metrics: Mutex::new(Default::default()),
-            client: new_default_client(),
         }
     }
 }
@@ -249,18 +245,13 @@ impl TraceFlusher {
 
     async fn send_and_handle_trace(&self, send_data: SendData) {
         let endpoint = send_data.get_target().clone();
-        let response = send_data.send(&self.client).await;
+        let response = send_data.send().await;
         self.metrics.lock_or_panic().update(&response);
         match response.last_result {
             Ok(response) => {
                 if endpoint.api_key.is_none() {
                     // not when intake
-                    match response.into_body().collect().await {
-                        Ok(body) => {
-                            self.write_remote_configs(endpoint.clone(), body.to_bytes().to_vec())
-                        }
-                        Err(e) => error!("Error receiving agent configuration: {e:?}"),
-                    }
+                    self.write_remote_configs(endpoint.clone(), response.into_body().to_vec());
                 }
                 info!("Successfully flushed traces to {endpoint:?}");
             }

datadog-tracer-flare/Cargo.toml

@@ -9,11 +9,13 @@ publish = false
 
 [dependencies]
 anyhow = "1.0"
+bytes = "1.4"
+http = "1"
+libdd-capabilities = { path = "../libdd-capabilities" }
+libdd-capabilities-impl = { path = "../libdd-capabilities-impl" }
 libdd-common = { path = "../libdd-common" }
 datadog-remote-config = { path = "../datadog-remote-config", default-features = false }
 libdd-trace-utils = { path = "../libdd-trace-utils" }
-http = "1"
-bytes = "1.4"
 tokio = { version = "1.36.0", features = ["time"] }
 serde_json = "1.0"
 zip = "4.0.0"

libdd-capabilities-impl/Cargo.toml

@@ -0,0 +1,20 @@
+# Copyright 2026-Present Datadog, Inc. https://www.datadoghq.com/
+# SPDX-License-Identifier: Apache-2.0
+
+[package]
+name = "libdd-capabilities-impl"
+version = "0.1.0"
+edition = "2021"
+description = "Native implementations of libdd-capabilities traits"
+
+[lib]
+crate-type = ["lib"]
+bench = false
+
+[dependencies]
+libdd-capabilities = { path = "../libdd-capabilities" }
+libdd-common = { path = "../libdd-common" }
+hyper = { workspace = true }
+http = "1"
+bytes = "1.4"
+http-body-util = "0.1"

libdd-capabilities-impl/src/http.rs

@@ -0,0 +1,48 @@
+// Copyright 2026-Present Datadog, Inc. https://www.datadoghq.com/
+// SPDX-License-Identifier: Apache-2.0
+
+//! HTTP capability implementation using hyper.
+
+use bytes::Bytes;
+use http_body_util::BodyExt;
+use libdd_capabilities::http::{HttpClientTrait, HttpError};
+use libdd_capabilities::maybe_send::MaybeSend;
+use libdd_common::{connector::Connector, http_common};
+
+pub struct DefaultHttpClient {
+    client: http_common::GenericHttpClient<Connector>,
+}
+
+impl HttpClientTrait for DefaultHttpClient {
+    fn new_client() -> Self {
+        Self {
+            client: http_common::new_default_client(),
+        }
+    }
+
+    #[allow(clippy::manual_async_fn)]
+    fn request(
+        &self,
+        req: http::Request<Bytes>,
+    ) -> impl std::future::Future<Output = Result<http::Response<Bytes>, HttpError>> + MaybeSend
+    {
+        let client = self.client.clone();
+        async move {
+            let hyper_req = req.map(http_common::Body::from_bytes);
+
+            let response = client
+                .request(hyper_req)
+                .await
+                .map_err(|e| HttpError::Network(e.into()))?;
+
+            let (parts, body) = response.into_parts();
+            let collected = body
+                .collect()
+                .await
+                .map_err(|e| HttpError::ResponseBody(e.into()))?
+                .to_bytes();
+
+            Ok(http::Response::from_parts(parts, collected))
+        }
+    }
+}

libdd-capabilities-impl/src/lib.rs

@@ -0,0 +1,12 @@
+// Copyright 2026-Present Datadog, Inc. https://www.datadoghq.com/
+// SPDX-License-Identifier: Apache-2.0
+
+//! Native capability implementations.
+//!
+//! This crate is patchable: `libdatadog-nodejs` overrides it via
+//! `[patch.crates-io]` with wasm implementations backed by JS transports.
+//! Both versions export the same `DefaultHttpClient` type.
+
+mod http;
+
+pub use http::DefaultHttpClient;

libdd-capabilities/Cargo.toml

@@ -0,0 +1,21 @@
+# Copyright 2026-Present Datadog, Inc. https://www.datadoghq.com/
+# SPDX-License-Identifier: Apache-2.0
+
+[package]
+name = "libdd-capabilities"
+version = "0.1.0"
+edition = "2021"
+description = "Portable capability traits for cross-platform libdatadog"
+homepage = "https://github.com/DataDog/libdatadog"
+repository = "https://github.com/DataDog/libdatadog"
+license = "Apache-2.0"
+
+[lib]
+crate-type = ["lib"]
+bench = false
+
+[dependencies]
+http = "1"
+bytes = "1.4"
+anyhow = "1.0"
+thiserror = "1.0"

libdd-capabilities/src/http.rs

@@ -0,0 +1,34 @@
+// Copyright 2026-Present Datadog, Inc. https://www.datadoghq.com/
+// SPDX-License-Identifier: Apache-2.0
+
+//! HTTP capability trait and error types.
+//!
+//! Request and response types are provided by the [`http`] crate, which is a
+//! pure-types crate with no platform dependencies (compiles on wasm). The body
+//! type is [`bytes::Bytes`].
+
+use crate::maybe_send::MaybeSend;
+use core::future::Future;
+
+#[derive(Debug, thiserror::Error)]
+pub enum HttpError {
+    #[error("Network error: {0}")]
+    Network(anyhow::Error),
+    #[error("Request timed out")]
+    Timeout,
+    #[error("Response body error: {0}")]
+    ResponseBody(anyhow::Error),
+    #[error("Invalid request: {0}")]
+    InvalidRequest(anyhow::Error),
+    #[error("HTTP error: {0}")]
+    Other(anyhow::Error),
+}
+
+pub trait HttpClientTrait {
+    fn new_client() -> Self;
+
+    fn request(
+        &self,
+        req: http::Request<bytes::Bytes>,
+    ) -> impl Future<Output = Result<http::Response<bytes::Bytes>, HttpError>> + MaybeSend;
+}

libdd-capabilities/src/lib.rs

@@ -0,0 +1,10 @@
+// Copyright 2026-Present Datadog, Inc. https://www.datadoghq.com/
+// SPDX-License-Identifier: Apache-2.0
+
+//! Portable capability traits for cross-platform libdatadog.
+
+pub mod http;
+pub mod maybe_send;
+
+pub use self::http::{HttpClientTrait, HttpError};
+pub use maybe_send::MaybeSend;