Skip to content

[crashtracking] Add sig_info and os_info as objects in errors payload #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 2 commits into from
Nov 19, 2025
Merged

[crashtracking] Add sig_info and os_info as objects in errors payload #1350

dd-mergequeue merged 2 commits into from
Nov 19, 2025

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Nov 17, 2025 •
edited
Loading

What does this PR do?

Parity with telemetry intake + errortracking needs OS info

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

{\"ddsource\":\"crashtracker\",\"ddtags\":\"service:foo,version:bar,language_name:native,data_schema_version:1.4,incomplete:false,is_crash:true,uuid:63a3f9a0-41df-489e-819f-e104b6eb500f,profiler_serializing:0,profiler_inactive:0,profiler_collecting_sample:1,profiler_unwinding:0,si_addr:0x0000000000000000,si_code:1,si_code_human_readable:SEGV_MAPERR,si_signo:11,si_signo_human_readable:SIGSEGV\",\"error\":{\"experimental\":{\"ucontext\":\"ucontext_t { uc_flags: 7, uc_link: 0x0, uc_stack: stack_t { ss_sp: 0x761727e3a000, ss_flags: 0, ss_size: 65536 }, uc_mcontext: mcontext_t { gregs: [105839950724912, 0, 8, -3335875642709087089, 89, 105839950723808, 28, 9223372036854775806, 1, 105839950724560, 140736526950712, 0, 105839594056768, 0, 0, 140736526949760, 105839594182818, 66050, 12103423998558259, 4, 14, 0, 0], fpregs: 0x761727e49540, __private: [0, 0, 0, 0, 0, 0, 0, 0] }, uc_sigmask: sigset_t { __val: [0, 11, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0] }, __private: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 127, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 128, 31, 0, 0, 255, 255, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 128, 25, 178, 198, 255, 127, 0, 0, 112, 27, 178, 198, 255, 127, 0, 0, 8, 5, 0, 0, 0, 0, 0, 0, 96, 245, 170, 200, 66, 96, 0, 0, 80, 0, 0, 0, 0, 0, 0, 0, 18, 56, 106, 179, 66, 96, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 50, 151, 243, 39, 23, 118, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 240, 0, 0, 0, 0, 0, 0, 0, 30, 0, 0, 0, 0, 0, 0, 0, 30, 0, 0, 0, 0, 0, 0, 0, 112, 27, 178, 198, 15, 0, 0, 0, 232, 0, 0, 0, 0, 0, 0, 0, 30, 0, 0, 0, 0, 0, 0, 0, 111, 109, 101, 47, 98, 105, 116, 115, 47, 46, 114, 117, 115, 116, 117, 112, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 83, 88, 80, 70, 140, 10, 0, 0, 255, 2, 0, 0, 0, 0, 0, 0, 136, 10, 0, 0, 0, 0, 0, 0] }\"},\"is_crash\":true,\"message\":\"Process terminated by signal SIGSEGV\",\"source_type\":\"Crashtracking\",\"stack\":{\"format\":\"Datadog Crashtracker 1.0\",\"frames\":[{\"ip\":\"0x6042b36a18a2\",\"sp\":\"0x7fffc6b21d80\",\"symbol_address\":\"0x6042b36a189e\"},{\"ip\":\"0x6042b36a1393\",\"sp\":\"0x7fffc6b21dc0\",\"symbol_address\":\"0x6042b36a0752\"},{\"ip\":\"0x6042b36a18dc\",\"sp\":\"0x7fffc6b22300\",\"symbol_address\":\"0x6042b36a18d9\"},{\"ip\":\"0x6042b36a2985\",\"sp\":\"0x7fffc6b22310\",\"symbol_address\":\"0x6042b36a24e0\"},{\"ip\":\"0x761727e75d90\",\"sp\":\"0x7fffc6b22450\",\"symbol_address\":\"0x761727e75d10\"},{\"ip\":\"0x761727e75e40\",\"sp\":\"0x7fffc6b224f0\",\"symbol_address\":\"0x761727e75dc0\"},{\"ip\":\"0x6042b369fd75\",\"sp\":\"0x7fffc6b22540\",\"symbol_address\":\"0x6042b369fd50\"},{\"ip\":\"0x0\",\"sp\":\"0x7fffc6b22548\",\"symbol_address\":\"0x0\"}],\"incomplete\":false},\"type\":\"SIGSEGV\"},\
"os_info\":{\"architecture\":\"x86_64\",\"bitness\":\"64-bit\",\"os_type\":\"Ubuntu\",\"version\":\"22.4.0\"},\
"sig_info\":{\"si_addr\":\"0x0000000000000000\",\"si_code\":1,\"si_code_human_readable\":\"SEGV_MAPERR\",\"si_signo\":11,\"si_signo_human_readable\":\"SIGSEGV\"},\"timestamp\":1763406980177}

@gyuheon0h Graphite App
Copy link
Contributor Author

gyuheon0h commented Nov 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title first commit [crashtracking] Add sig_info and os_info as objects in errors payload Nov 17, 2025
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13073-enhance-errors-intake-payload branch from cd3b00b to 670f703 Compare November 17, 2025 19:18
@gyuheon0h gyuheon0h requested a review from gleocadie November 17, 2025 19:18
@gyuheon0h gyuheon0h marked this pull request as ready for review November 17, 2025 19:18
@gyuheon0h gyuheon0h requested a review from a team as a code owner November 17, 2025 19:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.15%. Comparing base (6e559d7) to head (133ee8d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
+ Coverage   70.96%   71.15%   +0.19%     
==========================================
  Files         390      390              
  Lines       62588    62570      -18     
==========================================
+ Hits        44416    44523     +107     
+ Misses      18172    18047     -125
Components Coverage Δ
libdd-crashtracker 59.80% <100.00%> (+2.13%) ⬆️
libdd-crashtracker-ffi 14.60% <ø> (+0.35%) ⬆️
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 86.02% <ø> (-0.08%) ⬇️
libdd-data-pipeline-ffi 77.74% <ø> (-0.42%) ⬇️
libdd-common 80.93% <ø> (ø)
libdd-common-ffi 73.90% <ø> (ø)
libdd-telemetry 60.02% <ø> (ø)
libdd-telemetry-ffi 21.24% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.61% <ø> (-0.11%) ⬇️
libdd-profiling 79.65% <ø> (-0.03%) ⬇️
libdd-profiling-ffi 62.13% <ø> (ø)
datadog-sidecar 35.91% <ø> (-0.27%) ⬇️
datdog-sidecar-ffi 10.99% <ø> (-1.34%) ⬇️
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 59.65% <ø> (ø)
libdd-trace-utils 90.07% <ø> (ø)
datadog-tracer-flare 63.49% <ø> (+2.43%) ⬆️
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-11-18 22:05:48

Comparing candidate commit 2425179 in PR branch gyuheon0h/prof-13073-enhance-errors-intake-payload with baseline commit 444aa55 in branch main.

Found 0 performance improvements and 13 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+2.544ms; +3.316ms] or [+4.124%; +5.374%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+3.825µs; +3.947µs] or [+5.328%; +5.499%]
  • 🟥 throughput [-727338.822op/s; -704289.269op/s] or [-5.221%; -5.055%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+4.234µs; +4.371µs] or [+6.180%; +6.381%]
  • 🟥 throughput [-877445.040op/s; -849112.260op/s] or [-6.010%; -5.816%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟥 execution_time [+7.071µs; +7.101µs] or [+15.466%; +15.532%]
  • 🟥 throughput [-2941757.077op/s; -2928560.476op/s] or [-13.450%; -13.389%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟥 execution_time [+4.951µs; +4.995µs] or [+9.267%; +9.350%]
  • 🟥 throughput [-1600344.416op/s; -1587313.941op/s] or [-8.550%; -8.480%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+5.270µs; +5.317µs] or [+10.499%; +10.592%]
  • 🟥 throughput [-1907781.180op/s; -1892566.466op/s] or [-9.577%; -9.500%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟥 execution_time [+7.080µs; +7.118µs] or [+15.483%; +15.565%]
  • 🟥 throughput [-2946391.041op/s; -2930728.714op/s] or [-13.474%; -13.402%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.427µs 2.467µs ± 0.039µs 2.450µs ± 0.012µs 2.468µs 2.547µs 2.552µs 2.553µs 4.20% 1.225 -0.110 1.57% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.461µs; 2.472µs] or [-0.219%; +0.219%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.210µs 3.275µs ± 1.447µs 3.048µs ± 0.029µs 3.079µs 3.725µs 14.422µs 14.850µs 387.24% 7.278 54.316 44.08% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.074µs; 3.475µs] or [-6.124%; +6.124%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.007µs 205.533µs ± 0.269µs 205.485µs ± 0.184µs 205.708µs 206.034µs 206.282µs 206.352µs 0.42% 0.588 -0.031 0.13% 0.019µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4846079.986op/s 4865404.210op/s ± 6358.510op/s 4866536.550op/s ± 4368.023op/s 4869818.244op/s 4874505.978op/s 4875738.947op/s 4877886.720op/s 0.23% -0.582 -0.042 0.13% 449.615op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.158µs 18.251µs ± 0.062µs 18.246µs ± 0.023µs 18.266µs 18.348µs 18.510µs 18.516µs 1.48% 2.203 6.809 0.34% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54006928.317op/s 54790922.768op/s ± 185872.165op/s 54807353.305op/s ± 68568.334op/s 54879736.716op/s 55052830.946op/s 55068214.201op/s 55072169.996op/s 0.48% -2.163 6.643 0.34% 13143.147op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.555µs 10.689µs ± 0.102µs 10.663µs ± 0.065µs 10.750µs 10.877µs 10.922µs 11.006µs 3.22% 0.714 -0.433 0.95% 0.007µs 1 200
normalization/normalize_name/normalize_name/good throughput 90858207.791op/s 93559807.253op/s ± 888099.586op/s 93780894.976op/s ± 577516.495op/s 94261134.177op/s 94665347.541op/s 94735542.299op/s 94740047.052op/s 1.02% -0.684 -0.491 0.95% 62798.124op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.496µs; 205.570µs] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4864522.981op/s; 4866285.438op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.243µs; 18.260µs] or [-0.047%; +0.047%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54765162.673op/s; 54816682.862op/s] or [-0.047%; +0.047%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.675µs; 10.703µs] or [-0.132%; +0.132%] None None None
normalization/normalize_name/normalize_name/good throughput [93436725.191op/s; 93682889.314op/s] or [-0.132%; +0.132%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.852ms 14.912ms ± 0.041ms 14.907ms ± 0.016ms 14.921ms 14.979ms 15.068ms 15.171ms 1.77% 2.497 10.271 0.27% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.906ms; 14.918ms] or [-0.038%; +0.038%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.198ms 6.415ms ± 0.049ms 6.420ms ± 0.018ms 6.439ms 6.467ms 6.558ms 6.581ms 2.51% -1.083 4.989 0.76% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.408ms; 6.422ms] or [-0.106%; +0.106%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.881µs 534.779µs ± 1.184µs 534.618µs ± 0.268µs 534.929µs 535.413µs 538.525µs 545.751µs 2.08% 7.758 67.227 0.22% 0.084µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1832338.248op/s 1869939.378op/s ± 4071.169op/s 1870492.800op/s ± 938.393op/s 1871353.887op/s 1872377.494op/s 1872838.843op/s 1873076.584op/s 0.14% -7.698 66.464 0.22% 287.875op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.018µs 380.887µs ± 0.335µs 380.856µs ± 0.205µs 381.057µs 381.532µs 381.755µs 381.881µs 0.27% 0.473 0.184 0.09% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2618613.515op/s 2625454.266op/s ± 2308.940op/s 2625661.895op/s ± 1413.745op/s 2627084.649op/s 2628869.077op/s 2629550.869op/s 2631453.998op/s 0.22% -0.468 0.178 0.09% 163.267op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 195.890µs 196.427µs ± 0.227µs 196.428µs ± 0.144µs 196.572µs 196.751µs 196.893µs 197.515µs 0.55% 0.535 1.962 0.12% 0.016µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5062902.567op/s 5090957.436op/s ± 5882.971op/s 5090917.081op/s ± 3735.506op/s 5094597.458op/s 5100287.524op/s 5102306.846op/s 5104910.615op/s 0.27% -0.522 1.913 0.12% 415.989op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.792µs 36.996µs ± 0.075µs 36.992µs ± 0.050µs 37.053µs 37.119µs 37.167µs 37.209µs 0.59% 0.127 -0.045 0.20% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26874987.402op/s 27030108.812op/s ± 55071.732op/s 27032876.222op/s ± 36272.706op/s 27062978.817op/s 27116908.673op/s 27154742.647op/s 27179752.980op/s 0.54% -0.116 -0.048 0.20% 3894.160op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.909µs 45.102µs ± 0.175µs 45.078µs ± 0.162µs 45.271µs 45.373µs 45.444µs 45.505µs 0.95% 0.286 -1.394 0.39% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21975537.320op/s 22172461.790op/s ± 86042.984op/s 22183811.468op/s ± 80104.747op/s 22263614.680op/s 22265080.027op/s 22266680.591op/s 22267279.099op/s 0.38% -0.280 -1.403 0.39% 6084.158op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.615µs; 534.943µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869375.153op/s; 1870503.603op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.840µs; 380.933µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2625134.269op/s; 2625774.262op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [196.395µs; 196.458µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5090142.113op/s; 5091772.759op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.985µs; 37.006µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27022476.399op/s; 27037741.224op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.077µs; 45.126µs] or [-0.054%; +0.054%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22160537.060op/s; 22184386.520op/s] or [-0.054%; +0.054%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 189.264ns 193.046ns ± 2.283ns 192.706ns ± 1.336ns 193.911ns 197.449ns 200.402ns 204.795ns 6.27% 1.552 3.868 1.18% 0.161ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [192.729ns; 193.362ns] or [-0.164%; +0.164%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.898µs 25.471µs ± 8.996µs 18.160µs ± 0.176µs 33.385µs 41.717µs 42.537µs 59.627µs 228.33% 0.773 -0.260 35.23% 0.636µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.224µs; 26.717µs] or [-4.895%; +4.895%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.616ms 10.650ms ± 0.016ms 10.650ms ± 0.010ms 10.658ms 10.678ms 10.701ms 10.733ms 0.78% 1.236 3.765 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.648ms; 10.652ms] or [-0.021%; +0.021%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.234ns 253.429ns ± 13.279ns 247.513ns ± 2.983ns 254.386ns 286.256ns 295.342ns 298.913ns 20.77% 1.896 2.602 5.23% 0.939ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.589ns; 255.269ns] or [-0.726%; +0.726%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 63.954ms 64.627ms ± 2.422ms 64.259ms ± 0.111ms 64.424ms 64.941ms 83.128ms 85.008ms 32.29% 7.845 60.448 3.74% 0.171ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [64.291ms; 64.962ms] or [-0.519%; +0.519%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.941µs 4.996µs ± 0.037µs 4.995µs ± 0.034µs 5.032µs 5.047µs 5.051µs 5.070µs 1.50% 0.157 -1.499 0.73% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.991µs; 5.001µs] or [-0.101%; +0.101%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.877µs 34.345µs ± 0.701µs 34.050µs ± 0.072µs 34.136µs 35.770µs 35.870µs 37.766µs 10.91% 1.929 2.827 2.04% 0.050µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.248µs; 34.442µs] or [-0.283%; +0.283%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.912µs ± 0.002µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.917µs 3.920µs 0.21% -1.436 12.421 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255105581.261op/s 255622940.219op/s ± 159861.452op/s 255635320.584op/s ± 93156.125op/s 255711825.283op/s 255821109.262op/s 255862259.524op/s 256777519.515op/s 0.45% 1.460 12.600 0.06% 11303.912op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 80.294µs 81.571µs ± 0.578µs 81.575µs ± 0.413µs 81.987µs 82.416µs 82.893µs 84.394µs 3.46% 0.625 1.821 0.71% 0.041µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11849196.148op/s 12259848.476op/s ± 86492.730op/s 12258728.010op/s ± 61681.450op/s 12319291.257op/s 12386543.012op/s 12423383.023op/s 12454300.060op/s 1.60% -0.554 1.526 0.70% 6115.960op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 75.233µs 75.665µs ± 0.174µs 75.648µs ± 0.083µs 75.752µs 75.953µs 76.120µs 76.287µs 0.84% 0.429 1.173 0.23% 0.012µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13108446.275op/s 13216163.812op/s ± 30409.788op/s 13219195.027op/s ± 14560.113op/s 13231402.457op/s 13270844.450op/s 13286598.457op/s 13292064.637op/s 0.55% -0.408 1.149 0.23% 2150.297op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.889µs 3.912µs ± 0.003µs 3.911µs ± 0.001µs 3.913µs 3.915µs 3.917µs 3.920µs 0.21% -2.850 28.480 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255131374.691op/s 255652608.848op/s ± 166577.974op/s 255665936.245op/s ± 81782.463op/s 255745519.203op/s 255814851.221op/s 255892802.019op/s 257117016.107op/s 0.57% 2.894 28.910 0.06% 11778.841op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.274µs 72.802µs ± 0.176µs 72.819µs ± 0.116µs 72.915µs 73.085µs 73.197µs 73.301µs 0.66% -0.202 0.267 0.24% 0.012µs 1 200
credit_card/is_card_number/378282246310005 throughput 13642451.513op/s 13735874.976op/s ± 33281.298op/s 13732586.734op/s ± 21963.592op/s 13757180.776op/s 13792372.681op/s 13817407.818op/s 13836298.145op/s 0.76% 0.218 0.274 0.24% 2353.343op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.643µs 52.806µs ± 0.071µs 52.805µs ± 0.048µs 52.849µs 52.934µs 52.974µs 52.980µs 0.33% 0.163 -0.349 0.13% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18874908.432op/s 18937348.164op/s ± 25483.768op/s 18937718.578op/s ± 17354.236op/s 18957424.479op/s 18977256.423op/s 18991488.852op/s 18996027.931op/s 0.31% -0.157 -0.353 0.13% 1801.975op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.428µs 6.439µs ± 0.007µs 6.437µs ± 0.004µs 6.442µs 6.452µs 6.461µs 6.470µs 0.51% 1.358 2.684 0.11% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 154560828.295op/s 155313743.665op/s ± 167018.533op/s 155348111.366op/s ± 97759.694op/s 155426777.738op/s 155516176.822op/s 155551216.467op/s 155570537.164op/s 0.14% -1.349 2.644 0.11% 11809.994op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.922µs 3.928µs 0.40% 0.271 8.942 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254601394.981op/s 255598299.826op/s ± 193119.050op/s 255614203.105op/s ± 94612.704op/s 255708291.354op/s 255829206.548op/s 255900456.809op/s 256728918.158op/s 0.44% -0.246 8.982 0.08% 13655.579op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.913µs 65.092µs ± 0.112µs 65.067µs ± 0.068µs 65.158µs 65.308µs 65.373µs 65.518µs 0.69% 1.028 0.850 0.17% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15263018.984op/s 15362822.216op/s ± 26453.444op/s 15368696.289op/s ± 16062.290op/s 15382869.636op/s 15394907.213op/s 15399699.432op/s 15405317.916op/s 0.24% -1.019 0.819 0.17% 1870.541op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.181µs 58.400µs ± 0.154µs 58.368µs ± 0.077µs 58.460µs 58.640µs 58.824µs 59.573µs 2.06% 2.697 15.848 0.26% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16786190.197op/s 17123396.579op/s ± 44757.304op/s 17132538.915op/s ± 22635.883op/s 17150990.188op/s 17173611.975op/s 17181323.077op/s 17187815.558op/s 0.32% -2.616 15.030 0.26% 3164.819op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.921µs 3.926µs 0.36% 0.329 10.645 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254701210.369op/s 255615046.577op/s ± 188764.579op/s 255622609.821op/s ± 82484.467op/s 255712174.539op/s 255838706.501op/s 255922956.429op/s 256752123.805op/s 0.44% -0.301 10.690 0.07% 13347.671op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 55.169µs 55.493µs ± 0.166µs 55.483µs ± 0.118µs 55.601µs 55.781µs 55.875µs 55.968µs 0.87% 0.392 -0.376 0.30% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17867395.104op/s 18020598.446op/s ± 53888.864op/s 18023629.378op/s ± 38318.613op/s 18061933.121op/s 18099362.815op/s 18117375.781op/s 18125994.489op/s 0.57% -0.378 -0.390 0.30% 3810.518op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.634µs 52.828µs ± 0.101µs 52.816µs ± 0.050µs 52.857µs 53.094µs 53.119µs 53.151µs 0.63% 1.337 2.071 0.19% 0.007µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18814433.245op/s 18929392.523op/s ± 35936.154op/s 18933610.248op/s ± 17764.951op/s 18953415.348op/s 18974409.973op/s 18994086.974op/s 18999259.029op/s 0.35% -1.324 2.042 0.19% 2541.070op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.428µs 6.437µs ± 0.005µs 6.436µs ± 0.003µs 6.440µs 6.446µs 6.454µs 6.462µs 0.41% 1.382 3.355 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154740896.625op/s 155355156.294op/s ± 128684.607op/s 155377081.880op/s ± 78406.498op/s 155440585.538op/s 155528184.775op/s 155537101.445op/s 155576096.584op/s 0.13% -1.373 3.315 0.08% 9099.376op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255600784.959op/s; 255645095.478op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.491µs; 81.651µs] or [-0.098%; +0.098%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12247861.415op/s; 12271835.536op/s] or [-0.098%; +0.098%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [75.641µs; 75.689µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13211949.308op/s; 13220378.316op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255629522.742op/s; 255675694.953op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.778µs; 72.827µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/378282246310005 throughput [13731262.508op/s; 13740487.443op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.796µs; 52.816µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [18933816.358op/s; 18940879.969op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.438µs; 6.440µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/x371413321323331 throughput [155290596.503op/s; 155336890.828op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255571535.383op/s; 255625064.269op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.077µs; 65.108µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15359156.023op/s; 15366488.409op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.379µs; 58.421µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17117193.647op/s; 17129599.511op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255588885.622op/s; 255641207.532op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.470µs; 55.516µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18013129.968op/s; 18028066.925op/s] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.814µs; 52.842µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [18924412.118op/s; 18934372.929op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.436µs; 6.438µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155337321.845op/s; 155372990.743op/s] or [-0.011%; +0.011%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.967µs 90.230µs ± 0.147µs 90.229µs ± 0.065µs 90.284µs 90.379µs 90.511µs 91.739µs 1.67% 5.437 53.266 0.16% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [90.210µs; 90.251µs] or [-0.023%; +0.023%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.687µs 146.677µs ± 1.602µs 146.465µs ± 0.454µs 146.921µs 148.002µs 152.640µs 162.657µs 11.05% 6.087 51.901 1.09% 0.113µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.455µs; 146.899µs] or [-0.151%; +0.151%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2425179 1763500924 gyuheon0h/prof-13073-enhance-errors-intake-payload
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 159.716µs 160.579µs ± 0.310µs 160.530µs ± 0.142µs 160.692µs 161.053µs 161.339µs 162.961µs 1.51% 2.603 16.669 0.19% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [160.536µs; 160.622µs] or [-0.027%; +0.027%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Nov 17, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.57 MB 7.57 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 83.33 MB 83.32 MB -0% (-3.56 KB) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 55.84 MB 55.84 MB +0% (+3.82 KB) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.41 MB 8.41 MB +0% (+192 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.63 MB 9.63 MB +0% (+272 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 96.65 MB 96.65 MB -0% (-1.80 KB) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 19.16 MB 19.17 MB +.01% (+3.00 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.49 KB 65.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 132.59 MB 132.58 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 702.84 MB 702.84 MB +0% (+10.06 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.38 MB 6.38 MB +.01% (+1.00 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.49 KB 65.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 19.16 MB 19.16 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 37.10 MB 37.10 MB +.01% (+5.31 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 16.24 MB 16.24 MB +.01% (+3.00 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.50 KB 66.50 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 134.85 MB 134.84 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 690.84 MB 690.85 MB +0% (+8.66 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.89 MB 4.89 MB +.01% (+1.00 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.50 KB 66.50 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 20.33 MB 20.33 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 34.82 MB 34.83 MB +.01% (+4.13 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 72.24 MB 72.23 MB -0% (-2.94 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.96 MB 8.96 MB +.04% (+4.00 KB) 🔍
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 57.67 MB 57.67 MB -0% (-128 B) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.46 MB 9.46 MB +0% (+184 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 91.34 MB 91.33 MB -0% (-5.50 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.32 MB 10.32 MB +0% (+200 B) 👌

gyuheon0h
gyuheon0h commented Nov 17, 2025
View reviewed changes
libdd-crashtracker/src/crash_info/errors_intake.rs
experimental: crash_info.experimental.clone(),
},
trace_id: None,
os_info: ::os_info::get().into(),
Copy link
Contributor Author

@gyuheon0h gyuheon0h Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive seen telemetry crash reports with os info as the default unknown os_info. This makes sure we at least recalculate it (should be on same machine). I will investigate why original telemetry message sends unknown OS info sometimes...

Copy link
Contributor

@gleocadie gleocadie Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I saw this for some php crash report.
Maybe the crate needs an update.

gleocadie
gleocadie reviewed Nov 18, 2025
View reviewed changes
libdd-crashtracker/src/crash_info/errors_intake.rs
experimental: crash_info.experimental.clone(),
},
trace_id: None,
os_info: ::os_info::get().into(),
Copy link
Contributor

@gleocadie gleocadie Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I saw this for some php crash report.
Maybe the crate needs an update.

libdd-crashtracker/src/crash_info/errors_intake.rs
@@ -1,9 +1,9 @@
// Copyright 2024-Present Datadog, Inc. https://www.datadoghq.com/
// SPDX-License-Identifier: Apache-2.0

Copy link
Contributor

@gleocadie gleocadie Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have tests for this ?

Copy link
Contributor Author

@gyuheon0h gyuheon0h Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, bin_tests/tests/crashtracker_bin_test.rs:1797

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13073-enhance-errors-intake-payload branch from 670f703 to 8b86bc7 Compare November 18, 2025 14:54
@gyuheon0h gyuheon0h requested review from a team as code owners November 18, 2025 14:54
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13073-enhance-errors-intake-payload branch 2 times, most recently from a297079 to b7bc511 Compare November 18, 2025 18:04
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13073-enhance-errors-intake-payload branch from b7bc511 to 2425179 Compare November 18, 2025 21:51
gyuheon0h
gyuheon0h commented Nov 18, 2025
View reviewed changes
libdd-crashtracker/src/crash_info/errors_intake.rs
std::env::remove_var("_DD_ERRORS_INTAKE_ENABLED");
}

#[cfg_attr(miri, ignore)]
Copy link
Contributor Author

@gyuheon0h gyuheon0h Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miri doesnt like creating os_info

@gyuheon0h gyuheon0h requested a review from gleocadie November 18, 2025 23:23
gleocadie
gleocadie reviewed Nov 19, 2025
View reviewed changes
@gyuheon0h
Copy link
Contributor Author

gyuheon0h commented Nov 19, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-11-19 16:28:18 UTC ℹ️ Start processing command /merge

2025-11-19 16:28:23 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 35m (p90).

2025-11-19 16:47:53 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a3f9e86 into main Nov 19, 2025
37 checks passed
@dd-mergequeue dd-mergequeue bot deleted the gyuheon0h/prof-13073-enhance-errors-intake-payload branch November 19, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

crashtracker mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gyuheon0h @codecov-commenter @gleocadie