-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Move error log to debug when multiple root spans may exist in a batch #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move error log to debug when multiple root spans may exist in a batch #1167
Conversation
…st without an error
BenchmarksComparisonBenchmark execution time: 2025-07-31 20:27:14 Comparing candidate commit c59d7b7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
BaselineOmitted due to size. |
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
This PR is rejected because it was updated |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
+ Coverage 70.90% 71.26% +0.35%
==========================================
Files 346 347 +1
Lines 54084 54256 +172
==========================================
+ Hits 38350 38667 +317
+ Misses 15734 15589 -145
🚀 New features to boost your workflow:
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Moves an error log to an info log
Motivation
We use trace-utils as part of our agent pipeline, which means that some partial trace chunks are processed. This log gets noisy as an error log because for many cases it's expected often.
Additional Notes
Left the log in just moved it to an info level
How to test the change?
no functional change but we may begin returning the first span instead of the last to be consistent w/ go