Skip to content

feat: Move error log to debug when multiple root spans may exist in a batch #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Jul 31, 2025

What does this PR do?

Moves an error log to an info log

Motivation

We use trace-utils as part of our agent pipeline, which means that some partial trace chunks are processed. This log gets noisy as an error log because for many cases it's expected often.

Additional Notes

Left the log in just moved it to an info level

How to test the change?

no functional change but we may begin returning the first span instead of the last to be consistent w/ go

@astuyve astuyve requested review from a team as code owners July 31, 2025 19:31
@pr-commenter
Copy link

pr-commenter bot commented Jul 31, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-07-31 20:27:14

Comparing candidate commit c59d7b7 in PR branch aj/allow-multiple-root-spans-use-consistent with baseline commit 8ae8933 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.070ms 8.088ms ± 0.009ms 8.087ms ± 0.006ms 8.093ms 8.106ms 8.117ms 8.123ms 0.44% 0.804 0.818 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.087ms; 8.089ms] or [-0.016%; +0.016%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.828ms 14.885ms ± 0.030ms 14.882ms ± 0.015ms 14.897ms 14.921ms 14.983ms 15.102ms 1.47% 2.560 13.655 0.20% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.881ms; 14.889ms] or [-0.028%; +0.028%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.210µs 3.136µs ± 1.408µs 2.965µs ± 0.026µs 2.987µs 3.313µs 13.554µs 14.944µs 403.96% 7.557 57.541 44.78% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.941µs; 3.331µs] or [-6.222%; +6.222%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.292µs 2.354µs ± 0.015µs 2.357µs ± 0.007µs 2.362µs 2.378µs 2.382µs 2.383µs 1.13% -1.371 3.778 0.64% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.352µs; 2.356µs] or [-0.089%; +0.089%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.918µs 3.922µs 0.28% -0.754 7.469 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254997761.664op/s 255705772.509op/s ± 189007.993op/s 255717785.174op/s ± 118901.783op/s 255826231.115op/s 255944587.064op/s 255990711.595op/s 256904522.544op/s 0.46% 0.774 7.580 0.07% 13364.883op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.915µs 81.739µs ± 0.694µs 81.843µs ± 0.483µs 82.224µs 82.742µs 83.086µs 83.355µs 1.85% -0.271 -0.372 0.85% 0.049µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11996948.679op/s 12234955.153op/s ± 104185.245op/s 12218509.872op/s ± 71751.553op/s 12304380.704op/s 12424924.477op/s 12484274.851op/s 12513264.824op/s 2.41% 0.310 -0.346 0.85% 7367.009op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.451µs 74.896µs ± 0.163µs 74.879µs ± 0.080µs 74.976µs 75.146µs 75.429µs 75.645µs 1.02% 1.001 3.727 0.22% 0.012µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13219594.833op/s 13351890.176op/s ± 28962.189op/s 13354879.205op/s ± 14254.865op/s 13367010.223op/s 13393180.935op/s 13416303.488op/s 13431654.380op/s 0.57% -0.971 3.627 0.22% 2047.936op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.887µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.917µs 3.920µs 0.22% -2.174 17.193 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255097332.552op/s 255669306.857op/s ± 202362.099op/s 255666712.204op/s ± 126729.141op/s 255790089.277op/s 255923180.369op/s 256040492.633op/s 257257643.580op/s 0.62% 2.209 17.512 0.08% 14309.161op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.403µs 72.052µs ± 0.174µs 72.046µs ± 0.089µs 72.148µs 72.302µs 72.549µs 72.724µs 0.94% -0.151 2.577 0.24% 0.012µs 1 200
credit_card/is_card_number/378282246310005 throughput 13750629.660op/s 13878908.907op/s ± 33472.459op/s 13880010.017op/s ± 17086.186op/s 13893880.446op/s 13928202.477op/s 13978201.508op/s 14004965.818op/s 0.90% 0.184 2.583 0.24% 2366.860op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.118µs 52.190µs ± 0.042µs 52.192µs ± 0.028µs 52.214µs 52.261µs 52.287µs 52.415µs 0.43% 0.992 3.329 0.08% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19078621.808op/s 19160949.231op/s ± 15508.186op/s 19160074.237op/s ± 10183.756op/s 19173549.609op/s 19183932.689op/s 19186439.408op/s 19187255.825op/s 0.14% -0.981 3.273 0.08% 1096.594op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.750µs 5.896µs ± 0.058µs 5.896µs ± 0.038µs 5.935µs 5.995µs 6.001µs 6.046µs 2.54% -0.169 -0.311 0.98% 0.004µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165408839.749op/s 169609432.318op/s ± 1674295.770op/s 169604890.309op/s ± 1092292.197op/s 170684941.907op/s 172578860.331op/s 173524354.541op/s 173925710.812op/s 2.55% 0.219 -0.282 0.98% 118390.589op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.917µs 3.920µs 3.922µs 0.28% -0.148 4.772 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254987609.476op/s 255691709.180op/s ± 217241.361op/s 255709823.982op/s ± 135806.091op/s 255844190.688op/s 255947816.277op/s 256024661.898op/s 256916998.032op/s 0.47% 0.165 4.845 0.08% 15361.284op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.155µs 64.291µs ± 0.080µs 64.288µs ± 0.040µs 64.321µs 64.425µs 64.589µs 64.724µs 0.68% 1.622 5.341 0.12% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15450294.373op/s 15554352.528op/s ± 19291.890op/s 15554890.820op/s ± 9751.171op/s 15567443.805op/s 15580548.543op/s 15583653.932op/s 15587321.273op/s 0.21% -1.605 5.247 0.12% 1364.143op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.367µs 57.526µs ± 0.097µs 57.508µs ± 0.065µs 57.588µs 57.690µs 57.804µs 57.857µs 0.61% 0.839 0.502 0.17% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17283902.300op/s 17383619.358op/s ± 29216.479op/s 17388864.172op/s ± 19731.333op/s 17406008.562op/s 17420388.040op/s 17430193.400op/s 17431572.063op/s 0.25% -0.830 0.479 0.17% 2065.917op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.889µs 3.913µs ± 0.004µs 3.912µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.929µs 0.43% -0.595 7.989 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254499348.424op/s 255589894.829op/s ± 243109.389op/s 255596521.765op/s ± 152310.825op/s 255745618.629op/s 255906648.470op/s 255945504.976op/s 257117023.339op/s 0.59% 0.623 8.108 0.09% 17190.430op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.541µs 54.778µs ± 0.135µs 54.747µs ± 0.073µs 54.854µs 55.021µs 55.219µs 55.237µs 0.89% 1.017 1.056 0.25% 0.010µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18103950.510op/s 18255706.894op/s ± 44898.934op/s 18265827.377op/s ± 24255.884op/s 18285362.111op/s 18311428.904op/s 18329900.064op/s 18334786.591op/s 0.38% -1.003 1.015 0.25% 3174.834op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.117µs 52.188µs ± 0.039µs 52.182µs ± 0.025µs 52.211µs 52.252µs 52.271µs 52.437µs 0.49% 1.624 7.547 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19070333.177op/s 19161502.298op/s ± 14157.153op/s 19163561.447op/s ± 9147.162op/s 19171228.778op/s 19179857.316op/s 19183907.522op/s 19187453.324op/s 0.12% -1.609 7.429 0.07% 1001.062op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.728µs 5.888µs ± 0.061µs 5.888µs ± 0.040µs 5.930µs 5.993µs 6.031µs 6.037µs 2.52% -0.048 -0.188 1.04% 0.004µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165655200.114op/s 169865226.375op/s ± 1775544.834op/s 169826015.066op/s ± 1161306.186op/s 170807518.613op/s 173046455.321op/s 173909699.508op/s 174573417.826op/s 2.80% 0.104 -0.171 1.04% 125549.979op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.910µs; 3.911µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255679577.819op/s; 255731967.199op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.643µs; 81.835µs] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12220516.080op/s; 12249394.226op/s] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [74.874µs; 74.919µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13347876.295op/s; 13355904.057op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255641261.417op/s; 255697352.298op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.028µs; 72.076µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/378282246310005 throughput [13874269.947op/s; 13883547.868op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.184µs; 52.195µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19158799.946op/s; 19163098.517op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.888µs; 5.905µs] or [-0.137%; +0.137%] None None None
credit_card/is_card_number/x371413321323331 throughput [169377391.027op/s; 169841473.609op/s] or [-0.137%; +0.137%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.911µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [255661601.617op/s; 255721816.744op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.280µs; 64.302µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15551678.857op/s; 15557026.198op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.512µs; 57.539µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17379570.235op/s; 17387668.481op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255556202.206op/s; 255623587.452op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.759µs; 54.796µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18249484.334op/s; 18261929.455op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.183µs; 52.193µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19159540.252op/s; 19163464.343op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.879µs; 5.896µs] or [-0.145%; +0.145%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [169619152.937op/s; 170111299.812op/s] or [-0.145%; +0.145%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.825µs 26.223µs ± 10.285µs 18.236µs ± 0.233µs 35.600µs 45.295µs 46.019µs 71.602µs 292.63% 0.897 0.299 39.12% 0.727µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.798µs; 27.648µs] or [-5.436%; +5.436%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 84.807µs 85.040µs ± 0.159µs 85.011µs ± 0.051µs 85.072µs 85.242µs 85.574µs 86.463µs 1.71% 5.161 38.009 0.19% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [85.018µs; 85.062µs] or [-0.026%; +0.026%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.281ms 59.894ms ± 1.760ms 59.727ms ± 0.080ms 59.777ms 60.048ms 69.874ms 79.570ms 33.22% 9.020 87.423 2.93% 0.124ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.650ms; 60.138ms] or [-0.407%; +0.407%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.015µs 5.094µs ± 0.038µs 5.097µs ± 0.031µs 5.124µs 5.148µs 5.151µs 5.154µs 1.12% -0.035 -1.040 0.74% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.089µs; 5.099µs] or [-0.103%; +0.103%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.569µs 536.482µs ± 0.756µs 536.404µs ± 0.266µs 536.706µs 537.137µs 537.544µs 545.650µs 1.72% 8.994 106.362 0.14% 0.053µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1832677.810op/s 1864000.459op/s ± 2594.458op/s 1864267.304op/s ± 925.554op/s 1865096.986op/s 1866168.351op/s 1866363.335op/s 1867171.403op/s 0.16% -8.879 104.490 0.14% 183.456op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.467µs 380.206µs ± 0.352µs 380.198µs ± 0.253µs 380.445µs 380.777µs 381.152µs 381.247µs 0.28% 0.280 -0.146 0.09% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2622969.665op/s 2630156.297op/s ± 2433.718op/s 2630211.779op/s ± 1747.856op/s 2631970.581op/s 2634105.911op/s 2634917.850op/s 2635276.475op/s 0.19% -0.275 -0.152 0.09% 172.090op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.367µs 194.982µs ± 0.356µs 194.871µs ± 0.222µs 195.207µs 195.584µs 195.837µs 196.734µs 0.96% 1.110 1.950 0.18% 0.025µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5083005.479op/s 5128702.639op/s ± 9333.280op/s 5131596.761op/s ± 5828.613op/s 5135508.503op/s 5139816.362op/s 5141809.779op/s 5144902.803op/s 0.26% -1.096 1.871 0.18% 659.963op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.912µs 37.157µs ± 0.123µs 37.171µs ± 0.083µs 37.236µs 37.360µs 37.415µs 37.449µs 0.75% 0.006 -0.622 0.33% 0.009µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26702800.218op/s 26913470.005op/s ± 88790.153op/s 26902544.335op/s ± 59720.572op/s 26976121.554op/s 27057578.027op/s 27083172.130op/s 27091351.554op/s 0.70% 0.008 -0.628 0.33% 6278.412op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.863µs 45.992µs ± 0.072µs 45.984µs ± 0.044µs 46.035µs 46.111µs 46.183µs 46.343µs 0.78% 0.941 2.357 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21578143.930op/s 21742898.392op/s ± 33873.085op/s 21746465.941op/s ± 20978.839op/s 21764151.383op/s 21792394.152op/s 21801905.125op/s 21804089.769op/s 0.26% -0.925 2.286 0.16% 2395.189op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.377µs; 536.586µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1863640.892op/s; 1864360.026op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.157µs; 380.255µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2629819.007op/s; 2630493.587op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.932µs; 195.031µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5127409.136op/s; 5129996.142op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.140µs; 37.174µs] or [-0.046%; +0.046%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26901164.543op/s; 26925775.466op/s] or [-0.046%; +0.046%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.982µs; 46.002µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21738203.908op/s; 21747592.876op/s] or [-0.022%; +0.022%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 206.155µs 206.967µs ± 0.626µs 206.693µs ± 0.249µs 207.591µs 207.937µs 208.274µs 210.693µs 1.94% 1.554 4.687 0.30% 0.044µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4746233.639op/s 4831738.681op/s ± 14541.922op/s 4838104.282op/s ± 5824.321op/s 4842146.198op/s 4846500.078op/s 4847474.681op/s 4850716.575op/s 0.26% -1.516 4.383 0.30% 1028.269op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.192µs 18.291µs ± 0.080µs 18.283µs ± 0.040µs 18.323µs 18.397µs 18.554µs 18.942µs 3.60% 3.310 21.340 0.44% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52792852.824op/s 54671559.292op/s ± 236778.204op/s 54695681.743op/s ± 119015.462op/s 54815647.334op/s 54942403.986op/s 54960533.119op/s 54968531.670op/s 0.50% -3.153 19.683 0.43% 16742.747op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.923µs 10.998µs ± 0.036µs 10.993µs ± 0.025µs 11.019µs 11.060µs 11.085µs 11.154µs 1.46% 0.712 1.040 0.33% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 89654910.101op/s 90930063.112op/s ± 296915.039op/s 90964659.544op/s ± 203002.352op/s 91159024.852op/s 91348807.706op/s 91444956.477op/s 91553750.375op/s 0.65% -0.687 0.957 0.33% 20995.064op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.880µs; 207.053µs] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4829723.310op/s; 4833754.051op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.280µs; 18.303µs] or [-0.061%; +0.061%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54638744.110op/s; 54704374.474op/s] or [-0.060%; +0.060%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.993µs; 11.003µs] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/good throughput [90888913.544op/s; 90971212.681op/s] or [-0.045%; +0.045%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.069µs 146.817µs ± 0.346µs 146.759µs ± 0.115µs 146.914µs 147.187µs 147.719µs 150.212µs 2.35% 4.981 45.363 0.24% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [146.769µs; 146.865µs] or [-0.033%; +0.033%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.181µs 33.747µs ± 1.016µs 33.277µs ± 0.041µs 33.368µs 35.894µs 35.954µs 37.422µs 12.46% 1.745 1.265 3.00% 0.072µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.606µs; 33.888µs] or [-0.417%; +0.417%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz c59d7b7 1753992920 aj/allow-multiple-root-spans-use-consistent
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.945ns 257.087ns ± 13.908ns 249.520ns ± 2.631ns 264.132ns 283.998ns 294.965ns 305.267ns 22.34% 1.423 0.919 5.40% 0.983ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [255.160ns; 259.015ns] or [-0.750%; +0.750%] None None None

Baseline

Omitted due to size.

@astuyve
Copy link
Contributor Author

astuyve commented Jul 31, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 31, 2025

View all feedbacks in Devflow UI.

2025-07-31 19:40:31 UTC ℹ️ Start processing command /merge


2025-07-31 19:40:41 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-07-31 19:55:24 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 40m (p90).


2025-07-31 20:15:33 UTCMergeQueue: This merge request was updated

This PR is rejected because it was updated

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.26%. Comparing base (7d92a5e) to head (c59d7b7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
+ Coverage   70.90%   71.26%   +0.35%     
==========================================
  Files         346      347       +1     
  Lines       54084    54256     +172     
==========================================
+ Hits        38350    38667     +317     
+ Misses      15734    15589     -145     
Components Coverage Δ
datadog-crashtracker 43.84% <ø> (+0.10%) ⬆️
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.05% <ø> (+2.38%) ⬆️
data-pipeline-ffi 88.49% <ø> (ø)
ddcommon 83.17% <ø> (+0.18%) ⬆️
ddcommon-ffi 70.01% <ø> (ø)
ddtelemetry 60.12% <ø> (+0.03%) ⬆️
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.13% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 37.26% <ø> (ø)
datdog-sidecar-ffi 12.12% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 91.59% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.94% <0.00%> (ø)
datadog-tracer-flare 54.62% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astuyve astuyve changed the title feat: if multiple possible root spans in a chunk exist, return the last without an error feat: Move error log to debug when multiple root spans may exist in a batch Jul 31, 2025
@astuyve
Copy link
Contributor Author

astuyve commented Jul 31, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 31, 2025

View all feedbacks in Devflow UI.

2025-07-31 21:20:19 UTC ℹ️ Start processing command /merge


2025-07-31 21:20:25 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 40m (p90).


2025-07-31 21:49:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f8a01a5 into main Jul 31, 2025
37 of 39 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aj/allow-multiple-root-spans-use-consistent branch July 31, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants