Skip to content

Fix deadlock when calling runtime #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2025
Merged

Fix deadlock when calling runtime #1163

merged 3 commits into from
Jul 31, 2025

Conversation

VianneyRuhlmann
Copy link
Contributor

What does this PR do?

Fix a deadlock caused by trying to lock the mutex twice. This also simplifies these methods.

Motivation

Causing a deadlock in python integration when recreating the runtime.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner July 29, 2025 16:26
@pr-commenter
Copy link

pr-commenter bot commented Jul 29, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-07-30 11:33:36

Comparing candidate commit a3d38c5 in PR branch vianney/data-pipeline/fix-deadlock with baseline commit 8580cf5 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+11.474µs; +11.679µs] or [+15.917%; +16.202%]
  • 🟥 throughput [-1933300.817op/s; -1904376.465op/s] or [-13.936%; -13.728%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.999µs 5.070µs ± 0.033µs 5.073µs ± 0.030µs 5.091µs 5.122µs 5.126µs 5.131µs 1.14% -0.062 -1.130 0.65% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.065µs; 5.074µs] or [-0.091%; +0.091%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.946µs 205.575µs ± 0.440µs 205.524µs ± 0.212µs 205.736µs 206.202µs 206.676µs 208.717µs 1.55% 3.436 20.440 0.21% 0.031µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4791178.430op/s 4864415.753op/s ± 10331.051op/s 4865609.563op/s ± 5026.851op/s 4870682.559op/s 4874794.975op/s 4878437.409op/s 4879323.130op/s 0.28% -3.369 19.827 0.21% 730.516op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.182µs 18.290µs ± 0.087µs 18.279µs ± 0.041µs 18.313µs 18.505µs 18.551µs 18.673µs 2.16% 1.597 3.079 0.48% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53552029.622op/s 54675716.838op/s ± 258883.523op/s 54706355.640op/s ± 121853.782op/s 54845931.922op/s 54954889.887op/s 54988927.010op/s 54998331.563op/s 0.53% -1.562 2.936 0.47% 18305.829op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.919µs 10.992µs ± 0.048µs 10.987µs ± 0.025µs 11.012µs 11.066µs 11.096µs 11.415µs 3.90% 3.698 29.238 0.43% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 87605715.875op/s 90976993.550op/s ± 388902.067op/s 91019041.178op/s ± 203643.417op/s 91218382.222op/s 91448808.931op/s 91484415.107op/s 91579793.057op/s 0.62% -3.478 26.686 0.43% 27499.529op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.515µs; 205.636µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4862983.968op/s; 4865847.537op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.278µs; 18.302µs] or [-0.066%; +0.066%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54639838.071op/s; 54711595.604op/s] or [-0.066%; +0.066%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.985µs; 10.999µs] or [-0.060%; +0.060%] None None None
normalization/normalize_name/normalize_name/good throughput [90923095.464op/s; 91030891.636op/s] or [-0.059%; +0.059%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 248.338ns 260.050ns ± 14.344ns 251.865ns ± 2.742ns 272.404ns 291.873ns 306.952ns 308.914ns 22.65% 1.348 0.937 5.50% 1.014ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [258.062ns; 262.038ns] or [-0.764%; +0.764%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.241ms 8.261ms ± 0.013ms 8.258ms ± 0.005ms 8.264ms 8.278ms 8.318ms 8.349ms 1.10% 3.266 16.270 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.259ms; 8.262ms] or [-0.022%; +0.022%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.469µs 34.970µs ± 0.694µs 34.668µs ± 0.057µs 34.747µs 36.357µs 36.397µs 38.834µs 12.02% 2.108 4.509 1.98% 0.049µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.873µs; 35.066µs] or [-0.275%; +0.275%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.783ms 61.257ms ± 2.168ms 60.961ms ± 0.071ms 61.051ms 61.186ms 76.318ms 81.698ms 34.02% 8.059 64.827 3.53% 0.153ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.956ms; 61.558ms] or [-0.491%; +0.491%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.286µs 2.360µs ± 0.018µs 2.362µs ± 0.003µs 2.366µs 2.380µs 2.385µs 2.389µs 1.15% -2.443 6.558 0.74% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.357µs; 2.362µs] or [-0.103%; +0.103%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.186µs 3.247µs ± 1.463µs 3.035µs ± 0.036µs 3.070µs 3.668µs 13.959µs 15.127µs 398.41% 7.260 53.878 44.96% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.044µs; 3.450µs] or [-6.247%; +6.247%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.075µs 26.010µs ± 9.871µs 18.217µs ± 0.103µs 35.186µs 44.401µs 44.995µs 69.200µs 279.87% 0.917 0.315 37.86% 0.698µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.642µs; 27.378µs] or [-5.260%; +5.260%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 147.253µs 147.850µs ± 0.265µs 147.828µs ± 0.131µs 147.942µs 148.242µs 148.670µs 149.403µs 1.06% 1.592 6.326 0.18% 0.019µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.813µs; 147.886µs] or [-0.025%; +0.025%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.700µs 536.591µs ± 0.801µs 536.444µs ± 0.273µs 536.755µs 537.472µs 541.600µs 542.099µs 1.05% 4.540 26.910 0.15% 0.057µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1844683.108op/s 1863619.233op/s ± 2764.613op/s 1864126.250op/s ± 949.409op/s 1864976.932op/s 1866051.098op/s 1866508.584op/s 1866717.881op/s 0.14% -4.503 26.576 0.15% 195.488op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 379.405µs 380.181µs ± 0.358µs 380.168µs ± 0.244µs 380.418µs 380.801µs 380.990µs 381.342µs 0.31% 0.281 -0.278 0.09% 0.025µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2622319.818op/s 2630327.905op/s ± 2473.570op/s 2630413.319op/s ± 1686.746op/s 2632061.693op/s 2634186.144op/s 2634937.123op/s 2635702.888op/s 0.20% -0.277 -0.284 0.09% 174.908op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 195.136µs 195.741µs ± 0.294µs 195.834µs ± 0.182µs 195.962µs 196.155µs 196.223µs 196.294µs 0.24% -0.371 -1.077 0.15% 0.021µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5094391.705op/s 5108807.849op/s ± 7669.019op/s 5106375.545op/s ± 4748.672op/s 5116590.606op/s 5121649.969op/s 5124156.775op/s 5124628.262op/s 0.36% 0.375 -1.076 0.15% 542.282op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.876µs 37.138µs ± 0.101µs 37.146µs ± 0.063µs 37.199µs 37.296µs 37.332µs 37.403µs 0.69% -0.273 -0.169 0.27% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26735895.661op/s 26926456.042op/s ± 73519.161op/s 26920932.777op/s ± 45922.077op/s 26971014.396op/s 27061671.065op/s 27104915.598op/s 27117983.081op/s 0.73% 0.287 -0.163 0.27% 5198.590op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.850µs 46.017µs ± 0.078µs 46.006µs ± 0.042µs 46.058µs 46.130µs 46.259µs 46.486µs 1.04% 1.670 7.095 0.17% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21511631.937op/s 21731061.969op/s ± 36692.241op/s 21736263.768op/s ± 19714.412op/s 21751884.711op/s 21782886.414op/s 21793654.864op/s 21810245.532op/s 0.34% -1.638 6.898 0.17% 2594.533op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.480µs; 536.703µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1863236.084op/s; 1864002.381op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.132µs; 380.231µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2629985.092op/s; 2630670.718op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [195.700µs; 195.782µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5107744.996op/s; 5109870.701op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.124µs; 37.153µs] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26916266.994op/s; 26936645.091op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.006µs; 46.028µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21725976.778op/s; 21736147.161op/s] or [-0.023%; +0.023%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.920µs 0.24% -0.527 5.524 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255101709.960op/s 255683791.216op/s ± 191099.370op/s 255710663.135op/s ± 116709.464op/s 255805270.264op/s 255930909.839op/s 256017836.450op/s 256822390.895op/s 0.43% 0.543 5.610 0.07% 13512.766op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 78.883µs 80.388µs ± 0.810µs 80.329µs ± 0.526µs 80.868µs 81.828µs 82.406µs 84.376µs 5.04% 0.913 2.109 1.01% 0.057µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11851736.109op/s 12440902.252op/s ± 124293.796op/s 12448791.503op/s ± 80953.386op/s 12525501.038op/s 12612905.739op/s 12669483.006op/s 12676951.224op/s 1.83% -0.819 1.696 1.00% 8788.899op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.263µs 74.909µs ± 0.363µs 74.879µs ± 0.073µs 74.959µs 75.135µs 75.252µs 79.601µs 6.31% 10.799 137.531 0.48% 0.026µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12562640.937op/s 13349839.167op/s ± 61590.449op/s 13354806.001op/s ± 13035.676op/s 13367704.962op/s 13388741.074op/s 13418679.881op/s 13465737.035op/s 0.83% -10.464 131.931 0.46% 4355.102op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.890µs 3.911µs ± 0.004µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.919µs 3.939µs 0.71% 1.917 21.294 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 253895009.598op/s 255681653.892op/s ± 243588.864op/s 255709806.476op/s ± 114536.636op/s 255811610.609op/s 255913912.055op/s 255992197.175op/s 257067289.499op/s 0.53% -1.861 21.099 0.10% 17224.334op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 82.560µs 83.661µs ± 0.722µs 83.583µs ± 0.289µs 83.907µs 84.240µs 85.582µs 90.274µs 8.01% 5.231 41.867 0.86% 0.051µs 1 200
credit_card/is_card_number/378282246310005 throughput 11077377.420op/s 11953791.715op/s ± 98847.503op/s 11964161.356op/s ± 41269.670op/s 11996602.276op/s 12063042.076op/s 12100380.596op/s 12112330.969op/s 1.24% -4.820 37.226 0.82% 6989.574op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.121µs 52.188µs ± 0.036µs 52.184µs ± 0.024µs 52.212µs 52.250µs 52.279µs 52.299µs 0.22% 0.551 -0.086 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19120803.544op/s 19161577.653op/s ± 13054.562op/s 19163058.415op/s ± 8974.382op/s 19171674.331op/s 19179149.867op/s 19184759.110op/s 19186136.098op/s 0.12% -0.548 -0.092 0.07% 923.097op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.738µs 5.902µs ± 0.065µs 5.906µs ± 0.045µs 5.946µs 5.999µs 6.019µs 6.044µs 2.34% -0.217 -0.673 1.10% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165441684.835op/s 169458265.379op/s ± 1875819.537op/s 169319976.480op/s ± 1294791.790op/s 170814471.226op/s 172630102.332op/s 173432362.499op/s 174277756.126op/s 2.93% 0.259 -0.652 1.10% 132640.472op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.892µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.919µs 3.921µs 0.26% -1.031 9.194 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255025381.359op/s 255662345.282op/s ± 194498.663op/s 255689491.189op/s ± 116438.048op/s 255781306.491op/s 255902295.907op/s 256020741.765op/s 256966433.370op/s 0.50% 1.055 9.347 0.08% 13753.132op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.098µs 64.317µs ± 0.111µs 64.309µs ± 0.069µs 64.365µs 64.524µs 64.628µs 64.918µs 0.95% 1.681 5.669 0.17% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15404017.763op/s 15547920.521op/s ± 26821.177op/s 15549845.544op/s ± 16637.322op/s 15567857.434op/s 15580438.059op/s 15584037.647op/s 15601143.564op/s 0.33% -1.656 5.521 0.17% 1896.544op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.351µs 57.548µs ± 0.117µs 57.533µs ± 0.068µs 57.602µs 57.737µs 57.995µs 58.273µs 1.29% 2.144 8.905 0.20% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17160729.662op/s 17376946.394op/s ± 35062.873op/s 17381433.167op/s ± 20514.332op/s 17399634.652op/s 17416909.561op/s 17425224.878op/s 17436344.316op/s 0.32% -2.106 8.635 0.20% 2479.320op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.891µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.921µs 0.26% -0.945 8.592 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255046566.937op/s 255703390.552op/s ± 201409.895op/s 255703011.867op/s ± 124889.076op/s 255840166.945op/s 255955138.253op/s 255994006.160op/s 257036344.819op/s 0.52% 0.968 8.742 0.08% 14241.830op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.586µs 54.789µs ± 0.154µs 54.751µs ± 0.080µs 54.853µs 55.069µs 55.323µs 55.520µs 1.40% 1.793 4.658 0.28% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18011672.745op/s 18251877.457op/s ± 51039.428op/s 18264423.642op/s ± 26595.023op/s 18285039.639op/s 18307904.256op/s 18317099.141op/s 18319649.656op/s 0.30% -1.765 4.501 0.28% 3609.033op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.125µs 52.193µs ± 0.041µs 52.187µs ± 0.028µs 52.220µs 52.267µs 52.306µs 52.319µs 0.25% 0.692 0.029 0.08% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19113526.583op/s 19159604.223op/s ± 15059.813op/s 19161978.807op/s ± 10412.080op/s 19171296.256op/s 19178736.056op/s 19183721.136op/s 19184774.963op/s 0.12% -0.688 0.021 0.08% 1064.890op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.755µs 5.900µs ± 0.057µs 5.898µs ± 0.038µs 5.940µs 5.995µs 6.006µs 6.030µs 2.23% -0.165 -0.410 0.97% 0.004µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165849786.304op/s 169512539.474op/s ± 1646588.185op/s 169549466.347op/s ± 1093987.568op/s 170574151.667op/s 172604423.600op/s 172904057.111op/s 173767810.303op/s 2.49% 0.210 -0.387 0.97% 116431.367op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.911µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255657306.681op/s; 255710275.751op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [80.276µs; 80.500µs] or [-0.140%; +0.140%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12423676.327op/s; 12458128.177op/s] or [-0.138%; +0.138%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [74.859µs; 74.959µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13341303.324op/s; 13358375.011op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631 throughput [255647894.818op/s; 255715412.966op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/378282246310005 execution_time [83.561µs; 83.761µs] or [-0.120%; +0.120%] None None None
credit_card/is_card_number/378282246310005 throughput [11940092.401op/s; 11967491.028op/s] or [-0.115%; +0.115%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.183µs; 52.193µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19159768.417op/s; 19163386.890op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.893µs; 5.911µs] or [-0.153%; +0.153%] None None None
credit_card/is_card_number/x371413321323331 throughput [169198294.832op/s; 169718235.927op/s] or [-0.153%; +0.153%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255635389.638op/s; 255689300.926op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.302µs; 64.333µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15544203.364op/s; 15551637.678op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.532µs; 57.564µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17372087.016op/s; 17381805.771op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.910µs; 3.911µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255675477.077op/s; 255731304.026op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.768µs; 54.811µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18244803.884op/s; 18258951.031op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.187µs; 52.199µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19157517.078op/s; 19161691.368op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.892µs; 5.908µs] or [-0.134%; +0.134%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [169284338.187op/s; 169740740.760op/s] or [-0.135%; +0.135%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.841ms 14.897ms ± 0.033ms 14.889ms ± 0.012ms 14.904ms 14.971ms 15.028ms 15.084ms 1.31% 2.499 8.507 0.22% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.893ms; 14.902ms] or [-0.030%; +0.030%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a3d38c5 1753874394 vianney/data-pipeline/fix-deadlock
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 85.781µs 86.128µs ± 0.221µs 86.113µs ± 0.094µs 86.204µs 86.321µs 87.028µs 88.292µs 2.53% 5.380 46.902 0.26% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.097µs; 86.158µs] or [-0.036%; +0.036%] None None None

Baseline

Omitted due to size.

@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/data-pipeline/fix-deadlock branch 2 times, most recently from 6088db2 to 6f45c56 Compare July 29, 2025 16:40
@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/data-pipeline/fix-deadlock branch from 6f45c56 to e81d920 Compare July 29, 2025 16:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.87%. Comparing base (8580cf5) to head (a3d38c5).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
+ Coverage   70.73%   70.87%   +0.14%     
==========================================
  Files         345      345              
  Lines       54022    54023       +1     
==========================================
+ Hits        38213    38290      +77     
+ Misses      15809    15733      -76
Components Coverage Δ
datadog-crashtracker 43.81% <ø> (ø)
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 87.99% <100.00%> (+1.10%) ⬆️
data-pipeline-ffi 88.49% <ø> (ø)
ddcommon 82.99% <ø> (ø)
ddcommon-ffi 70.01% <ø> (ø)
ddtelemetry 60.08% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.13% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 36.49% <ø> (ø)
datdog-sidecar-ffi 8.41% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 91.59% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.94% <ø> (ø)
datadog-tracer-flare 54.62% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VianneyRuhlmann
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 30, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-07-30 14:43:22 UTC ℹ️ Start processing command /merge

2025-07-30 14:43:34 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 40m (p90).

2025-07-30 16:44:01 UTC 🚨 MergeQueue: This merge request is in error

error while getting head build completion result

Details

Error: There was an error while retrieving the result for pipeline 72178569

FullStacktrace:
child workflow execution error (type: mergequeue_private.MergeQueue_WaitForChecksOrUntilIsFinal, workflowID: wait_checks_0b7382ac526247786e6b6bae4ffc5ea9feac42e9, runID: 3d2d1b73-b50e-441f-b039-84475f3c0332, initiatedEventID: 234, startedEventID: 236): child workflow execution error (type: mergequeue.MergeQueue_WaitForCompletionOfRef, workflowID: 3d2d1b73-b50e-441f-b039-84475f3c0332_8, runID: 4ca0d162-b1a1-49df-b964-868475173a2a, initiatedEventID: 8, startedEventID: 10): There was an error while retrieving the result for pipeline 72178569 (type: FlowError, retryable: false): There was an error while retrieving the result for pipeline 72178569

@VianneyRuhlmann
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 31, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-07-31 11:35:12 UTC ℹ️ Start processing command /merge

2025-07-31 11:35:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 40m (p90).

2025-07-31 12:00:11 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 26bc8b5 into main Jul 31, 2025
37 checks passed
@dd-mergequeue dd-mergequeue bot deleted the vianney/data-pipeline/fix-deadlock branch July 31, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekump ekump ekump approved these changes

Assignees
No one assigned
Labels
data-pipeline mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VianneyRuhlmann @codecov-commenter @ekump