fix(ddcommon): fix build on i686 #1144
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1144 +/- ##
==========================================
+ Coverage 71.30% 71.51% +0.21%
==========================================
Files 343 343
Lines 52471 52848 +377
==========================================
+ Hits 37412 37792 +380
+ Misses 15059 15056 -3
🚀 New features to boost your workflow:
|
ekump
approved these changes
Jul 15, 2025
hoolioh
approved these changes
Jul 15, 2025
| @@ -64,9 +64,9 @@ pub fn alt_fork() -> libc::pid_t { | |||
| }; | |||
|
|
|||
| // The max value of a PID is configurable, but within an i32, so the failover | |||
| if res > pid_t::MAX as i64 { | |||
| if (res as i64) > (pid_t::MAX as i64) { | |||
There was a problem hiding this comment.
Nit: probably it would be better to use res as a c_long since the syscall is supposed to return that exact type and then cast pid_t to c_long just to cover the case the where the platform is 64bit
There was a problem hiding this comment.
Not sure it's an issue as we don't support bsd but syscall doesn't always return a c_long 😩
There was a problem hiding this comment.
I saw that but decided to ignore since, as you said, I don't think we will target bsd. Anyway I'll let you decide what's the cleanest way to do it.
VianneyRuhlmann
force-pushed
the
vianney/fix-i686-build
branch
from
fbe5ccd to
7aac992
Compare
BenchmarksComparisonBenchmark execution time: 2025-07-16 12:32:49 Comparing candidate commit 7aac992 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in Use ⏳ Processing |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Build is broken on i686 due to
c_long(return value fromsyscall) being an i32 instead of a i64 see this jobMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.