Skip to content

ekump/APMSP-2155 create metrics module for exporter #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

ekump/APMSP-2155 create metrics module for exporter #1143

wants to merge 10 commits into from

Conversation

ekump
Copy link
Contributor

@ekump ekump commented Jul 14, 2025

What does this PR do?

Moves the metrics emission for the Trace Exporter to a separate file. No functionality should change.

Motivation

An iterative step to refactor the Trace Exporter into smaller sub modules.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

A couple of new unit tests added, but existing ones still apply and haven't changed.

@ekump ekump requested a review from a team as a code owner July 14, 2025 20:04
@pr-commenter
Copy link

pr-commenter bot commented Jul 14, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-07-14 23:01:47

Comparing candidate commit 8555bbb in PR branch ekump/APMSP-2155-create-metrics-module-for-exporter with baseline commit 13b1cc3 in branch ekump/APMSP-2153-break-up-large-trace-exporter-functions.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.913µs 3.915µs 3.916µs 3.918µs 0.17% -2.238 18.653 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255233331.377op/s 255669749.769op/s ± 163000.912op/s 255676950.723op/s ± 82793.194op/s 255746545.875op/s 255886934.363op/s 255938351.560op/s 256969919.646op/s 0.51% 2.268 18.931 0.06% 11525.905op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.808µs 81.187µs ± 0.550µs 81.175µs ± 0.399µs 81.574µs 82.077µs 82.515µs 82.731µs 1.92% 0.217 -0.152 0.68% 0.039µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12087422.871op/s 12317776.623op/s ± 83397.553op/s 12319055.185op/s ± 60310.245op/s 12379036.538op/s 12442520.690op/s 12495779.386op/s 12530041.786op/s 1.71% -0.181 -0.177 0.68% 5897.098op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 75.302µs 75.706µs ± 0.180µs 75.655µs ± 0.065µs 75.786µs 76.048µs 76.354µs 76.677µs 1.35% 1.986 6.419 0.24% 0.013µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13041670.589op/s 13209147.382op/s ± 31304.838op/s 13217867.487op/s ± 11301.864op/s 13226209.654op/s 13241017.627op/s 13261949.739op/s 13279849.157op/s 0.47% -1.955 6.251 0.24% 2213.586op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.918µs 3.920µs 0.23% -1.026 10.750 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255074022.841op/s 255635716.916op/s ± 177109.406op/s 255649803.170op/s ± 96397.381op/s 255741078.413op/s 255850927.742op/s 255906252.035op/s 256862198.704op/s 0.47% 1.051 10.916 0.07% 12523.526op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.536µs 72.866µs ± 0.129µs 72.851µs ± 0.071µs 72.922µs 73.097µs 73.282µs 73.411µs 0.77% 0.884 2.223 0.18% 0.009µs 1 200
credit_card/is_card_number/378282246310005 throughput 13621948.869op/s 13723864.423op/s ± 24285.147op/s 13726734.246op/s ± 13440.888op/s 13739864.735op/s 13756981.096op/s 13774735.393op/s 13786300.553op/s 0.43% -0.865 2.173 0.18% 1717.219op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.672µs 52.868µs ± 0.079µs 52.871µs ± 0.047µs 52.916µs 52.967µs 53.002µs 53.318µs 0.84% 1.278 7.175 0.15% 0.006µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18755303.309op/s 18915182.457op/s ± 28293.121op/s 18913782.468op/s ± 16958.450op/s 18935650.506op/s 18955222.081op/s 18981800.635op/s 18985447.654op/s 0.38% -1.245 6.987 0.15% 2000.626op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.427µs 6.438µs ± 0.007µs 6.436µs ± 0.003µs 6.441µs 6.450µs 6.459µs 6.461µs 0.38% 1.263 1.885 0.10% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 154783153.489op/s 155331041.669op/s ± 158795.498op/s 155365339.858op/s ± 81509.740op/s 155440314.629op/s 155536145.495op/s 155560522.400op/s 155600546.928op/s 0.15% -1.256 1.863 0.10% 11228.537op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.896µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.918µs 3.921µs 3.934µs 0.55% 0.921 10.458 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254181544.869op/s 255568928.745op/s ± 217461.501op/s 255578906.716op/s ± 128483.227op/s 255707479.444op/s 255839204.673op/s 255928988.444op/s 256678535.581op/s 0.43% -0.891 10.369 0.08% 15376.850op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.955µs 65.102µs ± 0.087µs 65.087µs ± 0.049µs 65.145µs 65.271µs 65.355µs 65.502µs 0.64% 1.244 2.303 0.13% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15266768.439op/s 15360492.720op/s ± 20484.118op/s 15364140.097op/s ± 11572.427op/s 15373694.458op/s 15386543.392op/s 15388995.123op/s 15395253.643op/s 0.20% -1.233 2.258 0.13% 1448.446op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.167µs 58.337µs ± 0.112µs 58.308µs ± 0.056µs 58.376µs 58.548µs 58.696µs 58.868µs 0.96% 1.516 3.116 0.19% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16987098.990op/s 17141921.350op/s ± 32811.164op/s 17150437.807op/s ± 16589.483op/s 17163570.752op/s 17181380.967op/s 17186510.193op/s 17191892.304op/s 0.24% -1.500 3.038 0.19% 2320.100op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.918µs 3.921µs 3.925µs 0.34% -0.104 5.180 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254745113.417op/s 255599325.015op/s ± 205180.618op/s 255600660.806op/s ± 127457.191op/s 255743821.705op/s 255851051.911op/s 255917714.596op/s 256739357.943op/s 0.45% 0.122 5.232 0.08% 14508.461op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 55.102µs 55.441µs ± 0.158µs 55.423µs ± 0.094µs 55.525µs 55.738µs 55.864µs 56.024µs 1.08% 0.709 0.814 0.28% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17849618.053op/s 18037467.956op/s ± 51208.399op/s 18042938.306op/s ± 30700.890op/s 18073039.543op/s 18108977.707op/s 18135091.724op/s 18148212.541op/s 0.58% -0.689 0.775 0.28% 3620.981op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.595µs 52.828µs ± 0.070µs 52.827µs ± 0.042µs 52.870µs 52.938µs 52.991µs 53.061µs 0.44% 0.028 0.704 0.13% 0.005µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18846237.319op/s 18929247.120op/s ± 24995.455op/s 18929538.579op/s ± 14947.027op/s 18943604.889op/s 18967938.400op/s 18993321.988op/s 19013358.786op/s 0.44% -0.017 0.704 0.13% 1767.446op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.427µs 6.437µs ± 0.005µs 6.436µs ± 0.003µs 6.440µs 6.447µs 6.454µs 6.461µs 0.38% 1.139 2.289 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154777192.057op/s 155347880.284op/s ± 132132.516op/s 155369811.677op/s ± 82066.671op/s 155442330.849op/s 155523763.478op/s 155577532.168op/s 155586595.003op/s 0.14% -1.132 2.257 0.08% 9343.180op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255647159.410op/s; 255692340.127op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.111µs; 81.263µs] or [-0.094%; +0.094%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12306218.524op/s; 12329334.722op/s] or [-0.094%; +0.094%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [75.681µs; 75.731µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13204808.832op/s; 13213485.931op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255611171.256op/s; 255660262.576op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.848µs; 72.884µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/378282246310005 throughput [13720498.735op/s; 13727230.111op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.857µs; 52.879µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [18911261.302op/s; 18919103.611op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.437µs; 6.439µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/x371413321323331 throughput [155309034.140op/s; 155353049.197op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [255538790.672op/s; 255599066.817op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.090µs; 65.114µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15357653.818op/s; 15363331.622op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.321µs; 58.352µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17137374.039op/s; 17146468.662op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255570888.955op/s; 255627761.076op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.419µs; 55.462µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18030370.965op/s; 18044564.948op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.819µs; 52.838µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [18925782.991op/s; 18932711.250op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.436µs; 6.438µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155329567.988op/s; 155366192.580op/s] or [-0.012%; +0.012%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.494µs 536.241µs ± 0.736µs 536.179µs ± 0.247µs 536.419µs 536.892µs 537.513µs 545.062µs 1.66% 8.729 101.472 0.14% 0.052µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1834654.464op/s 1864836.342op/s ± 2529.424op/s 1865047.571op/s ± 858.450op/s 1865954.084op/s 1866887.393op/s 1867207.227op/s 1867434.761op/s 0.13% -8.617 99.667 0.14% 178.857op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 381.318µs 382.808µs ± 0.546µs 382.830µs ± 0.405µs 383.209µs 383.696µs 384.031µs 384.411µs 0.41% 0.080 -0.154 0.14% 0.039µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2601385.611op/s 2612283.234op/s ± 3728.732op/s 2612122.223op/s ± 2759.136op/s 2614921.316op/s 2617927.550op/s 2620557.043op/s 2622479.783op/s 0.40% -0.072 -0.157 0.14% 263.661op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 195.359µs 195.907µs ± 0.327µs 195.862µs ± 0.159µs 196.027µs 196.603µs 196.934µs 197.004µs 0.58% 1.153 1.629 0.17% 0.023µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5076046.524op/s 5104483.375op/s ± 8508.572op/s 5105626.003op/s ± 4153.233op/s 5109762.231op/s 5116122.037op/s 5118367.109op/s 5118768.220op/s 0.26% -1.142 1.599 0.17% 601.647op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 38.023µs 38.144µs ± 0.052µs 38.133µs ± 0.026µs 38.170µs 38.226µs 38.275µs 38.510µs 0.99% 2.012 10.926 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 25967305.308op/s 26216424.105op/s ± 35898.420op/s 26223733.244op/s ± 18021.105op/s 26238251.208op/s 26259604.457op/s 26281940.609op/s 26299554.113op/s 0.29% -1.976 10.623 0.14% 2538.402op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.883µs 46.028µs ± 0.192µs 46.008µs ± 0.038µs 46.046µs 46.119µs 46.195µs 48.287µs 4.95% 9.575 102.369 0.42% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20709685.678op/s 21726055.961op/s ± 87366.795op/s 21735443.353op/s ± 17741.227op/s 21753122.311op/s 21771164.357op/s 21778654.567op/s 21794458.318op/s 0.27% -9.418 99.569 0.40% 6177.765op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.139µs; 536.343µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1864485.788op/s; 1865186.896op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [382.732µs; 382.883µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2611766.467op/s; 2612800.000op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [195.861µs; 195.952µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5103304.169op/s; 5105662.581op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [38.137µs; 38.151µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26211448.929op/s; 26221399.281op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.002µs; 46.055µs] or [-0.058%; +0.058%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21713947.763op/s; 21738164.158op/s] or [-0.056%; +0.056%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.339µs 2.396µs ± 0.021µs 2.389µs ± 0.013µs 2.411µs 2.436µs 2.441µs 2.443µs 2.26% 0.163 -0.229 0.87% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.393µs; 2.398µs] or [-0.121%; +0.121%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.446µs 24.991µs ± 9.663µs 17.698µs ± 0.165µs 34.287µs 42.938µs 44.538µs 69.987µs 295.45% 1.080 1.031 38.57% 0.683µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.651µs; 26.330µs] or [-5.359%; +5.359%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.364µs 34.718µs ± 0.582µs 34.474µs ± 0.040µs 34.533µs 35.823µs 35.866µs 38.873µs 12.76% 2.853 12.204 1.67% 0.041µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.637µs; 34.799µs] or [-0.232%; +0.232%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 71.731ms 71.841ms ± 0.061ms 71.828ms ± 0.031ms 71.866ms 71.956ms 72.031ms 72.138ms 0.43% 1.512 3.868 0.08% 0.004ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [71.832ms; 71.849ms] or [-0.012%; +0.012%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.248µs 3.224µs ± 1.455µs 2.993µs ± 0.027µs 3.018µs 3.645µs 13.802µs 15.362µs 413.30% 7.364 55.550 45.02% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.022µs; 3.425µs] or [-6.255%; +6.255%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.257ms 8.274ms ± 0.010ms 8.273ms ± 0.005ms 8.278ms 8.290ms 8.297ms 8.335ms 0.75% 1.809 8.151 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.273ms; 8.275ms] or [-0.016%; +0.016%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.315ns 254.279ns ± 14.639ns 246.295ns ± 1.477ns 259.018ns 287.977ns 302.571ns 303.250ns 23.12% 1.735 2.082 5.74% 1.035ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [252.250ns; 256.308ns] or [-0.798%; +0.798%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.615µs 205.118µs ± 0.362µs 205.066µs ± 0.176µs 205.243µs 205.674µs 205.907µs 208.293µs 1.57% 3.748 28.188 0.18% 0.026µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4800928.837op/s 4875249.839op/s ± 8555.628op/s 4876473.009op/s ± 4179.498op/s 4880557.748op/s 4884881.109op/s 4886250.358op/s 4887230.459op/s 0.22% -3.664 27.198 0.18% 604.974op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.202µs 18.326µs ± 0.118µs 18.296µs ± 0.049µs 18.368µs 18.508µs 18.597µs 19.475µs 6.44% 4.963 42.788 0.64% 0.008µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 51347549.557op/s 54568346.532op/s ± 341946.163op/s 54655989.920op/s ± 145280.644op/s 54775093.584op/s 54868572.595op/s 54933080.917op/s 54938231.423op/s 0.52% -4.593 37.838 0.63% 24179.245op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.600µs 10.826µs ± 0.096µs 10.824µs ± 0.068µs 10.894µs 10.980µs 11.035µs 11.075µs 2.32% 0.115 -0.446 0.88% 0.007µs 1 200
normalization/normalize_name/normalize_name/good throughput 90292893.605op/s 92380570.750op/s ± 816517.198op/s 92390806.257op/s ± 584484.692op/s 92965674.444op/s 93707707.170op/s 94051144.534op/s 94341864.671op/s 2.11% -0.074 -0.456 0.88% 57736.485op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [205.068µs; 205.169µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4874064.111op/s; 4876435.567op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.310µs; 18.343µs] or [-0.090%; +0.090%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54520956.083op/s; 54615736.982op/s] or [-0.087%; +0.087%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.812µs; 10.839µs] or [-0.123%; +0.123%] None None None
normalization/normalize_name/normalize_name/good throughput [92267409.319op/s; 92493732.180op/s] or [-0.122%; +0.122%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.998µs 5.058µs ± 0.045µs 5.058µs ± 0.042µs 5.091µs 5.139µs 5.147µs 5.156µs 1.93% 0.493 -1.078 0.89% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.052µs; 5.065µs] or [-0.124%; +0.124%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 87.632µs 87.820µs ± 0.127µs 87.803µs ± 0.057µs 87.866µs 87.966µs 88.093µs 89.113µs 1.49% 5.679 53.299 0.14% 0.009µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [87.802µs; 87.838µs] or [-0.020%; +0.020%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 8555bbb 1752533414 ekump/APMSP-2155-create-metrics-module-for-exporter
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 152.303µs 152.809µs ± 0.340µs 152.730µs ± 0.146µs 152.910µs 153.320µs 154.084µs 155.489µs 1.81% 3.457 20.462 0.22% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [152.762µs; 152.856µs] or [-0.031%; +0.031%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (13b1cc3) to head (8555bbb).

Additional details and impacted files 
@@                                    Coverage Diff                                    @@
##           ekump/APMSP-2153-break-up-large-trace-exporter-functions    #1143   +/-   ##
=========================================================================================
  Coverage                                                     71.22%   71.23%           
=========================================================================================
  Files                                                           344      345    +1     
  Lines                                                         52701    52730   +29     
=========================================================================================
+ Hits                                                          37537    37560   +23     
- Misses                                                        15164    15170    +6
Components Coverage Δ
datadog-crashtracker 43.94% <ø> (+0.02%) ⬆️
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 88.03% <92.68%> (+0.06%) ⬆️
data-pipeline-ffi 87.61% <ø> (ø)
ddcommon 82.88% <ø> (ø)
ddcommon-ffi 69.66% <ø> (ø)
ddtelemetry 60.08% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.13% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 40.28% <ø> (ø)
datdog-sidecar-ffi 5.17% <ø> (ø)
spawn-worker 55.35% <ø> (ø)
tinybytes 90.96% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.17% <ø> (ø)
datadog-tracer-flare 78.54% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekump
Copy link
Contributor Author

ekump commented Jul 14, 2025 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 9.24 MB 9.24 MB +.02% (+2.47 KB) 🔍
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 70.23 MB 70.28 MB +.06% (+46.75 KB) 🔍
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.10 MB 22.11 MB +.05% (+12.39 KB) 🔍
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 26.16 MB 26.17 MB +.05% (+13.71 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.09 MB 9.16 MB +.71% (+66.46 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 82.45 MB 82.50 MB +.05% (+48.25 KB) 🔍
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.37 MB 18.39 MB +.09% (+18.00 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 64.65 KB 64.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 124.80 MB 124.96 MB +.13% (+168.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 644.68 MB 646.87 MB +.33% (+2.18 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.87 MB 5.88 MB +.24% (+14.50 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 64.65 KB 64.65 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.33 MB 17.34 MB +.04% (+8.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.14 MB 32.17 MB +.08% (+27.65 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.66 MB 15.68 MB +.12% (+20.50 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 65.65 KB 65.65 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.13 MB 127.30 MB +.13% (+176.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 634.31 MB 636.51 MB +.34% (+2.20 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.47 MB 4.48 MB +.17% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 65.65 KB 65.65 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.47 MB 18.48 MB +.04% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.18 MB 30.21 MB +.08% (+25.80 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 62.96 MB 63.00 MB +.06% (+42.62 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.83 MB 9.84 MB +.05% (+5.85 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.95 MB 20.96 MB +.04% (+10.39 KB) 🔍
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 77.43 MB 77.46 MB +.04% (+33.98 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.74 MB 9.74 MB +.01% (+1.85 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 24.08 MB 24.09 MB +.02% (+7.34 KB) 🔍

@ekump ekump force-pushed the ekump/APMSP-2155-create-metrics-module-for-exporter branch from c0809ff to 8555bbb Compare July 14, 2025 22:50
@ekump ekump changed the base branch from ekump/APMSP-2153-break-up-large-trace-exporter-functions to main July 15, 2025 18:31
@ekump
Copy link
Contributor Author

ekump commented Jul 15, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 15, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-07-15 18:31:54 UTC ℹ️ Start processing command /merge

2025-07-15 18:32:09 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-07-15 18:40:27 UTC ⚠️ MergeQueue: This merge request was unqueued

edmund.kump@datadoghq.com unqueued this merge request

@ekump
Copy link
Contributor Author

ekump commented Jul 15, 2025

/merge -c

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 15, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-07-15 18:40:22 UTC ℹ️ Start processing command /merge -c

@ekump
Copy link
Contributor Author

ekump commented Jul 15, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 15, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-07-15 18:40:46 UTC ℹ️ Start processing command /merge

2025-07-15 18:40:58 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-07-15 18:45:29 UTC ⚠️ MergeQueue: This merge request was unqueued

edmund.kump@datadoghq.com unqueued this merge request

@ekump
Copy link
Contributor Author

ekump commented Jul 15, 2025

/merge -c

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 15, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-07-15 18:45:23 UTC ℹ️ Start processing command /merge -c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoolioh hoolioh hoolioh approved these changes

Assignees
No one assigned
Labels
data-pipeline mergequeue-status: removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekump @codecov-commenter @hoolioh