Implement with_endpoint for SendData
#1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 71.27% 71.29% +0.01%
==========================================
Files 343 343
Lines 52396 52471 +75
==========================================
+ Hits 37347 37410 +63
- Misses 15049 15061 +12
🚀 New features to boost your workflow:
|
hoolioh
reviewed
Jul 11, 2025
BenchmarksComparisonBenchmark execution time: 2025-07-11 14:40:27 Comparing candidate commit 27aef15 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
ekump
reviewed
Jul 11, 2025
| @@ -205,13 +205,16 @@ impl SendData { | |||
| self.retry_strategy = retry_strategy; | |||
| } | |||
|
|
|||
| /// Overrides the set target Endpoint. | |||
| /// Returns a copy of the SendData with the user-defined endpoint. | |||
There was a problem hiding this comment.
nit: Clone and Copy are different.
Suggested change
| /// Returns a copy of the SendData with the user-defined endpoint. | |
| /// Returns a clone of the SendData with the user-defined endpoint. |
ekump
reviewed
Jul 11, 2025
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
ekump
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements a function
with_endpointforSendDatathat returns a copy of theSendDatausing the user-defined endpoint.Motivation
Supporting dual shipping for traces in the Lambda Extension - need to be able to make a copy of the original traces
SendDataand send it to another endpoint.Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.