Skip to content

feat(sidecar): add telemetry clients expiration #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat(sidecar): add telemetry clients expiration #1077

wants to merge 15 commits into from
+694 −1,126

Conversation

Leiyks
Copy link
Contributor

@Leiyks Leiyks commented May 28, 2025

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented May 28, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-07-16 13:03:40

Comparing candidate commit 2b562ab in PR branch leiyks-reduce-telemetry-size with baseline commit 034bb32 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.205µs 3.227µs ± 1.440µs 3.002µs ± 0.033µs 3.032µs 3.675µs 13.850µs 15.200µs 406.31% 7.319 55.034 44.50% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.028µs; 3.427µs] or [-6.183%; +6.183%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.913µs ± 0.006µs 3.912µs ± 0.002µs 3.914µs 3.918µs 3.922µs 3.965µs 1.35% 6.228 52.107 0.15% 0.000µs 1 200
credit_card/is_card_number/ throughput 252205789.267op/s 255569264.985op/s ± 393194.135op/s 255619490.991op/s ± 131529.986op/s 255743983.867op/s 255850801.609op/s 255945061.927op/s 256749106.300op/s 0.44% -6.157 51.374 0.15% 27803.024op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.850µs 81.415µs ± 0.632µs 81.412µs ± 0.404µs 81.810µs 82.482µs 82.929µs 83.538µs 2.61% 0.224 0.174 0.77% 0.045µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11970600.206op/s 12283491.917op/s ± 95238.080op/s 12283191.682op/s ± 61029.244op/s 12344936.495op/s 12436026.317op/s 12479781.091op/s 12523457.301op/s 1.96% -0.175 0.124 0.77% 6734.349op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 75.149µs 75.657µs ± 0.151µs 75.629µs ± 0.054µs 75.700µs 75.918µs 76.102µs 76.298µs 0.88% 0.799 3.063 0.20% 0.011µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13106573.193op/s 13217592.422op/s ± 26349.256op/s 13222372.115op/s ± 9438.411op/s 13230564.345op/s 13261189.671op/s 13274413.460op/s 13306966.197op/s 0.64% -0.772 3.013 0.20% 1863.174op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.914µs 3.917µs 3.919µs 3.920µs 0.18% -1.323 10.403 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255113065.692op/s 255580276.896op/s ± 188648.096op/s 255579451.413op/s ± 118779.663op/s 255705158.778op/s 255808522.346op/s 255885870.589op/s 256897305.704op/s 0.52% 1.347 10.586 0.07% 13339.435op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.537µs 72.850µs ± 0.121µs 72.841µs ± 0.069µs 72.905µs 73.090µs 73.206µs 73.299µs 0.63% 0.823 1.544 0.17% 0.009µs 1 200
credit_card/is_card_number/378282246310005 throughput 13642761.714op/s 13726884.989op/s ± 22676.434op/s 13728580.492op/s ± 13040.978op/s 13741721.702op/s 13757522.961op/s 13774236.909op/s 13786127.020op/s 0.42% -0.809 1.517 0.16% 1603.466op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.673µs 52.861µs ± 0.070µs 52.865µs ± 0.046µs 52.910µs 52.964µs 53.007µs 53.024µs 0.30% -0.166 -0.356 0.13% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 18859262.752op/s 18917674.767op/s ± 24945.243op/s 18916242.661op/s ± 16508.585op/s 18932896.608op/s 18960219.769op/s 18971203.056op/s 18984880.441op/s 0.36% 0.172 -0.354 0.13% 1763.895op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.429µs 6.437µs ± 0.004µs 6.437µs ± 0.003µs 6.440µs 6.444µs 6.447µs 6.449µs 0.19% 0.298 -0.408 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 155065539.139op/s 155349301.881op/s ± 103373.491op/s 155355234.390op/s ± 69283.829op/s 155419839.344op/s 155512667.377op/s 155545639.564op/s 155553780.467op/s 0.13% -0.295 -0.410 0.07% 7309.610op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.916µs 3.921µs 3.932µs 0.51% 0.949 19.762 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254320133.926op/s 255606814.810op/s ± 197642.995op/s 255615068.512op/s ± 87399.526op/s 255698814.809op/s 255817356.496op/s 255892768.490op/s 256881375.678op/s 0.50% -0.901 19.745 0.08% 13975.470op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.940µs 65.100µs ± 0.103µs 65.072µs ± 0.046µs 65.137µs 65.316µs 65.492µs 65.614µs 0.83% 1.844 4.519 0.16% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15240689.077op/s 15361072.525op/s ± 24259.154op/s 15367579.786op/s ± 10989.409op/s 15377088.523op/s 15386072.143op/s 15389934.677op/s 15398838.928op/s 0.20% -1.829 4.438 0.16% 1715.381op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.175µs 58.331µs ± 0.116µs 58.298µs ± 0.054µs 58.373µs 58.549µs 58.729µs 58.967µs 1.15% 1.976 5.529 0.20% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16958584.376op/s 17143730.719op/s ± 34048.793op/s 17153259.941op/s ± 15744.210op/s 17166726.592op/s 17177477.583op/s 17187546.266op/s 17189512.678op/s 0.21% -1.955 5.394 0.20% 2407.613op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.890µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.913µs 3.917µs 3.919µs 3.923µs 0.28% -1.327 13.732 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254912424.717op/s 255628699.970op/s ± 194791.122op/s 255636888.414op/s ± 102409.873op/s 255754270.979op/s 255836029.205op/s 255929870.357op/s 257055964.986op/s 0.56% 1.359 13.964 0.08% 13773.812op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 55.161µs 55.464µs ± 0.154µs 55.443µs ± 0.080µs 55.529µs 55.748µs 56.004µs 56.098µs 1.18% 1.199 2.591 0.28% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17826015.918op/s 18029991.140op/s ± 49790.939op/s 18036691.217op/s ± 26160.267op/s 18058768.222op/s 18095706.523op/s 18119225.046op/s 18128650.519op/s 0.51% -1.174 2.499 0.28% 3520.751op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.699µs 52.883µs ± 0.079µs 52.885µs ± 0.054µs 52.934µs 53.014µs 53.058µs 53.139µs 0.48% 0.040 -0.135 0.15% 0.006µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 18818497.474op/s 18909835.360op/s ± 28294.623op/s 18908784.968op/s ± 19168.616op/s 18928428.312op/s 18959455.205op/s 18967907.802op/s 18975694.034op/s 0.35% -0.031 -0.142 0.15% 2000.732op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.427µs 6.438µs ± 0.005µs 6.437µs ± 0.003µs 6.441µs 6.445µs 6.449µs 6.464µs 0.42% 0.985 3.595 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 154693268.334op/s 155337953.560op/s ± 118047.827op/s 155348393.264op/s ± 75791.358op/s 155418354.917op/s 155499845.688op/s 155568775.364op/s 155596066.604op/s 0.16% -0.974 3.539 0.08% 8347.242op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.914µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number/ throughput [255514772.060op/s; 255623757.911op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.327µs; 81.503µs] or [-0.108%; +0.108%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12270292.836op/s; 12296690.999op/s] or [-0.107%; +0.107%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [75.636µs; 75.678µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13213940.669op/s; 13221244.176op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255554132.084op/s; 255606421.708op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.833µs; 72.867µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/378282246310005 throughput [13723742.254op/s; 13730027.725op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.851µs; 52.870µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [18914217.596op/s; 18921131.938op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.437µs; 6.438µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [155334975.309op/s; 155363628.453op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255579423.392op/s; 255634206.229op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.085µs; 65.114µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15357710.439op/s; 15364434.610op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.314µs; 58.347µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17139011.884op/s; 17148449.554op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255601703.794op/s; 255655696.146op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [55.442µs; 55.485µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18023090.595op/s; 18036891.685op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.872µs; 52.894µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [18905913.998op/s; 18913756.723op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.437µs; 6.438µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [155321593.267op/s; 155354313.854op/s] or [-0.011%; +0.011%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.837µs 34.230µs ± 0.676µs 33.926µs ± 0.048µs 34.030µs 35.617µs 35.652µs 37.672µs 11.04% 1.992 3.301 1.97% 0.048µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.136µs; 34.324µs] or [-0.274%; +0.274%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 151.093µs 151.967µs ± 0.336µs 151.937µs ± 0.169µs 152.109µs 152.508µs 152.990µs 153.785µs 1.22% 1.469 5.953 0.22% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [151.920µs; 152.013µs] or [-0.031%; +0.031%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.764µs 25.998µs ± 9.681µs 18.241µs ± 0.308µs 34.782µs 41.784µs 45.238µs 70.629µs 287.20% 0.914 0.722 37.15% 0.685µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.656µs; 27.340µs] or [-5.161%; +5.161%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 73.116ms 73.440ms ± 0.134ms 73.433ms ± 0.059ms 73.501ms 73.632ms 73.799ms 74.263ms 1.13% 1.242 7.507 0.18% 0.009ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [73.422ms; 73.459ms] or [-0.025%; +0.025%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.942µs 87.172µs ± 0.147µs 87.151µs ± 0.056µs 87.225µs 87.320µs 87.421µs 88.829µs 1.93% 7.187 77.898 0.17% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [87.152µs; 87.193µs] or [-0.023%; +0.023%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.274ms 8.293ms ± 0.011ms 8.293ms ± 0.007ms 8.299ms 8.311ms 8.329ms 8.354ms 0.74% 1.696 6.167 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.292ms; 8.295ms] or [-0.018%; +0.018%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.037µs 536.206µs ± 0.684µs 536.140µs ± 0.301µs 536.460µs 536.866µs 537.373µs 543.752µs 1.42% 6.733 72.180 0.13% 0.048µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1839074.690op/s 1864956.438op/s ± 2359.457op/s 1865185.899op/s ± 1048.579op/s 1866075.085op/s 1867310.754op/s 1868395.977op/s 1869028.797op/s 0.21% -6.624 70.601 0.13% 166.839op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 382.384µs 383.323µs ± 0.339µs 383.311µs ± 0.196µs 383.483µs 383.925µs 384.137µs 384.392µs 0.28% 0.417 0.436 0.09% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2601508.309op/s 2608769.212op/s ± 2303.468op/s 2608850.457op/s ± 1331.906op/s 2610260.452op/s 2611983.972op/s 2613288.932op/s 2615168.912op/s 0.24% -0.411 0.430 0.09% 162.880op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 195.389µs 195.904µs ± 0.231µs 195.893µs ± 0.156µs 196.055µs 196.310µs 196.383µs 196.712µs 0.42% 0.282 -0.147 0.12% 0.016µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5083561.715op/s 5104546.626op/s ± 6008.335op/s 5104840.665op/s ± 4073.314op/s 5108649.380op/s 5113675.356op/s 5115712.958op/s 5117982.976op/s 0.26% -0.276 -0.156 0.12% 424.853op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 38.155µs 38.254µs ± 0.048µs 38.251µs ± 0.033µs 38.285µs 38.345µs 38.364µs 38.375µs 0.32% 0.326 -0.363 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26058847.431op/s 26141010.611op/s ± 32580.976op/s 26142829.086op/s ± 22746.296op/s 26164400.014op/s 26190321.910op/s 26202470.889op/s 26208580.438op/s 0.25% -0.321 -0.368 0.12% 2303.823op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.868µs 46.008µs ± 0.184µs 45.987µs ± 0.040µs 46.033µs 46.105µs 46.237µs 48.425µs 5.30% 11.452 147.465 0.40% 0.013µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20650608.402op/s 21735662.833op/s ± 83157.105op/s 21745263.263op/s ± 18943.017op/s 21762261.650op/s 21782834.640op/s 21798946.363op/s 21801615.964op/s 0.26% -11.231 143.534 0.38% 5880.095op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.112µs; 536.301µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1864629.440op/s; 1865283.436op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [383.276µs; 383.370µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2608449.973op/s; 2609088.450op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [195.872µs; 195.936µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5103713.929op/s; 5105379.324op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [38.248µs; 38.261µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26136495.202op/s; 26145526.021op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.983µs; 46.034µs] or [-0.055%; +0.055%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21724138.058op/s; 21747187.608op/s] or [-0.053%; +0.053%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 246.534ns 257.495ns ± 13.723ns 250.313ns ± 2.812ns 260.885ns 285.720ns 292.181ns 295.958ns 18.24% 1.269 0.101 5.32% 0.970ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [255.594ns; 259.397ns] or [-0.739%; +0.739%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.896µs 206.393µs ± 0.357µs 206.347µs ± 0.167µs 206.535µs 206.777µs 207.968µs 209.640µs 1.60% 4.628 35.775 0.17% 0.025µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4770088.195op/s 4845130.235op/s ± 8323.431op/s 4846215.820op/s ± 3931.660op/s 4849628.106op/s 4853609.690op/s 4856186.122op/s 4856826.657op/s 0.22% -4.544 34.775 0.17% 588.555op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.205µs 18.379µs ± 0.113µs 18.359µs ± 0.068µs 18.430µs 18.604µs 18.758µs 18.763µs 2.20% 1.205 1.574 0.61% 0.008µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53296333.436op/s 54411761.185op/s ± 331548.723op/s 54469073.115op/s ± 202171.237op/s 54662605.431op/s 54820651.710op/s 54892747.668op/s 54928620.488op/s 0.84% -1.166 1.449 0.61% 23444.035op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.661µs 10.818µs ± 0.068µs 10.816µs ± 0.050µs 10.866µs 10.922µs 10.955µs 11.024µs 1.93% 0.086 -0.442 0.63% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 90707972.261op/s 92446402.804op/s ± 580274.110op/s 92455230.016op/s ± 427275.764op/s 92881781.362op/s 93358442.462op/s 93713797.695op/s 93801375.944op/s 1.46% -0.057 -0.455 0.63% 41031.576op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.344µs; 206.443µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4843976.688op/s; 4846283.782op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.363µs; 18.395µs] or [-0.085%; +0.085%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54365811.721op/s; 54457710.649op/s] or [-0.084%; +0.084%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.808µs; 10.827µs] or [-0.087%; +0.087%] None None None
normalization/normalize_name/normalize_name/good throughput [92365982.393op/s; 92526823.215op/s] or [-0.087%; +0.087%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.011µs 5.088µs ± 0.043µs 5.093µs ± 0.039µs 5.104µs 5.163µs 5.166µs 5.169µs 1.48% 0.228 -0.889 0.84% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.082µs; 5.094µs] or [-0.117%; +0.117%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 2b562ab 1752670324 leiyks-reduce-telemetry-size
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.380µs 2.421µs ± 0.018µs 2.422µs ± 0.009µs 2.428µs 2.468µs 2.477µs 2.482µs 2.46% 1.116 2.353 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.419µs; 2.424µs] or [-0.102%; +0.102%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.80808% with 491 lines in your changes missing coverage. Please review.

Project coverage is 71.28%. Comparing base (2a14f03) to head (2b562ab).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   71.23%   71.28%   +0.05%     
==========================================
  Files         343      340       -3     
  Lines       52393    52352      -41     
==========================================
- Hits        37321    37319       -2     
+ Misses      15072    15033      -39
Components Coverage Δ
datadog-crashtracker 43.91% <ø> (ø)
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 89.38% <ø> (+0.17%) ⬆️
data-pipeline-ffi 88.36% <ø> (+0.81%) ⬆️
ddcommon 82.88% <ø> (ø)
ddcommon-ffi 69.66% <ø> (ø)
ddtelemetry 60.08% <ø> (ø)
ddtelemetry-ffi 21.32% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.58% <ø> (ø)
datadog-profiling 77.13% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 39.07% <0.80%> (-1.21%) ⬇️
datdog-sidecar-ffi 11.12% <28.57%> (+5.95%) ⬆️
spawn-worker 55.35% <ø> (ø)
tinybytes 90.96% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 77.10% <ø> (ø)
datadog-trace-utils 89.17% <ø> (+0.08%) ⬆️
datadog-tracer-flare 78.54% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 88e2fff to d0dd988 Compare June 3, 2025 14:07
@r1viollet
Copy link
Contributor

r1viollet commented Jun 3, 2025 •
edited by ekump
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 9.24 MB 9.24 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 22.10 MB 22.10 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 70.23 MB 70.23 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 26.15 MB 26.15 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.09 MB 9.09 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 82.44 MB 82.44 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.37 MB 18.37 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 64.26 KB 64.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 124.56 MB 124.57 MB +0% (+8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 643.66 MB 643.66 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.86 MB 5.86 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 64.26 KB 64.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.33 MB 17.33 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.13 MB 32.13 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.66 MB 15.66 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 65.25 KB 65.25 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 126.89 MB 126.91 MB +.01% (+24.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 633.28 MB 633.28 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.47 MB 4.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 65.25 KB 65.25 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.47 MB 18.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.18 MB 30.18 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 62.95 MB 62.95 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.83 MB 9.83 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 20.95 MB 20.95 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 77.42 MB 77.42 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.74 MB 9.74 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 24.08 MB 24.08 MB 0% (0 B) 👌

bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 4, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 12, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 4 times, most recently from 8108039 to e69e142 Compare June 17, 2025 13:23
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jun 17, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from e69e142 to 2671326 Compare June 18, 2025 11:35
bwoebi
bwoebi reviewed Jun 18, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 9257c8b to 97e94de Compare June 18, 2025 12:57
bwoebi
bwoebi reviewed Jun 18, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 2 times, most recently from bd0fe85 to 74e40d7 Compare June 18, 2025 14:09
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch 3 times, most recently from bfe0484 to c38ee2c Compare July 7, 2025 13:53
Leiyks added 11 commits July 8, 2025 15:20
@Leiyks
feat(sidecar): add telemetry clients expiration
32ca7b4 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): buffer integrations and dependencies
247ddaf 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): replace tokio Mutex by standard one for consistency
06d4247 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): use cached telemetry clients
70048d2 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): update TelemetryCachedClient structs
59543be 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): clean sidecar server telemetry behaviour
3ac5f38 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): remove unused AppInstance and EnqueuedTelemetryData an…
bcf421c 
…d refacto telemetry

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): apply feedbacks
de8d92e 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
feat(sidecar): expose path_for_telemetry
66adc23 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
chore: add debug logs
8ac121f 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks
chore: fix telemetry lifecycle
ea5b305 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
bwoebi
bwoebi reviewed Jul 8, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jul 8, 2025
View reviewed changes
bwoebi
bwoebi reviewed Jul 8, 2025
View reviewed changes
@Leiyks
chore: merge telemetry module
f1c42c2 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from c38ee2c to f1c42c2 Compare July 8, 2025 15:20
@github-actions github-actions bot removed the telemetry label Jul 8, 2025
@Leiyks
feat: apply PR suggestions
c344794 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks marked this pull request as ready for review July 9, 2025 15:16
@Leiyks Leiyks requested review from a team as code owners July 9, 2025 15:16
bwoebi
bwoebi reviewed Jul 11, 2025
View reviewed changes
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from a9a1761 to 7b88200 Compare July 11, 2025 14:55
@Leiyks
feat: remove needs for version
37ec4be 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from 7b88200 to 37ec4be Compare July 11, 2025 14:59
@Leiyks
feat(sidecar: telemetry): handle config buffering
2b562ab 
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks-reduce-telemetry-size branch from d7537b7 to 2b562ab Compare July 16, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Leiyks @codecov-commenter @r1viollet @bwoebi