Repository navigation
Conversation
Overall package sizeSelf size: 53.9 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------|🤖 This report was automatically generated by heaviest-objects-in-the-universe |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a1ce25dac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Aaalibaba42
left a comment
There was a problem hiding this comment.
Can't really review the "js" side of the PR
| rustflags = ["-C", "link-args=-Wl,-undefined,dynamic_lookup"] | ||
|
|
||
| [target.wasm32-wasip1-threads] | ||
| rustflags = ["--cfg", "tokio_unstable"] |
There was a problem hiding this comment.
This is, as per the name, unstable. The whole capability architecture was made so that we did not need to either compile to wasi nor have unstable/nightly features enabled. I'm not opposing this change of direction, but it has to be thought-out properly.
Node 24.20.0 / V8 13.6: option preparation drops from 469.11 to 4.23 ns/op when a runtime ID is present. When absent, it drops from 453.39 to 17.43 ns/op (1M iterations x 7 trials, drop best and worst).
|
Superseded, since napi is not being used |
Summary
Deduplicates the native N-API and WASM bindings by building both artifacts
from the shared libdatadog crate. The WASM fallback targets
wasm32-unknown-unknown, uses the napi-rs current-thread async runtime, anddoes not require WASI or worker permissions.
Details
wasm32-unknown-unknown.preserving napi-rs exports.
current-thread task host for async exports.
self-contained entry point with no separate runtime assets.
package as its fallback.
--allow-wasior--allow-worker.target.
Compared with the separate wasm-bindgen implementation on the base commit:
The published package contains no separate runtime or worker files.
Validation
size-report tests on Node 24.
flag test is skipped there.
cargo clippy --package libdatadog --target wasm32-unknown-unknown -- -D warnings.This PR was generated by Codex.