feat(libdatadog): add universal core and optional extras packages by rochdev · Pull Request #207 · DataDog/libdatadog-nodejs

rochdev · 2026-08-24T18:14:04Z

Summary

Introduces the package foundation shared by the rest of the stack:

@datadog/libdatadog is the universal native-first package with an always
available inlined WASM fallback.
@datadog/libdatadog-extras is the renamed existing package for optional
functionality that is not supported in every environment.

The universal artifact combines the existing DDSketch and compression
bindings into one native library and one WASM module. The APM data pipeline is
deliberately excluded here and added by the next PR in the stack.

Details

Generates six napi-rs-compatible platform packages as optional dependencies
of the universal metapackage.
Brotli-compresses and inlines the WASM fallback for bundler and
cross-platform compatibility.
Provides explicit CommonJS and ESM entry points for the selected backend and
the forced-WASM subpath.
Enforces 500 KiB optimized WASM and 200 KiB inlined JavaScript size budgets.
Limits Binaryen to the WebAssembly features used by the Rust output and
supported by Node.js 18; the broader --all-features mode can emit GC
instructions that Node.js 18 cannot parse.
Pins wasm-pack 0.14 in build and release CI to remain compatible with the
repository's Rust 1.90 toolchain.
Builds and publishes the universal package, its platform packages, and the
extras package from the same release workflow.
Runs musl package tests inside Alpine after host-side artifact downloads.
Keeps library_config in extras; its Rust changes are limited to dependency
cleanup and edits required by Clippy.
Adds package loading, native/WASM parity, ESM, and published-content tests.

The generated packages/libdatadog/package-lock.json accounts for most of the
added lines in this foundation PR.

Validation

Native and WASM Cargo checks, release builds, and Clippy.
17 universal-package integration tests locally.
Full repository test suite locally, including HTTP, pipeline, and crash
tracker coverage.
Full package and published-content tests on Node.js 18 and 24 in CI.
ESLint, actionlint, and package dry-run/content validation.
WASM library_config test.

This PR was generated by Codex.

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

bengl · 2026-08-24T18:23:05Z


    #[wasm_bindgen]
-    pub fn set_envp(&mut self, envp: Box<[JsValue]>) -> Result<(), JsValue> {
+    pub fn set_envp(&mut self, envp: Vec<JsValue>) -> Result<(), JsValue> {


This file seems mostly like stylistic changes, still.

All changes to this file have been reverted.

bengl · 2026-08-24T18:26:47Z

@@ -0,0 +1,37 @@
+'use strict'


This is a test, not a script. Add it to the tests directory.

bengl · 2026-08-24T18:27:52Z

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash


A little weird that this file is bash and clean-native is JS. Try to be consistent here.

Switched to JS.

github-actions · 2026-08-24T18:28:58Z

Overall package size

Self size: 36.97 MB
Deduped: 36.97 MB
No deduping: 36.97 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------|

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

bengl · 2026-08-24T18:30:06Z

@@ -0,0 +1,10 @@
+export function backend(): 'native' | 'wasm'


Is there a test to verify this file?

Test added.

bengl · 2026-08-24T18:30:48Z

@@ -0,0 +1,66 @@
+{
+  "name": "@datadog/libdatadog",
+  "version": "0.1.0-pre",


Note that we already have this package published, so this number may need to be bumped.

This is already done in release PRs.

bengl · 2026-08-24T18:33:15Z

@@ -1,7 +1,7 @@
 {
-  "name": "@datadog/libdatadog",
+  "name": "@datadog/libdatadog-extras",


Add a TODO somewhere to restructure this whole package Russian doll situation.

Done, although it's in a bit of a random place because JSON don't have TODOs.

rochdev · 2026-08-25T01:59:02Z

@bengl All your concerns should have been addressed. I also improved the packaging and cross-platform testing.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2b5753847

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

* feat(libdatadog): add universal core and optional extras packages * refactor: restructure libdatadog packages * test: tighten wasm size budgets * ci(libdatadog): fix cross-platform builds and tests * fix(libdatadog): address package compatibility issues

The release workflow publishes under npm OIDC trusted publishing, which turns on provenance, and sigstore refuses the upload unless the manifest records the source repository. Both packages carved out of the root in #207 lacked the field, so publishing 0.19.0 failed with: npm error code E422 npm error 422 Unprocessable Entity - PUT .../@DataDog%2flibdatadog-wasm - Error verifying sigstore provenance bundle: Failed to validate repository information: package.json: "repository.url" is "", expected to match "https://github.com/DataDog/libdatadog-nodejs" Add repository, homepage, and bugs to both manifests, matching the root package, and assert in package.test.js that all three carry the same repository URL. Only a real publish exercises the sigstore check, so without the assertion the next carve-out can regress it just as quietly.

The release workflow publishes under npm OIDC trusted publishing, which turns on provenance, and sigstore refuses the upload unless the manifest records the source repository. Both packages carved out of the root in #207 lacked the field, so publishing 0.19.0 failed with: npm error code E422 npm error 422 Unprocessable Entity - PUT .../@DataDog%2flibdatadog-wasm - Error verifying sigstore provenance bundle: Failed to validate repository information: package.json: "repository.url" is "", expected to match "https://github.com/DataDog/libdatadog-nodejs" Add repository, homepage, and bugs to both manifests, matching the root package, and assert in package.test.js that all three carry the same repository URL. Only a real publish exercises the sigstore check, so without the assertion the next carve-out can regress it just as quietly. (cherry picked from commit 146cd7c)

rochdev mentioned this pull request Aug 24, 2026

feat(libdatadog): add apm data pipeline #205

Merged

rochdev force-pushed the rochdev/libdatadog-core branch from c77f5ff to d12e121 Compare August 24, 2026 18:19

bengl reviewed Aug 24, 2026

View reviewed changes

rochdev force-pushed the rochdev/libdatadog-core branch from d12e121 to c0fa67d Compare August 24, 2026 18:29

bengl reviewed Aug 24, 2026

View reviewed changes

rochdev force-pushed the rochdev/libdatadog-core branch 3 times, most recently from a9fb52c to e2b5753 Compare August 25, 2026 00:30

rochdev marked this pull request as ready for review August 25, 2026 01:57

rochdev requested review from a team as code owners August 25, 2026 01:57

chatgpt-codex-connector Bot reviewed Aug 25, 2026

View reviewed changes

Comment thread .github/workflows/release.yml Outdated

Comment thread scripts/build-wasm.js Outdated

Comment thread packages/libdatadog/index.js

Comment thread packages/libdatadog/index.d.ts

bengl previously approved these changes Aug 25, 2026

View reviewed changes

rochdev added 5 commits August 26, 2026 01:01

feat(libdatadog): add universal core and optional extras packages

bf9ca11

refactor: restructure libdatadog packages

069fd3a

test: tighten wasm size budgets

07c454d

ci(libdatadog): fix cross-platform builds and tests

245afa2

fix(libdatadog): address package compatibility issues

01ad475

rochdev dismissed bengl’s stale review via 01ad475 August 26, 2026 05:16

rochdev force-pushed the rochdev/libdatadog-core branch from bb617cd to 01ad475 Compare August 26, 2026 05:16

bengl approved these changes Aug 27, 2026

View reviewed changes

rochdev merged commit b858f08 into main Aug 27, 2026
70 checks passed

rochdev deleted the rochdev/libdatadog-core branch August 27, 2026 17:41

bengl mentioned this pull request Aug 31, 2026

v0.19.0 #226

Merged

bengl mentioned this pull request Aug 31, 2026

fix(libdatadog): add repository metadata for npm provenance #227

Merged

bengl mentioned this pull request Aug 31, 2026

fix(libdatadog): add repository metadata for npm provenance #228

Merged

		@@ -0,0 +1,10 @@
		export function backend(): 'native' \| 'wasm'

Conversation

rochdev commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Validation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rochdev commented Aug 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rochdev commented Aug 24, 2026 •

edited

Loading

github-actions Bot commented Aug 24, 2026 •

edited

Loading