Reuse buffer in Apache Common serialization #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid allocating a new String on each log line by reusing a Vec<u8> buffer. This eliminates format! overhead in the hot loop. **Micro-benchmark** (cargo criterion): - 1 MB: 84 → 95 MiB/s (+13%) - 10 MB: 137 → 171 MiB/s (+25%) - 100 MB: 134 → 167 MiB/s (+25%) - 1 GB: 134 → 171 MiB/s (+28%) **Macro-benchmark** (hyperfine with payloadtool): - +17% faster (4.00s → 3.41s mean) Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
GeorgeHahn
approved these changes
Jan 12, 2026
blt
added a commit
that referenced
this pull request
Jan 15, 2026
Refactor skills to reduce token usage while preserving functionality: - Extract shared BENCHMARKING.md and DB_SCHEMA.md references - Remove duplicated bash blocks (worktree, criterion, hyperfine) - Convert verbose tutorials to concise checklists - Trust LLM knowledge of bash/Rust basics Based on analysis of merged PRs, establishes a standard commit format: - Title: Action verb + target + technique (no prefixes) - Body: Brief explanation + benchmark results - ONE commit per optimization (includes db.yaml update) Examples from merged PRs analyzed: - Reuse buffer in Apache Common serialization (#1690) - Eliminate allocations in Splunk HEC serialization (#1694) - Use handle-based tag storage in DogStatsD (#1691) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid allocating a new String on each log line by reusing a Vec buffer. This eliminates format! overhead in the hot loop.
Micro-benchmark (cargo criterion):
Macro-benchmark (hyperfine with payloadtool):