Jamie/auto brokers #251
Merged
Jamie/auto brokers #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
--brokersflag to accept the special identifier-1which automatically expands to an ID list of all mapped brokers.Example: If
topic1were running on broker set1001,1002,1003and we wanted to perform a rebalance, we might run the commandtopicmappr rebalance --topics topic1 --brokers 1001,1002,1003. This requires users to look up which brokers held partitions fortopic1. Specifying-1will automatically expand to1001,1002,1003without a user having to find this information:topicmappr rebalance --topics topic1 --brokers -1would result in the exact same output.Additionally, this expansion is an in-place substitution only for the special identifier. This allows additional, unmapped brokers to be included. If we were to scale
topic1using the original brokers along with the additional brokers1004,1005, we could use the following command:topicmappr rebalance --topics topic1 --brokers -1,1004,1005.Closes #163