Fix Message.equals #194
Merged
Fix Message.equals #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed excessive CPU usage in HashMap lookups in StatsDAggregator. The stacks shows that the HashMap had devolved into a TreeMap which happens after frequent hash collisions. That got me looking at the implementations of hashCode/equals in the Message hierarchy.
retronym
force-pushed
the
topic/string-equals
branch
from
13ed366
to
0485d49
Compare
|
These are the only two instances of |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed excessive CPU usage in HashMap lookups in StatsDAggregator.
The stacks shows that the HashMap had devolved into a TreeMap which
happens after frequent hash collisions. That got me looking at the
implementations of hashCode/equals in the Message heirarchy and
this seems a likely culprit.