Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bind9 to use requests wrapper #885

Merged
merged 1 commit into from
May 24, 2021
Merged

Update bind9 to use requests wrapper #885

merged 1 commit into from
May 24, 2021

Conversation

npezzotti
Copy link
Contributor

@npezzotti npezzotti commented May 21, 2021 •
edited
Loading

What does this PR do?

  • Updates bind9 to use requests wrapper
  • Removes requests import

Motivation

  • Standardize http requests

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@hithwen hithwen merged commit 369a91f into master May 24, 2021
@hithwen hithwen deleted the nathan/bind9-requests-wrapper branch May 24, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

@luisgonzalex luisgonzalex luisgonzalex approved these changes

Assignees
No one assigned
Labels
changelog/Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npezzotti @hithwen @luisgonzalex