Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install instructions #792

Merged
merged 24 commits into from
Jan 15, 2021
Merged

Update install instructions #792

merged 24 commits into from
Jan 15, 2021

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Jan 12, 2021

Update install instructions to use the integration install command instead of building the wheel

arapulido
arapulido reviewed Jan 12, 2021
View reviewed changes
cert_manager/README.md Outdated Show resolved Hide resolved
platinummonkey
platinummonkey approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@platinummonkey platinummonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for storm + upsc

@hithwen hithwen requested a review from a team January 12, 2021 15:34
@hithwen hithwen force-pushed the julia/AI-1286-update-install-instructions branch from cfed89c to 2250f22 Compare January 12, 2021 15:42
cswatt
cswatt reviewed Jan 12, 2021
View reviewed changes
cyral/README.md Outdated Show resolved Hide resolved
cswatt
cswatt reviewed Jan 12, 2021
View reviewed changes
flume/README.md Outdated Show resolved Hide resolved
cswatt
cswatt reviewed Jan 12, 2021
View reviewed changes
kernelcare/README.md Outdated Show resolved Hide resolved
cswatt
cswatt reviewed Jan 12, 2021
View reviewed changes
nextcloud/README.md Outdated Show resolved Hide resolved
@hithwen hithwen force-pushed the julia/AI-1286-update-install-instructions branch from e0d8b2e to fc1d32c Compare January 12, 2021 15:48
@hithwen hithwen force-pushed the julia/AI-1286-update-install-instructions branch from fc1d32c to b12ac26 Compare January 12, 2021 15:49
hithwen
hithwen commented Jan 12, 2021
View reviewed changes
kernelcare/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 12, 2021
View reviewed changes
php_apcu/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 12, 2021
View reviewed changes
pihole/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 12, 2021
View reviewed changes
puma/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 12, 2021
View reviewed changes
snmpwalk/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 13, 2021
View reviewed changes
ping/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 13, 2021
View reviewed changes
reboot_required/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 13, 2021
View reviewed changes
sortdb/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 13, 2021
View reviewed changes
sortdb/README.md Outdated Show resolved Hide resolved
l0k0ms
l0k0ms reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to reduce friction i have inlined the integration name in the integration install command, do you think we should also inline the latest version of the integration ?

aqua/README.md Outdated Show resolved Hide resolved
bind9/README.md Outdated Show resolved Hide resolved
cyral/README.md Outdated Show resolved Hide resolved
eventstore/README.md Outdated Show resolved Hide resolved
filebeat/README.md Outdated Show resolved Hide resolved
traefik/README.md Outdated Show resolved Hide resolved
unbound/README.md Outdated Show resolved Hide resolved
upsc/README.md Outdated Show resolved Hide resolved
vespa/README.md Outdated Show resolved Hide resolved
zabbix/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
storm/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
storm/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
traefik/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
traefik/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
traefik/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
vespa/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
vespa/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
vespa/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
vespa/README.md Outdated Show resolved Hide resolved
hithwen
hithwen commented Jan 15, 2021
View reviewed changes
vespa/README.md Outdated Show resolved Hide resolved
hithwen and others added 2 commits January 15, 2021 13:13
@hithwen
Fix zabbix links
ca12afd
@hithwen
Apply suggestions from code review
259cb69 
Co-authored-by: Pierre Guceski <pierre.guceski@datadoghq.com>
@hithwen
Copy link
Contributor Author

hithwen commented Jan 15, 2021

In order to reduce friction i have inlined the integration name in the integration install command, do you think we should also inline the latest version of the integration ?

No, cause that's going to get outdated

@hithwen hithwen merged commit e0f0566 into master Jan 15, 2021
@hithwen hithwen deleted the julia/AI-1286-update-install-instructions branch January 15, 2021 12:30
eliadeini pushed a commit to eliadeini/integrations-extras that referenced this pull request Jun 1, 2021
@hithwen @ChristineTChen @eliadeini
Update install instructions (DataDog#792)
00dca3b 
* Update install instructions

Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com>
Co-authored-by: Pierre Guceski <pierre.guceski@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0k0ms l0k0ms l0k0ms left review comments

@arapulido arapulido arapulido left review comments

@cswatt cswatt cswatt approved these changes

@platinummonkey platinummonkey platinummonkey approved these changes

@eplanet eplanet Awaiting requested review from eplanet

@ericmustin ericmustin Awaiting requested review from ericmustin

@jstanton617 jstanton617 Awaiting requested review from jstanton617 jstanton617 is a code owner

@KealanMaas KealanMaas Awaiting requested review from KealanMaas KealanMaas is a code owner

@monganai monganai Awaiting requested review from monganai monganai is a code owner

@ChristineTChen ChristineTChen Awaiting requested review from ChristineTChen

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hithwen @platinummonkey @arapulido @cswatt @l0k0ms @ChristineTChen