Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds lacework tile for lacework integration #505

Merged
merged 19 commits into from
Jan 17, 2020
Merged

Conversation

anshumgargdd
Copy link
Contributor

What does this PR do?

This PR adds basic scaffolding and tile for Lacework integration

Motivation

We recently released a Lacework logs integration which needs an in app tile.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@anshumgargdd anshumgargdd requested review from a team as code owners November 27, 2019 20:13
@anshumgargdd anshumgargdd requested review from therve and removed request for a team November 27, 2019 20:13
@hithwen
Copy link
Contributor

hithwen commented Dec 2, 2019

We are currently on a code freeze, let's wait till next week to merge this

@anshumgargdd
Copy link
Contributor Author

@hithwen Can we merge this now?

@hithwen
Copy link
Contributor

hithwen commented Dec 23, 2019

@hithwen Can we merge this now?

Yes, but have you addressed @l0k0ms's feedback?

@anshumgargdd
Copy link
Contributor Author

@hithwen Rebased and Updated readme based on feedback. Free to merge. Thanks!

@anshumgargdd
Copy link
Contributor Author

Hello @hithwen rebumping. Can we merge this?

@l0k0ms l0k0ms changed the base branch from master to aerospike January 13, 2020 08:33
@l0k0ms l0k0ms changed the base branch from aerospike to master January 13, 2020 08:33
lacework/README.md Outdated Show resolved Hide resolved
lacework/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased of master + left some suggestion :)

anshumgargdd and others added 2 commits January 13, 2020 10:39
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
Co-Authored-By: Pierre Guceski <pierre.guceski@datadoghq.com>
@anshumgargdd
Copy link
Contributor Author

@l0k0ms Accepted suggestions. Feel free to merge. Thanks.

@platinummonkey platinummonkey removed their request for review January 13, 2020 15:48
Copy link
Contributor

@l0k0ms l0k0ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G doc wise

@anshumgargdd
Copy link
Contributor Author

@hithwen Good to merge? Thanks!

@hithwen hithwen merged commit e97dc39 into master Jan 17, 2020
@hithwen hithwen deleted the anshum.garg/lacework branch January 17, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants