-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Agora Analytics dashboard to add widgets for chat metrics #2508
Update Agora Analytics dashboard to add widgets for chat metrics #2508
Conversation
72bb886
to
c001ad1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR. I've requested changes. Please let me know if you have questions
agora_analytics/assets/dashboards/agora_analytics_overview.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
Co-authored-by: Erica Ho <109224841+eho1307@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left you a suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some edits for the metrics :)
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
@Kevenxia We'll merge this PR. Once you see the PR close, it may take an hour or two to see the updates live. |
What does this PR do?
This pull request introduces a significant update to our Agora Analytics integration.
It revamps the existing dashboard by consolidating all previous indicators into a new "Group RTC", and adding a new group for Chat, which includes 13 additional indicators.
Consequently, the dashboard will feature two groups: RTC and Chat.
(After discussed with Daniel Maguire and our products, we choose to update the old dashboard, instead of adding a new dashboard. So we abandoned the last pr.)
Motivation
What inspired you to submit this pull request?
Some customers expressed their requirements to integrate their data of Agora Chat to DataDog.
Review checklist
PR has a meaningful title or PR has the no-changelog label attached
Feature or bugfix has tests
Git history is clean
If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
If this PR includes a log pipeline, please add a description describing the remappers and processors.
Additional Notes
Anything else we should know when reviewing?