Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log instruction on traefik integration #249

Merged
merged 6 commits into from
Jan 7, 2019
Merged

Add log instruction on traefik integration #249

merged 6 commits into from
Jan 7, 2019

Conversation

NBParis
Copy link

@NBParis NBParis commented Dec 18, 2018

What does this PR do?

Add log collection instruction for traefik integration

Motivation

Traefik was recently added as a log integration.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@NBParis NBParis requested a review from a team as a code owner December 18, 2018 12:48
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NBParis

traefik/README.md Show resolved Hide resolved
@NBParis
Copy link
Author

NBParis commented Dec 26, 2018

@jeremy-lq made a quick change as the copy paste was still referencing Aerospike. Should be good now.

Thanks you both for your reviews.

@masci masci requested a review from a team as a code owner January 7, 2019 16:55
@masci masci dismissed jeremy-lq’s stale review January 7, 2019 17:04

feedback was incorporated, going to merge

@masci masci merged commit 9e7b2f1 into master Jan 7, 2019
@masci masci deleted the nils/traefik branch January 7, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants