Add check for Riak replication (riak-repl) metrics #212
Conversation
|
I'm unsure if the checkboxes in the PR detail are for me or the reviewer(s) so I've left them unchecked. |
abtreece
force-pushed
the
add-riak-repl-integration
branch
from
7fe3b87 to
99dc5ba
Compare
|
👋 Hello! Thanks for the PR! One quick question before we go any further (and please forgive me if it's obvious - I'm not a Riak expert): why should this be a separate Integration? In other words, would it make sense to integrate this code / functionality into the core Riak Integration? |
|
Hey @phrawzty... the riak check in integration-core pulls stats from ../stats whereas this integration pulls from ../riak-repl/stats. The stats are provided by different Erlang "actors" and thus operate a bit independently. I suppose they could be combined, but I believe keeping them separate follows with the Erlang model and will allow for independent feature/fix contributions based on the advancements of those separate codebases. |
abtreece
force-pushed
the
add-riak-repl-integration
branch
from
931c0f9 to
de692fc
Compare
abtreece
force-pushed
the
add-riak-repl-integration
branch
from
840e497 to
08a23ff
Compare
|
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed if no further activity occurs in the next two weeks. Thank you for participating in the Datadog open source community. If you need more time, or have any questions, let us know. |
|
Hey @masci is there anything I can do at this point to help move this along? I'm getting ready to work on a new feature for it and don't want to muddy this PR. |
Only implements a subset of available metrics at this point.
These checks will pull out the connected cluster and gather metrics reported for each. The tests require starting two clusters via docker and configuring replication between them. Additionally fixed a couple issues with the README and removing unnecessary files.
abtreece
force-pushed
the
add-riak-repl-integration
branch
from
16fbb7f to
4cf4b33
Compare
|
@abtreece Hello there! Can you please fix the 2 validations in CI? Here are the valid unit names currently: https://github.com/DataDog/integrations-core/blob/a676e7b2f46e3ceb48c1d00d0abad7aa16d9a922/datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/metadata.py#L48-L184 |
|
Hi @abtreece! In order to thank you for both your contribution and your patience, I'd be happy to send you a t-shirt and some stickers. 😄 If you're interested, please shoot me an email with your postal mail details: |
What does this PR do?
Adds a custom check for Riak replication (riak-repl) starting with a subset of the available metrics
Motivation
Replication has been included in the open source version of Riak. The node and cluster metrics are currently available in core but there is no visibility for riak-repl.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?