-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenMetricsV2] Improve label sharing behavior #9804
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs review
...dog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/openmetrics.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for docs
What does this PR do?
share_labels
to v1label_joins
i.e. cache previous payloadscache_shared_labels
to prevent inconsistences at the risk of potentially increased memory usageMotivation
Potential inconsistences are preferred over dependence on the order in which metrics are exposed in a payload