Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate all integrations for base and dev updates #9787

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Validate all integrations for base and dev updates #9787

merged 1 commit into from
Jul 28, 2021

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Jul 28, 2021 •
edited
Loading

What does this PR do?

Changing datadog_checks_dev or datadog_checks_base can affect other integration, like config spec.
This PR updates the changed behaviour for some validation command, to validate every check when datadog_checks_base or datadog_checks_dev is changed.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner July 28, 2021 07:54
@codecov
Copy link

codecov bot commented Jul 28, 2021 •
edited
Loading

Codecov Report

Merging #9787 (0b07d19) into master (b43d9a9) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ofek
ofek approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's improve the PR title

@coignetp coignetp changed the title Extend dev validation Validate all integrations for base and dev updates Jul 28, 2021
@ofek ofek merged commit 8e3cbf6 into master Jul 28, 2021
@ofek ofek deleted the paul/extend-dev-validation branch July 28, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coignetp @hithwen @ofek