Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove documentation specifications #9763

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Remove documentation specifications #9763

merged 1 commit into from
Jul 26, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jul 23, 2021

What does this PR do?

Finish removal that was started in #9160

Reverted:

Motivation

We decided not to proceed with this

@ofek ofek requested review from a team as code owners July 23, 2021 21:05
@codecov
Copy link

codecov bot commented Jul 23, 2021 •
edited
Loading

Codecov Report

Merging #9763 (ee339f7) into master (5b90b65) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Flag Coverage Δ
datadog_checks_dev 79.93% <100.00%> (+1.77%) ⬆️
rethinkdb 97.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek force-pushed the ofek/doc-specs branch from cb968d6 to ee339f7 Compare July 26, 2021 15:29
kayayarai
kayayarai reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i think?

@ofek ofek merged commit 09e6cc4 into master Jul 26, 2021
@ofek ofek deleted the ofek/doc-specs branch July 26, 2021 17:40
github-actions bot pushed a commit that referenced this pull request Jul 26, 2021
@ofek
Remove documentation specifications (#9763) 09e6cc4
06ae8f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@kayayarai kayayarai kayayarai approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/datadog_checks_dev integration/rethinkdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @kayayarai @ChristineTChen