Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update container identifier #9512

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Update container identifier #9512

merged 1 commit into from
Jun 14, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Cilium container updated https://hub.docker.com/r/cilium/cilium

Motivation

Fix autodiscovery

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners June 14, 2021 19:43
@codecov
Copy link

codecov bot commented Jun 14, 2021 •
edited
Loading

Codecov Report

Merging #9512 (6b8226d) into master (0b3de8a) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
cilium 85.84% <ø> (+1.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ChristineTChen ChristineTChen merged commit 09f0348 into master Jun 14, 2021
@ChristineTChen ChristineTChen deleted the cc/cilium-identifier branch June 14, 2021 21:17
ahmed-mez
ahmed-mez reviewed Jun 15, 2021
View reviewed changes
cilium/datadog_checks/cilium/data/auto_conf.yaml
- cilium-agent
- cilium
Copy link
Contributor

@ahmed-mez ahmed-mez Jun 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ChristineTChen
I think we can keep both of them, otherwise it would be a breaking change for customers who will continue to use cilium-agent (ad_identifiers is a list).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, i'll add it back in another PR

@ChristineTChen ChristineTChen mentioned this pull request Jun 15, 2021
Merged
4 tasks
alexandre-normand pushed a commit that referenced this pull request Jun 24, 2021
@ChristineTChen @alexandre-normand
Update container identifier (#9512)
2468bf7
@FlorianVeaux FlorianVeaux mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmed-mez ahmed-mez ahmed-mez left review comments

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
documentation integration/cilium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @ofek @ahmed-mez