Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration log checking #9118

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Fix integration log checking #9118

merged 1 commit into from
Apr 7, 2021

Conversation

luisgonzalex
Copy link
Contributor

What does this PR do?

Two ways we decide whether an intg. has log support

  1. It has a logs section in the config
  2. It has a logs section in the readme

Checking the readme was looking for "# Log collection", but we don't seem to be consistent on the casing. It seems like # Log collection is the most popular.

We can either accept it and use this PR or I can make the change for all intgs. to use the correct casing. WDYT?

➜ git grep "# Log Collection"
aspdotnet/README.md:#### Log Collection
cassandra/README.md:##### Log Collection
cilium/README.md:##### Log Collection
clickhouse/README.md:##### Log Collection
datadog_checks_dev/datadog_checks/dev/tooling/templates/integration/logs/{check_name}/README.md:### Log Collection
ecs_fargate/README.md:### Log Collection
fluentd/README.md:##### Log Collection
harbor/README.md:##### Log Collection
mcache/README.md:#### Log Collection
proxysql/README.md:##### Log Collection
sidekiq/README.md:### Log Collection
vault/README.md:#### Log Collection
vertica/README.md:#### Log Collection
voltdb/README.md:#### Log Collection
➜ git grep "# Log collection"
kafka/README.md:##### Log collection
kafka/README.md:##### Log collection
kafka_consumer/README.md:##### Log collection
kong/README.md:##### Log collection
kong/README.md:##### Log collection
kube_scheduler/README.md:#### Log collection
kyototycoon/README.md:##### Log collection
lighttpd/README.md:#### Log collection
linkerd/README.md:##### Log collection
mapr/README.md:#### Log collection
mapreduce/README.md:##### Log collection
marathon/README.md:##### Log collection
marathon/README.md:##### Log collection
.... and much more

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

Copy link
Member

@mgarabed mgarabed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a uniform README standard, this seems like the correct approach.

@luisgonzalex luisgonzalex merged commit fe8fe25 into master Apr 7, 2021
@luisgonzalex luisgonzalex deleted the lg/catalog_tool_logs branch April 7, 2021 20:49
github-actions bot pushed a commit that referenced this pull request Apr 7, 2021
luisgonzalex added a commit that referenced this pull request Apr 8, 2021
luisgonzalex added a commit that referenced this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants