Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore secondary dashboards #9037

Merged
merged 1 commit into from
Mar 26, 2021
Merged

Ignore secondary dashboards #9037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ignore secondary dashboards
  • Loading branch information
@hithwen
hithwen committed Mar 26, 2021
commit 10bff5a1aee100c85cfb9d0dec75a12ab312fc90
6 changes: 5 additions & 1 deletion datadog_checks_dev/datadog_checks/dev/tooling/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
'hdfs_namenode',
'mesos',
)
SECONDARY_DASHBOARDS = (
'cassandra_nodetool', # included in cassandra
'kafka_consumer', # included in kafka
)

# List of integrations where is not possible or it does not make sense to have its own log integration
INTEGRATION_LOGS_NOT_POSSIBLE = (
Expand Down Expand Up @@ -614,7 +618,7 @@ def is_jmx_integration(check_name):


def has_dashboard(check):
if check in DOGWEB_JSON_DASHBOARDS:
if check in DOGWEB_JSON_DASHBOARDS or check in SECONDARY_DASHBOARDS:
return True
dashboards_path = os.path.join(get_assets_directory(check), 'dashboards')
return os.path.isdir(dashboards_path) and len(os.listdir(dashboards_path)) > 0
Expand Down