Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include new and legacy openmetrics template in http validation #9034

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Include new and legacy openmetrics template in http validation #9034

merged 2 commits into from
Mar 25, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

New openmetrics config template is also a valid http config support

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested a review from a team as a code owner March 25, 2021 15:41
luisgonzalex
luisgonzalex previously approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@luisgonzalex luisgonzalex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (add a changelog label)

@ChristineTChen ChristineTChen merged commit 5c2ac56 into master Mar 25, 2021
@ChristineTChen ChristineTChen deleted the cc/fix-http-validator branch March 25, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisgonzalex luisgonzalex luisgonzalex approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @ofek @luisgonzalex