Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor has_logs utility #8123

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Refactor has_logs utility #8123

merged 1 commit into from
Dec 11, 2020

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Dec 3, 2020

Flink was not correctly identified as having logs

@hithwen hithwen requested review from a team as code owners December 3, 2020 12:12
@hithwen hithwen force-pushed the julia/refine_has_logs branch from da55c77 to e60cc2b Compare December 3, 2020 12:15
@codecov
Copy link

codecov bot commented Dec 3, 2020 •
edited
Loading

Codecov Report

Merging #8123 (e60cc2b) into master (46532e4) will decrease coverage by 7.59%.
The diff coverage is n/a.

Impacted Files Coverage Δ
php_fpm/datadog_checks/php_fpm/php_fpm.py
directory/datadog_checks/directory/__about__.py
nagios/tests/common.py
hdfs_datanode/tests/conftest.py
consul/datadog_checks/consul/metrics.py
dotnetclr/datadog_checks/dotnetclr/__init__.py
cockroachdb/datadog_checks/cockroachdb/metrics.py
tomcat/tests/test_check.py
go_expvar/datadog_checks/go_expvar/__about__.py
disk/tests/test_unit.py
... and 759 more

florimondmanca
florimondmanca approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the docs site locally, can confirm flink now shows as ticked and other integrations weren't affected. 👍

apigirl
apigirl reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs review needed

@hithwen hithwen merged commit 986dfdd into master Dec 11, 2020
@hithwen hithwen deleted the julia/refine_has_logs branch December 11, 2020 09:46
@ChristineTChen ChristineTChen changed the title Refactor has logs Refactor has_logs utility Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apigirl apigirl apigirl left review comments

@yzhan289 yzhan289 yzhan289 approved these changes

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hithwen @florimondmanca @apigirl @yzhan289 @ChristineTChen