Use snmp mibs copy while mibs.snmplabs.com is down #7835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
|
gmarabout
previously approved these changes
Nov 24, 2020
| reader = HttpReader('mibs.snmplabs.com', 80, '/asn1/@mib@') | ||
| # As mibs.snmplabs.com is down, use a copy | ||
| # https://github.com/etingof/pysnmp/issues/376 | ||
| reader = HttpReader('raw.githubusercontent.com', 80, '/projx/snmp-mibs/master/@mib@') |
There was a problem hiding this comment.
Can't we have an option to override this value, instead of hardcoded URL? By default that would remain mibs.snmplabs.com but we could override it using:
ddev meta snmp translate-profile --source-url=raw.githubusercontent.com ...
AlexandreYang
previously approved these changes
Nov 25, 2020
pducolin
dismissed stale reviews from AlexandreYang and gmarabout
via
3697666
pducolin
force-pushed
the
pducolin/snmplabs-com-is-down
branch
from
3697666 to
6bf7496
Compare
pducolin
force-pushed
the
pducolin/snmplabs-com-is-down
branch
from
6bf7496 to
d870352
Compare
pducolin
force-pushed
the
pducolin/snmplabs-com-is-down
branch
from
d870352 to
90ad3cf
Compare
gmarabout
approved these changes
Nov 27, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2020
* use snmp mibs copy while mibs.snmplabs.com is down * add option to set custom MIB source in ddev translate profile d4c6575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mibs.snmplabs.com has been down since late August, as reported in etingof/pysnmp#376. In the meantime a copy has been provided at https://github.com/projx/snmp-mibs. This PR changes the target mibs source url
We might also create our copy and point to our mibs - not sure there could be security concerns
Motivation
Fix ddev mibs resolution
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached