Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lighttpd logs #7719

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Add lighttpd logs #7719

merged 3 commits into from
Oct 7, 2020

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Oct 5, 2020 •
edited
Loading

What does this PR do?

Add support for lighttpd log integration

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@yzhan289 yzhan289 requested review from a team as code owners October 5, 2020 20:16
@codecov
Copy link

codecov bot commented Oct 5, 2020 •
edited
Loading

Codecov Report

Merging #7719 into master will decrease coverage by 4.94%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
lighttpd/tests/conftest.py 100.00% <100.00%> (ø)
datadog_checks_dev/datadog_checks/dev/jmx.py
disk/datadog_checks/disk/__init__.py
...troller/datadog_checks/openstack_controller/api.py
nagios/tests/conftest.py
tcp_check/datadog_checks/tcp_check/__about__.py
kubelet/tests/test_prometheus.py
datadog_checks_base/tests/test_metadata.py
gunicorn/datadog_checks/gunicorn/gunicorn.py
presto/tests/common.py
... and 848 more

kayayarai
kayayarai previously approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording recommendation. Otherwise, looks good for docs

lighttpd/README.md Show resolved Hide resolved
coignetp
coignetp previously approved these changes Oct 7, 2020
View reviewed changes
lighttpd/tests/conftest.py
@@ -23,7 +23,7 @@ def wait_for_lighttpd():

@pytest.fixture(scope="session")
def dd_environment():
with docker_run(common.COMPOSE_FILE, conditions=[WaitFor(wait_for_lighttpd)]):
with docker_run(common.COMPOSE_FILE, conditions=[WaitFor(wait_for_lighttpd)], mount_logs=True):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@yzhan289 yzhan289 dismissed stale reviews from coignetp and kayayarai via 17d8bc0 October 7, 2020 13:09
@yzhan289 yzhan289 requested review from kayayarai and coignetp October 7, 2020 13:09
@yzhan289 yzhan289 requested review from anshumgargdd and a team as code owners October 7, 2020 13:13
@yzhan289 yzhan289 removed request for a team and anshumgargdd October 7, 2020 14:05
@yzhan289 yzhan289 merged commit 9bd4de9 into master Oct 7, 2020
@yzhan289 yzhan289 deleted the az/lighttpd-logs-doc branch October 7, 2020 14:12
github-actions bot pushed a commit that referenced this pull request Oct 7, 2020
@yzhan289
Add lighttpd logs (#7719)
1d73599 
Updating spec.yaml and README to include log integration information. 9bd4de9
This was referenced Nov 3, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

@kayayarai kayayarai Awaiting requested review from kayayarai

Assignees
No one assigned
Labels
documentation integration/lighttpd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yzhan289 @kayayarai @coignetp