Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kafka-python to 2.0.2 #7718

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Update kafka-python to 2.0.2 #7718

merged 1 commit into from
Oct 6, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 5, 2020

@ofek ofek requested review from trishankatdatadog and a team as code owners October 5, 2020 16:13
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #7718 into master will decrease coverage by 8.52%.
The diff coverage is n/a.

Impacted Files Coverage Δ
redisdb/datadog_checks/redisdb/__init__.py
datadog_checks_dev/tests/tooling/test_constants.py
envoy/tests/test_parser.py
kubernetes_state/tests/test_kubernetes_state.py
disk/tests/utils.py
mcache/datadog_checks/mcache/mcache.py
redisdb/tests/test_default.py
php_fpm/tests/conftest.py
gitlab/datadog_checks/gitlab/__about__.py
cassandra_nodetool/tests/conftest.py
... and 801 more

hithwen
hithwen reviewed Oct 6, 2020
View reviewed changes
datadog_checks_base/datadog_checks/base/data/agent_requirements.in
jaydebeapi==1.2.3
jpype1==0.7.1 ; python_version <= '2.7'
# 0.7.1 version breaks in py3 but is the latest py2 compatible version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when someone runs the command this will happen again. since we're pinning version based on the marker, I think it's already explicit that the reason is compatibility. there will definitely be more cases like this. wdyt?

@ofek ofek merged commit 109ab42 into master Oct 6, 2020
@ofek ofek deleted the ofek/uk branch October 6, 2020 16:38
github-actions bot pushed a commit that referenced this pull request Oct 6, 2020
@ofek
Update kafka-python to 2.0.2 (#7718) 109ab42
0de9bd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

@trishankatdatadog trishankatdatadog Awaiting requested review from trishankatdatadog

Assignees
No one assigned
Labels
dependencies integration/datadog_checks_base integration/kafka_consumer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @hithwen