Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip auto-setting Python version suffix if using an RC build #7653

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

florimondmanca
Copy link
Contributor

@florimondmanca florimondmanca commented Sep 24, 2020

What does this PR do?

Skip adding the -py2 or -py3 suffix if we're using an RC Agent build, such as datadog/agent:7.23.0-rc.2.

Motivation

RC builds aren't published with a -py2 or -py3 suffix, and I got tired of commenting out this auto-set code when doing QA. :-)

Additional Notes

Might need an additional tweak and thinking, because even public tags don't have -py2 or -py3 suffixes either, but only internal dev versions such as datadog/agent-dev:master-py3. But for now I'm just scratching my own itch!

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca requested a review from a team as a code owner September 24, 2020 09:06
@florimondmanca florimondmanca changed the title Skip python version autoset if using an RC build Skip auto-setting Python version suffix if using an RC build Sep 24, 2020
@florimondmanca florimondmanca merged commit 41960aa into master Dec 2, 2020
@florimondmanca florimondmanca deleted the fm/env-auto-py-rc branch December 2, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants