Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix init_config/db config spec template #7583

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Fix init_config/db config spec template #7583

merged 1 commit into from
Sep 15, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Sep 15, 2020

Motivation

There is no standard metric_prefix option, only in older custom query logic (deprecated)

@ofek ofek requested a review from a team as a code owner September 15, 2020 16:03
@codecov
Copy link

codecov bot commented Sep 15, 2020 •
edited
Loading

Codecov Report

Merging #7583 into master will decrease coverage by 6.90%.
The diff coverage is n/a.

Impacted Files Coverage Δ
mapr/tests/common.py
aerospike/tests/common.py
...e_metrics_server/tests/test_kube_metrics_server.py
...server/datadog_checks/exchange_server/__about__.py
mapr/tests/test_unit.py
consul/tests/test_integration.py
mesos_slave/tests/utils.py
disk/datadog_checks/disk/__init__.py
ibm_mq/tests/test_ibm_mq_unit.py
airflow/tests/test_integration_e2e.py
... and 895 more

coignetp
coignetp approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ if the CI is green

@ofek ofek merged commit 479d3af into master Sep 15, 2020
@ofek ofek deleted the ofek-patch-1 branch September 15, 2020 16:58
This was referenced Feb 7, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

@mgarabed mgarabed mgarabed approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @mgarabed @coignetp