Skip to content

Allow codeowner validation to fail on CI #7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Allow codeowner validation to fail on CI #7207

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d1a54e
Fail if no codeowner
sarah-witt Jul 24, 2020
6e489e3
Add import
sarah-witt Jul 24, 2020
0e419a0
Format import
sarah-witt Jul 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/codeowners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import click

from ...utils import get_codeowners, get_valid_integrations
from ..console import CONTEXT_SETTINGS, echo_failure, echo_success
from ..console import CONTEXT_SETTINGS, abort, echo_failure, echo_success

DIRECTORY_REGEX = re.compile(r"\/(.*)\/$")

Expand Down Expand Up @@ -72,3 +72,5 @@ def codeowners():

if not has_failed:
echo_success("All integrations have valid codeowners.")
else:
abort()