Add new_gc_metrics to all jmx integrations #7073
Merged
+102
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
hithwen
force-pushed
the
julia/AI-852-document-new_gc_metrics
branch
from
2b8beeb to
312488a
Compare
AlexandreYang
approved these changes
Jul 7, 2020
mgarabed
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JMXfetch reads a flag named
new_gc_metricsininit_configthat makes it produce different GC metrics. But it's not documented it in integrations.New metrics are documented in
java/metadata.csvAgent changelog notice: https://github.com/DataDog/datadog-agent/blob/afb595fa7567e5c006ab84ee03a33aaf49d8567b/CHANGELOG.rst#upgrade-notes-10
Usage example: https://github.com/DataDog/datadog-agent/blob/41be52cc63a629f7a18e94fc6e36733e0ff967dd/cmd/agent/dist/conf.d/jmx.d/conf.yaml.example#L11