-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully skip quantile-less summary metrics #6909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristineTChen
previously approved these changes
Jun 16, 2020
Codecov Report
|
mgarabed
previously approved these changes
Jun 16, 2020
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
ofek
previously approved these changes
Jun 16, 2020
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
florimondmanca
dismissed stale reviews from ofek, mgarabed, and ChristineTChen
via
June 17, 2020 07:25
c402df8
AlexandreYang
approved these changes
Jun 17, 2020
4 tasks
github-actions bot
pushed a commit
to bksteiny/integrations-core
that referenced
this pull request
Jun 17, 2020
* Gracefully skip quantile-less summary metrics * Address feedback c917b8c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle summary metrics that don't have a
quantile
by skipping them to prevent crashing.Motivation
In a customer's setup, a system is submitting summary metrics without a quantile, eg:
Currently this makes the check crash with a
KeyError
, meaning that the rest of metrics is not submitted which is a major pain point.Additional Notes
We can look at how what to do with quantile-less metrics later.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached