Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dashboard fields in export #6787

Merged
merged 13 commits into from
Jun 9, 2020
Merged

Remove unused dashboard fields in export #6787

merged 13 commits into from
Jun 9, 2020

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Jun 1, 2020 •
edited by ChristineTChen
Loading

What does this PR do?

  • Remove fields not needed from dashboard payload.
  • Fields such as "id" and "new-id" are confusing and not necessary
  • Tested by syncing a dashboard with the fields removed
  • Removed created_by as the Created by Datadog field is generated by author_info

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jun 2, 2020 •
edited
Loading

Codecov Report

Merging #6787 into master will not change coverage.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
datadog_checks_dev/datadog_checks/dev/__about__.py 100.00% <100.00%> (ø)

@sarah-witt sarah-witt marked this pull request as ready for review June 4, 2020 19:14
@sarah-witt sarah-witt requested a review from a team as a code owner June 4, 2020 19:14
@sarah-witt sarah-witt mentioned this pull request Jun 5, 2020
Merged
4 tasks
@sarah-witt sarah-witt requested a review from ChristineTChen June 9, 2020 20:39
nmuesch
nmuesch approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🥇

@sarah-witt sarah-witt merged commit 2e59642 into master Jun 9, 2020
@sarah-witt sarah-witt deleted the sarah/remove-dash-fields branch June 9, 2020 21:12
github-actions bot pushed a commit that referenced this pull request Jun 9, 2020
@sarah-witt
Remove unused dashboard fields in export (#6787)
8314d5a 
* Pop unused fields

* Update style

* Update sidekiq test

* Remove more fields

* Remove dash changes

* test

* Remove changes

* Fix whitespace

* Style

* Add fields to remove

* Use required fields

* Add argument for author

* Use updated payload 2e59642
@ChristineTChen ChristineTChen mentioned this pull request Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@nmuesch nmuesch nmuesch approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarah-witt @nmuesch @ChristineTChen @ofek