Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove instance argument from new Check template #6673

Merged
merged 2 commits into from
May 26, 2020
Merged

Remove instance argument from new Check template #6673

merged 2 commits into from
May 26, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented May 18, 2020 •
edited
Loading

What does this PR do?

Remove instance argument from check

Motivation

We should use self.instance instead.

Additional Notes

Newly created integrations works.

  py27: commands succeeded
  py38: commands succeeded
  style: commands succeeded
  congratulations :)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang marked this pull request as ready for review May 26, 2020 10:27
@AlexandreYang AlexandreYang requested a review from a team as a code owner May 26, 2020 10:27
@AlexandreYang AlexandreYang merged commit d1798d5 into master May 26, 2020
@AlexandreYang AlexandreYang deleted the alex/ddev_template branch May 26, 2020 11:04
@ofek ofek changed the title Remove instance argument from check Remove instance argument from new Check template Jun 1, 2020
@mgarabed mgarabed mentioned this pull request Jun 16, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux approved these changes

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandreYang @hithwen @FlorianVeaux @ofek