Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trello release status subcommand #6628

Merged
merged 10 commits into from
May 14, 2020
Merged

Add Trello release status subcommand #6628

merged 10 commits into from
May 14, 2020

Conversation

mgarabed
Copy link
Member

@mgarabed mgarabed commented May 12, 2020 •
edited
Loading

What does this PR do?

Add a subcommand ddev release trello status which queries the Trello release board for statistics of each team.

Example output:

❯ ddev release trello status

Trello Status Report (copied to your clipboard):

Team                           | Total           | In Progress     | Issues Found    | Awaiting Build  | Done
--                             | --              | --              | --              | --              | --
Containers                     | 0               | 0               | 0               | 0               | 0
Container App                  | 0               | 0               | 0               | 0               | 0
Core                           | 0               | 0               | 0               | 0               | 0
Integrations                   | 1               | 0               | 0               | 0               | 0
Logs                           | 0               | 0               | 0               | 0               | 0
Platform                       | 1               | 0               | 0               | 0               | 0
Networks                       | 2               | 2               | 0               | 0               | 0
Processes                      | 0               | 0               | 0               | 0               | 0
Trace                          | 0               | 0               | 0               | 0               | 0
--                             | --              | --              | --              | --              | --
TOTALS                         | 4               | 2               | 0               | 0               | 0

Motivation

In the past, each Agent team would report on QA status daily, but a recent recommended change would have this reported in one status report instead.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@mgarabed mgarabed requested a review from a team as a code owner May 12, 2020 20:19
@codecov
Copy link

codecov bot commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #6628 into master will decrease coverage by 4.66%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_dev/datadog_checks/dev/utils.py 51.24% <0.00%> (-0.29%) ⬇️
...atadog_checks_base/datadog_checks/base/__init__.py
...ctory/datadog_checks/active_directory/__about__.py
datadog_checks_base/tests/test_proxy.py
tokumx/datadog_checks/tokumx/__about__.py
iis/datadog_checks/iis/iis.py
marathon/tests/conftest.py
tls/tests/utils.py
system_swap/tests/common.py
disk/datadog_checks/disk/__init__.py
... and 768 more

sarah-witt
sarah-witt reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

datadog_checks_dev/datadog_checks/dev/tooling/commands/release/testable.py Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/commands/release/status.py Outdated Show resolved Hide resolved
AlexandreYang
AlexandreYang requested changes May 13, 2020
View reviewed changes
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯, very helpful tool!!!

datadog_checks_dev/datadog_checks/dev/tooling/commands/release/status.py Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/commands/release/status.py Outdated Show resolved Hide resolved
sarah-witt
sarah-witt previously approved these changes May 13, 2020
View reviewed changes
ofek
ofek requested changes May 14, 2020
View reviewed changes
datadog_checks_dev/datadog_checks/dev/tooling/trello.py Outdated
import requests

TRELLO_DOCSTRING = """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

datadog_checks_dev/datadog_checks/dev/tooling/commands/release/trello/status.py Outdated
out = '\n'.join(output)

try:
pyperclip.copy(out)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add flag?

ofek
ofek previously approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek
Copy link
Contributor

ofek commented May 14, 2020

integrations-core/datadog_checks_dev/tox.ini

Line 13 in 18eae45

datadog_checks/dev/tooling/commands/release/testable.py

@mgarabed mgarabed merged commit 147f7e4 into master May 14, 2020
@mgarabed mgarabed deleted the mgarabed/trello-counts branch May 14, 2020 19:08
@ofek ofek changed the title Add trello release status subcommand Add Trello release status subcommand May 14, 2020
AlexandreYang pushed a commit that referenced this pull request May 15, 2020
@mgarabed @AlexandreYang
Add trello release status subcommand (#6628)
7196c7f 
* Add count option for trello cards

* Add separate status subcommand

* Fix style

* Add the actual script

* Format docstrings and add totals row

* Refactor scripts under trello subcommand

* Reformat output and copy to clipboard

* Include init

* Cleanup and add clipboard option

* fix tox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang requested changes

@sarah-witt sarah-witt sarah-witt approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgarabed @ofek @sarah-witt @AlexandreYang