Add send_monotonic_with_gauge config option and refactor test #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
ChristineTChen
force-pushed
the
cc/openmetrics-monotonic
branch
from
cf4753f to
9f29cf0
Compare
|
CI failing on new flake8 error codes. PR to fix #6620 |
ChristineTChen
force-pushed
the
cc/openmetrics-monotonic
branch
from
6cac4b8 to
8b21165
Compare
ofek
approved these changes
May 15, 2020
CharlyF
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
send_monotonic_with_gaugeconfig option submits a monotonic_count along with the gauge for Prometheuscountermetrics and histogram/summary metrics (that should be a counter). The monotonic_count metric is differentiated from the gauge metric with an appended.total.This option is hidden by default as it only really applies for legacy behavior.
This PR also refactors tests to de-duplicate code/assertions and use
pytest.parametrizefor testing the various submission type flags that affect histogram/summary count and sum metrics and counter metrics.