Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ceph config spec #6563

Merged
merged 4 commits into from
May 1, 2020
Merged

Add ceph config spec #6563

merged 4 commits into from
May 1, 2020

Conversation

mgarabed
Copy link
Member

@mgarabed mgarabed commented May 1, 2020

No description provided.

@mgarabed mgarabed requested review from a team as code owners May 1, 2020 18:52
@codecov
Copy link

codecov bot commented May 1, 2020 •
edited
Loading

Codecov Report

Merging #6563 into master will increase coverage by 3.16%.
The diff coverage is n/a.

Impacted Files Coverage Δ
envoy/tests/test_metrics.py
datadog_checks_dev/tests/test_subprocess.py
...datadog_checks/base/checks/openmetrics/__init__.py
...s_base/datadog_checks/base/utils/metadata/utils.py
postfix/datadog_checks/postfix/__init__.py
nginx/datadog_checks/nginx/nginx.py
envoy/datadog_checks/envoy/__about__.py
ssh_check/tests/conftest.py
oracle/tests/conftest.py
fluentd/tests/mock/fluentd_version.py
... and 829 more

ChristineTChen
ChristineTChen reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgarabed mgarabed merged commit e615a1b into master May 1, 2020
@mgarabed mgarabed deleted the mgarabed/ceph-spec branch May 1, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
documentation integration/ceph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgarabed @ChristineTChen