Update metadata.csv #6205
Merged
Update metadata.csv #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
requested changes
Apr 1, 2020
FlorianVeaux
force-pushed
the
florian/update_mysql_metadata
branch
from
dd15d91 to
5a3cbfc
Compare
AlexandreYang
requested changes
Apr 22, 2020
FlorianVeaux
force-pushed
the
florian/update_mysql_metadata
branch
from
5a3cbfc to
7682730
Compare
Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com>
Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com>
Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com>
Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com>
Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com>
Codecov Report
|
AlexandreYang
approved these changes
May 14, 2020
AlexandreYang
added a commit
that referenced
this pull request
May 15, 2020
* Update metadata.csv * Fix tests * Assert e2e with metadata * Update mysql/metadata.csv Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com> * Update mysql/metadata.csv Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com> * Update mysql/metadata.csv Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com> * Update mysql/metadata.csv Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com> * Update mysql/metadata.csv Co-Authored-By: Alexandre Yang <alexandre.yang@datadoghq.com> Co-authored-by: Alexandre Yang <alexandre.yang@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
MySQL metadata.csv is really outdated.
I've tried to add as many metrics as possible, I wasn't able to find any documentation at all for some metrics so I didn't add them.
Some others, the documentation I found is quite sparse (all the descriptions that look like
As shown in the <NAME> section of the <QUERY>), should they be documented? Can't find better docs at the moment and this is a very long work.Motivation