Fix e2e test #6167
Merged
Fix e2e test #6167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hithwen
force-pushed
the
julia/fix-activemq
branch
from
bbf8444 to
c417dd2
Compare
hithwen
force-pushed
the
julia/fix-activemq
branch
from
c417dd2 to
5928181
Compare
Codecov Report
|
AlexandreYang
approved these changes
Mar 27, 2020
| @@ -40,12 +40,12 @@ instances: | |||
| ## @param host - string - required | |||
| ## JMX hostname to connect to. | |||
| # | |||
| - host: <HOST> | |||
| - host: localhost | |||
There was a problem hiding this comment.
Actually, we don't need to override this anymore don't we? host and port are overriden in conftest.
The placeholder are our usual way to proceed for required parameters, any reason to change them?
There was a problem hiding this comment.
Actually, we don't need to override this anymore don't we?
Overriding in the test makes the test more independent to the sample config.
The placeholder are our usual way to proceed for required parameters, any reason to change them?
The sample files had these values before applying specs. I'm happy to revert this override but I thought is probably useful to keep these default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e test was relying on the sample configuration default values that were changed to a placeholder when introducing specs here https://github.com/DataDog/integrations-core/pull/6115/files
This PR: