Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Agent 6+ signature in check integration test #5718

Merged

Conversation

florimondmanca
Copy link
Contributor

@florimondmanca florimondmanca commented Feb 12, 2020

What does this PR do?

The check template was generating a test using the legacy MyCheck(name, init_config, agentConfig) signature (A5). Or maybe this was a typo. In any case, this PR updates the test template to use the proper A6/A7 signature.

Motivation

Encourage usage of up-to-date signature for new integrations.

Additional Notes

Discovered while working on #5715. Refs #5573.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@florimondmanca florimondmanca requested a review from a team as a code owner February 12, 2020 14:20
@florimondmanca florimondmanca changed the title Fix usage of legacy signature in check integration test Switch to Agent 6+ signature in check integration test Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #5718 into master will decrease coverage by 3.82%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_dev/tests/common.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/conftest.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test__env.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_utils.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_docker.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_conditions.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_structures.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/test_subprocess.py 100.00% <0.00%> (ø) ⬆️
datadog_checks_dev/datadog_checks/dev/env.py 43.18% <0.00%> (ø) ⬆️
datadog_checks_dev/tests/tooling/test_dep.py 95.09% <0.00%> (ø) ⬆️
... and 886 more

@florimondmanca florimondmanca merged commit aaecdac into master Feb 12, 2020
@florimondmanca florimondmanca deleted the florimondmanca/integration-template-test-signature branch February 12, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants