Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function call for release testable #5432

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix function call for release testable #5432

merged 1 commit into from
Jan 9, 2020

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Jan 9, 2020

What does this PR do?

get_pr() no longer takes a repo argument.

https://github.com/DataDog/integrations-core/blob/master/datadog_checks_dev/datadog_checks/dev/tooling/github.py#L55

Motivation

ddev release testable would get an unexpected keyword argument:

± |master {5} ✓| → ddev release testable --since 6.16
Branch `6.16.x` will be compared to `origin/master`.
Getting diff... failed!
Local branch `6.16.x` might not exist, trying `origin/6.16.x`... success!
Traceback (most recent call last):
  File "/usr/local/bin/ddev", line 11, in <module>
    load_entry_point('datadog-checks-dev', 'console_scripts', 'ddev')()
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/Users/christine.chen/dev/integrations-core/datadog_checks_dev/datadog_checks/dev/tooling/commands/release/testable.py", line 183, in testable
    api_response = get_pr(commit_id, user_config, repo=repo, raw=True)
TypeError: get_pr() got an unexpected keyword argument 'repo'

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ofek ofek merged commit b9be2ec into master Jan 9, 2020
@ofek ofek deleted the cc/fix-testable branch January 9, 2020 22:34
@ofek ofek changed the title Remove repo reference Fix function call for release testable Jan 9, 2020
AlexandreYang pushed a commit that referenced this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants