Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes and changelog command work with other repos #5331

Merged
merged 6 commits into from
Dec 24, 2019
Merged

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Dec 24, 2019

What does this PR do?

Updates the changes and changelog ddev command to allow it to work with other open-source repositories

Motivation

Gain the ability to use the same autogeneration changelog workflow in other projects 😄

Additional Notes

The command invocation wouldn't change for existing integrations, but for other projects would now let you:

ddev release show changes . (Note the lack of a check name at the end, instead is . which would now default to the current working directory)

and

ddev release changelog . <VERSION> (Note the special . character to denote we're not doing a check but the current directory.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@nmuesch nmuesch requested a review from a team as a code owner December 24, 2019 15:38
@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #5331 into master will decrease coverage by 3.78%.
The diff coverage is 50%.

Impacted Files Coverage Δ
...checks_dev/datadog_checks/dev/tooling/constants.py 96.29% <100%> (+0.14%) ⬆️
...tadog_checks_dev/datadog_checks/dev/tooling/git.py 93.84% <42.85%> (-6.16%) ⬇️
datadog_checks_dev/tests/test_docker.py 48.14% <0%> (-51.86%) ⬇️
datadog_checks_dev/datadog_checks/dev/docker.py 31.42% <0%> (-31.43%) ⬇️
datadog_checks_dev/datadog_checks/dev/env.py 23.07% <0%> (-28.21%) ⬇️
...atadog_checks_dev/datadog_checks/dev/structures.py 67.79% <0%> (-18.65%) ⬇️
datadog_checks_dev/datadog_checks/dev/_env.py 46.15% <0%> (-18.47%) ⬇️
datadog_checks_dev/tests/test_conditions.py 82.25% <0%> (-17.75%) ⬇️
...atadog_checks_dev/datadog_checks/dev/subprocess.py 62.16% <0%> (-16.22%) ⬇️
...atadog_checks_dev/datadog_checks/dev/conditions.py 80.95% <0%> (-4.77%) ⬇️
... and 829 more

@ofek ofek merged commit 45f7600 into master Dec 24, 2019
@ofek ofek deleted the nick/ca branch December 24, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants