Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bean name of directsql_errors metric #5141

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Fix bean name of directsql_errors metric #5141

merged 1 commit into from
Dec 4, 2019

Conversation

florimondmanca
Copy link
Contributor

@florimondmanca florimondmanca commented Dec 4, 2019 •
edited
Loading

Fix for a typo introduced in #5074. (Official Hive docs do list directsql_errors as the bean name, instead of directsql_error.)

@florimondmanca florimondmanca requested review from a team as code owners December 4, 2019 14:23
@AlexandreYang
Copy link
Member

Fix for a typo introduced in #5074. (Official Hive docs do list sqldirect_errors as the bean name, instead of sqldirect_error.)

Typo in desc ? sqldirect_errors => directsql_errors

@florimondmanca
Copy link
Contributor Author

Typo in desc ?

Yes 🤦‍♂ directsql_errors

@florimondmanca florimondmanca merged commit 6bdc227 into master Dec 4, 2019
@florimondmanca florimondmanca deleted the florimondmanca/fix-hive-directsql-errors-metric-name branch December 4, 2019 15:54
therve pushed a commit that referenced this pull request Dec 4, 2019
@florimondmanca @therve
Fix typo in directsql_errors bean name (#5141)
64e68fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes

@therve therve Awaiting requested review from therve

@hithwen hithwen Awaiting requested review from hithwen

Assignees
No one assigned
Labels
integration/hive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florimondmanca @AlexandreYang