Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shlex #5064

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Remove shlex #5064

merged 1 commit into from
Nov 22, 2019

Conversation

AlexandreYang
Copy link
Member

What does this PR do?

Remove shlex

Motivation

Not available on windows.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #5064 into master will increase coverage by 6.26%.
The diff coverage is 100%.

Impacted Files Coverage Δ
gunicorn/datadog_checks/gunicorn/gunicorn.py 84.31% <100%> (-0.16%) ⬇️
gunicorn/tests/test_check.py 88.23% <0%> (ø) ⬆️
gunicorn/datadog_checks/gunicorn/__about__.py 100% <0%> (ø) ⬆️
gunicorn/tests/common.py 100% <0%> (ø) ⬆️
gunicorn/datadog_checks/gunicorn/__init__.py 100% <0%> (ø) ⬆️
gunicorn/tests/test_unit.py 100% <0%> (ø) ⬆️
gunicorn/tests/test_metadata.py 100% <0%> (ø) ⬆️
vertica/tests/metrics.py
...checks_dev/tests/plugin/test_environment_runner.py
... and 855 more

@AlexandreYang AlexandreYang merged commit df47063 into master Nov 22, 2019
@AlexandreYang AlexandreYang deleted the alex/gunicorn_remove_shlex branch November 22, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants